memory leak in sock_hash_update

memory leak in sock_hash_update_common
Status: upstream: reported syz repro on 2019/05/22 15:58
Reported-by: syzbot+30c7a1fc662026545124@syzkaller.appspotmail.com
First crash: 34d, last: 1d13h

Sample crash report:

dy
BUG: memory leak
unreferenced object 0xffff88810dc30340 (size 64):
  comm "softirq", pid 0, jiffies 4294949769 (age 8.870s)
  hex dump (first 32 bytes):
    00 70 f4 14 81 88 ff ff 00 2a c3 1b 82 88 ff ff  .p.......*......
    bf 84 c1 58 00 00 00 00 c0 f2 cc 0d 81 88 ff ff  ...X............
  backtrace:
    [<0000000059c77455>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline]
    [<0000000059c77455>] slab_post_alloc_hook mm/slab.h:439 [inline]
    [<0000000059c77455>] slab_alloc_node mm/slab.c:3269 [inline]
    [<0000000059c77455>] kmem_cache_alloc_node_trace+0x15b/0x2a0 mm/slab.c:3597
    [<00000000a3eee734>] __do_kmalloc_node mm/slab.c:3619 [inline]
    [<00000000a3eee734>] __kmalloc_node+0x38/0x50 mm/slab.c:3627
    [<00000000869e2762>] kmalloc_node include/linux/slab.h:590 [inline]
    [<00000000869e2762>] sock_hash_alloc_elem net/core/sock_map.c:639 [inline]
    [<00000000869e2762>] sock_hash_update_common+0x301/0x540 net/core/sock_map.c:690
    [<00000000ae16fa93>] sock_hash_update_elem+0xf0/0x130 net/core/sock_map.c:739
    [<0000000047230865>] map_update_elem kernel/bpf/syscall.c:925 [inline]
    [<0000000047230865>] __do_sys_bpf+0x19b7/0x1dd0 kernel/bpf/syscall.c:2801
    [<00000000fb5f3bec>] __se_sys_bpf kernel/bpf/syscall.c:2772 [inline]
    [<00000000fb5f3bec>] __x64_sys_bpf+0x1e/0x30 kernel/bpf/syscall.c:2772
    [<000000007b931104>] do_syscall_64+0x76/0x1a0 arch/x86/entry/common.c:301
    [<00000000e7e5ff7d>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

All crashes (7):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	Maintainers
ci-upstream-gce-leak	2019/05/22 12:28	upstream	9c7db500	84b9d384	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-gce-leak	2019/06/24 12:07	upstream	241e3900	472f0082	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-gce-leak	2019/06/21 11:39	upstream	abf02e29	34bf9440	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-gce-leak	2019/06/18 03:20	upstream	9e0babf2	442206d7	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-gce-leak	2019/06/16 20:48	upstream	e01e060f	442206d7	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-gce-leak	2019/05/31 06:52	upstream	20f94496	d9aaf3c2	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com
ci-upstream-gce-leak	2019/05/27 16:15	upstream	cd6c84d8	562efd79	.config	log	report	syz	ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com