possible deadlock in peernet2id

possible deadlock in peernet2id_alloc
Status: upstream: reported on 2020/03/21 09:40
Reported-by: syzbot+3f960c64a104eaa2c813@syzkaller.appspotmail.com
First crash: 77d, last: 21h11m

Sample crash report:
device macsec0 entered promiscuous mode
=====================================================
WARNING: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected
5.7.0-rc7-syzkaller #0 Not tainted
-----------------------------------------------------
syz-executor.1/29072 [HC0[0]:SC0[2]:HE1:SE0] is trying to acquire:
ffff8880886040f0 (&net->nsid_lock){+.+.}-{2:2}, at: spin_lock include/linux/spinlock.h:353 [inline]
ffff8880886040f0 (&net->nsid_lock){+.+.}-{2:2}, at: peernet2id_alloc+0xcd/0x3f0 net/core/net_namespace.c:254

and this task is already holding:
ffff88806079c280 (&dev->addr_list_lock_key#179){+...}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:358 [inline]
ffff88806079c280 (&dev->addr_list_lock_key#179){+...}-{2:2}, at: netif_addr_lock_bh include/linux/netdevice.h:4172 [inline]
ffff88806079c280 (&dev->addr_list_lock_key#179){+...}-{2:2}, at: dev_uc_add+0x1f/0xb0 net/core/dev_addr_lists.c:588
which would create a new lock dependency:
 (&dev->addr_list_lock_key#179){+...}-{2:2} -> (&net->nsid_lock){+.+.}-{2:2}

but this new dependency connects a SOFTIRQ-irq-safe lock:
 (&mc->mca_lock){+.-.}-{2:2}

... which became SOFTIRQ-irq-safe at:
  lock_acquire+0x1f2/0x8f0 kernel/locking/lockdep.c:4934
  __raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
  _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:175
  spin_lock_bh include/linux/spinlock.h:358 [inline]
  mld_send_cr net/ipv6/mcast.c:1953 [inline]
  mld_ifc_timer_expire+0x2b5/0x920 net/ipv6/mcast.c:2477
  call_timer_fn+0x1ac/0x780 kernel/time/timer.c:1405
  expire_timers kernel/time/timer.c:1450 [inline]
  __run_timers kernel/time/timer.c:1774 [inline]
  __run_timers kernel/time/timer.c:1741 [inline]
  run_timer_softirq+0x623/0x1600 kernel/time/timer.c:1787
  __do_softirq+0x26c/0x9f7 kernel/softirq.c:292
  invoke_softirq kernel/softirq.c:373 [inline]
  irq_exit+0x192/0x1d0 kernel/softirq.c:413
  exiting_irq arch/x86/include/asm/apic.h:546 [inline]
  smp_apic_timer_interrupt+0x19e/0x600 arch/x86/kernel/apic/apic.c:1140
  apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:829
  arch_local_irq_restore arch/x86/include/asm/paravirt.h:759 [inline]
  slab_alloc mm/slab.c:3313 [inline]
  kmem_cache_alloc+0x274/0x740 mm/slab.c:3484
  __d_alloc+0x2b/0x8e0 fs/dcache.c:1690
  d_alloc_pseudo+0x19/0x70 fs/dcache.c:1819
  alloc_file_pseudo+0xc6/0x250 fs/file_table.c:225
  sock_alloc_file+0x4f/0x190 net/socket.c:411
  sock_map_fd net/socket.c:435 [inline]
  __sys_socket+0x13d/0x200 net/socket.c:1530
  __do_sys_socket net/socket.c:1535 [inline]
  __se_sys_socket net/socket.c:1533 [inline]
  __x64_sys_socket+0x6f/0xb0 net/socket.c:1533
  do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
  entry_SYSCALL_64_after_hwframe+0x49/0xb3

to a SOFTIRQ-irq-unsafe lock:
 (&net->nsid_lock){+.+.}-{2:2}

... which became SOFTIRQ-irq-unsafe at:
...
  lock_acquire+0x1f2/0x8f0 kernel/locking/lockdep.c:4934
  __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
  _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151
  spin_lock include/linux/spinlock.h:353 [inline]
  unhash_nsid net/core/net_namespace.c:537 [inline]
  cleanup_net+0x2a5/0xa50 net/core/net_namespace.c:585
  process_one_work+0x965/0x16a0 kernel/workqueue.c:2268
  worker_thread+0x96/0xe20 kernel/workqueue.c:2414
  kthread+0x388/0x470 kernel/kthread.c:268
  ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:351

other info that might help us debug this:

Chain exists of:
  &mc->mca_lock --> &dev->addr_list_lock_key#179 --> &net->nsid_lock

 Possible interrupt unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&net->nsid_lock);
                               local_irq_disable();
                               lock(&mc->mca_lock);
                               lock(&dev->addr_list_lock_key#179);
  <Interrupt>
    lock(&mc->mca_lock);

 *** DEADLOCK ***

2 locks held by syz-executor.1/29072:
 #0: ffffffff8a586988 (rtnl_mutex){+.+.}-{3:3}, at: rtnl_lock net/core/rtnetlink.c:72 [inline]
 #0: ffffffff8a586988 (rtnl_mutex){+.+.}-{3:3}, at: rtnetlink_rcv_msg+0x3f9/0xad0 net/core/rtnetlink.c:5451
 #1: ffff88806079c280 (&dev->addr_list_lock_key#179){+...}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:358 [inline]
 #1: ffff88806079c280 (&dev->addr_list_lock_key#179){+...}-{2:2}, at: netif_addr_lock_bh include/linux/netdevice.h:4172 [inline]
 #1: ffff88806079c280 (&dev->addr_list_lock_key#179){+...}-{2:2}, at: dev_uc_add+0x1f/0xb0 net/core/dev_addr_lists.c:588

the dependencies between SOFTIRQ-irq-safe lock and the holding lock:
 -> (&mc->mca_lock){+.-.}-{2:2} {
    HARDIRQ-ON-W at:
                      lock_acquire+0x1f2/0x8f0 kernel/locking/lockdep.c:4934
                      __raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
                      _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:175
                      spin_lock_bh include/linux/spinlock.h:358 [inline]
                      mld_del_delrec+0x344/0x570 net/ipv6/mcast.c:786
                      __ipv6_dev_mc_inc+0x811/0xca0 net/ipv6/mcast.c:930
                      ipv6_add_dev net/ipv6/addrconf.c:455 [inline]
                      ipv6_add_dev+0xa2e/0x10b0 net/ipv6/addrconf.c:365
                      addrconf_init+0xd3/0x39a net/ipv6/addrconf.c:7135
                      inet6_init+0x368/0x705 net/ipv6/af_inet6.c:1072
                      do_one_initcall+0x10a/0x7d0 init/main.c:1196
                      do_initcall_level init/main.c:1269 [inline]
                      do_initcalls init/main.c:1285 [inline]
                      do_basic_setup init/main.c:1305 [inline]
                      kernel_init_freeable+0x501/0x5ae init/main.c:1489
                      kernel_init+0xd/0x1bb init/main.c:1396
                      ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:351
    IN-SOFTIRQ-W at:
                      lock_acquire+0x1f2/0x8f0 kernel/locking/lockdep.c:4934
                      __raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
                      _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:175
                      spin_lock_bh include/linux/spinlock.h:358 [inline]
                      mld_send_cr net/ipv6/mcast.c:1953 [inline]
                      mld_ifc_timer_expire+0x2b5/0x920 net/ipv6/mcast.c:2477
                      call_timer_fn+0x1ac/0x780 kernel/time/timer.c:1405
                      expire_timers kernel/time/timer.c:1450 [inline]
                      __run_timers kernel/time/timer.c:1774 [inline]
                      __run_timers kernel/time/timer.c:1741 [inline]
                      run_timer_softirq+0x623/0x1600 kernel/time/timer.c:1787
                      __do_softirq+0x26c/0x9f7 kernel/softirq.c:292
                      invoke_softirq kernel/softirq.c:373 [inline]
                      irq_exit+0x192/0x1d0 kernel/softirq.c:413
                      exiting_irq arch/x86/include/asm/apic.h:546 [inline]
                      smp_apic_timer_interrupt+0x19e/0x600 arch/x86/kernel/apic/apic.c:1140
                      apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:829
                      arch_local_irq_restore arch/x86/include/asm/paravirt.h:759 [inline]
                      slab_alloc mm/slab.c:3313 [inline]
                      kmem_cache_alloc+0x274/0x740 mm/slab.c:3484
                      __d_alloc+0x2b/0x8e0 fs/dcache.c:1690
                      d_alloc_pseudo+0x19/0x70 fs/dcache.c:1819
                      alloc_file_pseudo+0xc6/0x250 fs/file_table.c:225
                      sock_alloc_file+0x4f/0x190 net/socket.c:411
                      sock_map_fd net/socket.c:435 [inline]
                      __sys_socket+0x13d/0x200 net/socket.c:1530
                      __do_sys_socket net/socket.c:1535 [inline]
                      __se_sys_socket net/socket.c:1533 [inline]
                      __x64_sys_socket+0x6f/0xb0 net/socket.c:1533
                      do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
                      entry_SYSCALL_64_after_hwframe+0x49/0xb3
    INITIAL USE at:
                     lock_acquire+0x1f2/0x8f0 kernel/locking/lockdep.c:4934
                     __raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
                     _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:175
                     spin_lock_bh include/linux/spinlock.h:358 [inline]
                     mld_del_delrec+0x344/0x570 net/ipv6/mcast.c:786
                     __ipv6_dev_mc_inc+0x811/0xca0 net/ipv6/mcast.c:930
                     ipv6_add_dev net/ipv6/addrconf.c:455 [inline]
                     ipv6_add_dev+0xa2e/0x10b0 net/ipv6/addrconf.c:365
                     addrconf_init+0xd3/0x39a net/ipv6/addrconf.c:7135
                     inet6_init+0x368/0x705 net/ipv6/af_inet6.c:1072
                     do_one_initcall+0x10a/0x7d0 init/main.c:1196
                     do_initcall_level init/main.c:1269 [inline]
                     do_initcalls init/main.c:1285 [inline]
                     do_basic_setup init/main.c:1305 [inline]
                     kernel_init_freeable+0x501/0x5ae init/main.c:1489
                     kernel_init+0xd/0x1bb init/main.c:1396
                     ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:351
  }
  ... key      at: [<ffffffff8d22b5e0>] __key.78898+0x0/0x40
  ... acquired at:
   __raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
   _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:175
   spin_lock_bh include/linux/spinlock.h:358 [inline]
   netif_addr_lock_bh include/linux/netdevice.h:4172 [inline]
   __dev_mc_add+0x28/0xd0 net/core/dev_addr_lists.c:765
   igmp6_group_added+0x375/0x420 net/ipv6/mcast.c:672
   __ipv6_dev_mc_inc+0x819/0xca0 net/ipv6/mcast.c:931
   ipv6_add_dev net/ipv6/addrconf.c:458 [inline]
   ipv6_add_dev+0xa3d/0x10b0 net/ipv6/addrconf.c:365
   addrconf_notify+0x89c/0x2270 net/ipv6/addrconf.c:3503
   notifier_call_chain+0xc0/0x230 kernel/notifier.c:83
   call_netdevice_notifiers_info net/core/dev.c:1948 [inline]
   call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1933
   call_netdevice_notifiers_extack net/core/dev.c:1960 [inline]
   call_netdevice_notifiers net/core/dev.c:1974 [inline]
   register_netdevice+0xd70/0x10b0 net/core/dev.c:9435
   macsec_newlink+0x408/0x1320 drivers/net/macsec.c:4048
   __rtnl_newlink+0xf18/0x1590 net/core/rtnetlink.c:3333
   rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3391
   rtnetlink_rcv_msg+0x44e/0xad0 net/core/rtnetlink.c:5454
   netlink_rcv_skb+0x15a/0x410 net/netlink/af_netlink.c:2469
   netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
   netlink_unicast+0x537/0x740 net/netlink/af_netlink.c:1329
   netlink_sendmsg+0x882/0xe10 net/netlink/af_netlink.c:1918
   sock_sendmsg_nosec net/socket.c:652 [inline]
   sock_sendmsg+0xcf/0x120 net/socket.c:672
   __sys_sendto+0x220/0x330 net/socket.c:2000
   __do_sys_sendto net/socket.c:2012 [inline]
   __se_sys_sendto net/socket.c:2008 [inline]
   __x64_sys_sendto+0xdd/0x1b0 net/socket.c:2008
   do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
   entry_SYSCALL_64_after_hwframe+0x49/0xb3

-> (&dev->addr_list_lock_key#179){+...}-{2:2} {
   HARDIRQ-ON-W at:
                    lock_acquire+0x1f2/0x8f0 kernel/locking/lockdep.c:4934
                    __raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
                    _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:175
                    spin_lock_bh include/linux/spinlock.h:358 [inline]
                    netif_addr_lock_bh include/linux/netdevice.h:4172 [inline]
                    __dev_mc_add+0x28/0xd0 net/core/dev_addr_lists.c:765
                    igmp6_group_added+0x375/0x420 net/ipv6/mcast.c:672
                    __ipv6_dev_mc_inc+0x819/0xca0 net/ipv6/mcast.c:931
                    ipv6_add_dev net/ipv6/addrconf.c:458 [inline]
                    ipv6_add_dev+0xa3d/0x10b0 net/ipv6/addrconf.c:365
                    addrconf_notify+0x89c/0x2270 net/ipv6/addrconf.c:3503
                    notifier_call_chain+0xc0/0x230 kernel/notifier.c:83
                    call_netdevice_notifiers_info net/core/dev.c:1948 [inline]
                    call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1933
                    call_netdevice_notifiers_extack net/core/dev.c:1960 [inline]
                    call_netdevice_notifiers net/core/dev.c:1974 [inline]
                    register_netdevice+0xd70/0x10b0 net/core/dev.c:9435
                    macsec_newlink+0x408/0x1320 drivers/net/macsec.c:4048
                    __rtnl_newlink+0xf18/0x1590 net/core/rtnetlink.c:3333
                    rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3391
                    rtnetlink_rcv_msg+0x44e/0xad0 net/core/rtnetlink.c:5454
                    netlink_rcv_skb+0x15a/0x410 net/netlink/af_netlink.c:2469
                    netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
                    netlink_unicast+0x537/0x740 net/netlink/af_netlink.c:1329
                    netlink_sendmsg+0x882/0xe10 net/netlink/af_netlink.c:1918
                    sock_sendmsg_nosec net/socket.c:652 [inline]
                    sock_sendmsg+0xcf/0x120 net/socket.c:672
                    __sys_sendto+0x220/0x330 net/socket.c:2000
                    __do_sys_sendto net/socket.c:2012 [inline]
                    __se_sys_sendto net/socket.c:2008 [inline]
                    __x64_sys_sendto+0xdd/0x1b0 net/socket.c:2008
                    do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
                    entry_SYSCALL_64_after_hwframe+0x49/0xb3
   INITIAL USE at:
                   lock_acquire+0x1f2/0x8f0 kernel/locking/lockdep.c:4934
                   __raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
                   _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:175
                   spin_lock_bh include/linux/spinlock.h:358 [inline]
                   netif_addr_lock_bh include/linux/netdevice.h:4172 [inline]
                   __dev_mc_add+0x28/0xd0 net/core/dev_addr_lists.c:765
                   igmp6_group_added+0x375/0x420 net/ipv6/mcast.c:672
                   __ipv6_dev_mc_inc+0x819/0xca0 net/ipv6/mcast.c:931
                   ipv6_add_dev net/ipv6/addrconf.c:458 [inline]
                   ipv6_add_dev+0xa3d/0x10b0 net/ipv6/addrconf.c:365
                   addrconf_notify+0x89c/0x2270 net/ipv6/addrconf.c:3503
                   notifier_call_chain+0xc0/0x230 kernel/notifier.c:83
                   call_netdevice_notifiers_info net/core/dev.c:1948 [inline]
                   call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1933
                   call_netdevice_notifiers_extack net/core/dev.c:1960 [inline]
                   call_netdevice_notifiers net/core/dev.c:1974 [inline]
                   register_netdevice+0xd70/0x10b0 net/core/dev.c:9435
                   macsec_newlink+0x408/0x1320 drivers/net/macsec.c:4048
                   __rtnl_newlink+0xf18/0x1590 net/core/rtnetlink.c:3333
                   rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3391
                   rtnetlink_rcv_msg+0x44e/0xad0 net/core/rtnetlink.c:5454
                   netlink_rcv_skb+0x15a/0x410 net/netlink/af_netlink.c:2469
                   netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
                   netlink_unicast+0x537/0x740 net/netlink/af_netlink.c:1329
                   netlink_sendmsg+0x882/0xe10 net/netlink/af_netlink.c:1918
                   sock_sendmsg_nosec net/socket.c:652 [inline]
                   sock_sendmsg+0xcf/0x120 net/socket.c:672
                   __sys_sendto+0x220/0x330 net/socket.c:2000
                   __do_sys_sendto net/socket.c:2012 [inline]
                   __se_sys_sendto net/socket.c:2008 [inline]
                   __x64_sys_sendto+0xdd/0x1b0 net/socket.c:2008
                   do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
                   entry_SYSCALL_64_after_hwframe+0x49/0xb3
 }
 ... key      at: [<ffff88806079cb98>] 0xffff88806079cb98
 ... acquired at:
   lock_acquire+0x1f2/0x8f0 kernel/locking/lockdep.c:4934
   __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
   _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151
   spin_lock include/linux/spinlock.h:353 [inline]
   peernet2id_alloc+0xcd/0x3f0 net/core/net_namespace.c:254
   rtnl_fill_link_netnsid net/core/rtnetlink.c:1565 [inline]
   rtnl_fill_ifinfo+0x1e7c/0x39b0 net/core/rtnetlink.c:1751
   rtmsg_ifinfo_build_skb+0xcd/0x1a0 net/core/rtnetlink.c:3699
   rtmsg_ifinfo_event.part.0+0x49/0xe0 net/core/rtnetlink.c:3731
   rtmsg_ifinfo_event net/core/rtnetlink.c:3742 [inline]
   rtmsg_ifinfo+0x7f/0xa0 net/core/rtnetlink.c:3740
   __dev_notify_flags+0x235/0x2c0 net/core/dev.c:8188
   __dev_set_promiscuity+0x191/0x210 net/core/dev.c:7964
   dev_set_promiscuity+0x4f/0xe0 net/core/dev.c:7984
   macsec_dev_change_rx_flags+0x13b/0x170 drivers/net/macsec.c:3582
   dev_change_rx_flags net/core/dev.c:7917 [inline]
   __dev_set_promiscuity.cold+0x2e3/0x340 net/core/dev.c:7961
   __dev_set_rx_mode+0x21f/0x300 net/core/dev.c:8066
   dev_uc_add+0xa1/0xb0 net/core/dev_addr_lists.c:592
   macvlan_open+0x54a/0x8b0 drivers/net/macvlan.c:627
   __dev_open+0x231/0x3c0 net/core/dev.c:1436
   __dev_change_flags+0x4df/0x620 net/core/dev.c:8154
   rtnl_configure_link+0xec/0x250 net/core/rtnetlink.c:3015
   __rtnl_newlink+0xf3f/0x1590 net/core/rtnetlink.c:3351
   rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3391
   rtnetlink_rcv_msg+0x44e/0xad0 net/core/rtnetlink.c:5454
   netlink_rcv_skb+0x15a/0x410 net/netlink/af_netlink.c:2469
   netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
   netlink_unicast+0x537/0x740 net/netlink/af_netlink.c:1329
   netlink_sendmsg+0x882/0xe10 net/netlink/af_netlink.c:1918
   sock_sendmsg_nosec net/socket.c:652 [inline]
   sock_sendmsg+0xcf/0x120 net/socket.c:672
   ____sys_sendmsg+0x6bf/0x7e0 net/socket.c:2362
   ___sys_sendmsg+0x100/0x170 net/socket.c:2416
   __sys_sendmsg+0xec/0x1b0 net/socket.c:2449
   do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
   entry_SYSCALL_64_after_hwframe+0x49/0xb3


the dependencies between the lock to be acquired
 and SOFTIRQ-irq-unsafe lock:
-> (&net->nsid_lock){+.+.}-{2:2} {
   HARDIRQ-ON-W at:
                    lock_acquire+0x1f2/0x8f0 kernel/locking/lockdep.c:4934
                    __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
                    _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151
                    spin_lock include/linux/spinlock.h:353 [inline]
                    unhash_nsid net/core/net_namespace.c:537 [inline]
                    cleanup_net+0x2a5/0xa50 net/core/net_namespace.c:585
                    process_one_work+0x965/0x16a0 kernel/workqueue.c:2268
                    worker_thread+0x96/0xe20 kernel/workqueue.c:2414
                    kthread+0x388/0x470 kernel/kthread.c:268
                    ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:351
   SOFTIRQ-ON-W at:
                    lock_acquire+0x1f2/0x8f0 kernel/locking/lockdep.c:4934
                    __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
                    _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151
                    spin_lock include/linux/spinlock.h:353 [inline]
                    unhash_nsid net/core/net_namespace.c:537 [inline]
                    cleanup_net+0x2a5/0xa50 net/core/net_namespace.c:585
                    process_one_work+0x965/0x16a0 kernel/workqueue.c:2268
                    worker_thread+0x96/0xe20 kernel/workqueue.c:2414
                    kthread+0x388/0x470 kernel/kthread.c:268
                    ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:351
   INITIAL USE at:
                   lock_acquire+0x1f2/0x8f0 kernel/locking/lockdep.c:4934
                   __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
                   _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151
                   spin_lock include/linux/spinlock.h:353 [inline]
                   unhash_nsid net/core/net_namespace.c:537 [inline]
                   cleanup_net+0x2a5/0xa50 net/core/net_namespace.c:585
                   process_one_work+0x965/0x16a0 kernel/workqueue.c:2268
                   worker_thread+0x96/0xe20 kernel/workqueue.c:2414
                   kthread+0x388/0x470 kernel/kthread.c:268
                   ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:351
 }
 ... key      at: [<ffffffff8d203380>] __key.69412+0x0/0x40
 ... acquired at:
   lock_acquire+0x1f2/0x8f0 kernel/locking/lockdep.c:4934
   __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
   _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151
   spin_lock include/linux/spinlock.h:353 [inline]
   peernet2id_alloc+0xcd/0x3f0 net/core/net_namespace.c:254
   rtnl_fill_link_netnsid net/core/rtnetlink.c:1565 [inline]
   rtnl_fill_ifinfo+0x1e7c/0x39b0 net/core/rtnetlink.c:1751
   rtmsg_ifinfo_build_skb+0xcd/0x1a0 net/core/rtnetlink.c:3699
   rtmsg_ifinfo_event.part.0+0x49/0xe0 net/core/rtnetlink.c:3731
   rtmsg_ifinfo_event net/core/rtnetlink.c:3742 [inline]
   rtmsg_ifinfo+0x7f/0xa0 net/core/rtnetlink.c:3740
   __dev_notify_flags+0x235/0x2c0 net/core/dev.c:8188
   __dev_set_promiscuity+0x191/0x210 net/core/dev.c:7964
   dev_set_promiscuity+0x4f/0xe0 net/core/dev.c:7984
   macsec_dev_change_rx_flags+0x13b/0x170 drivers/net/macsec.c:3582
   dev_change_rx_flags net/core/dev.c:7917 [inline]
   __dev_set_promiscuity.cold+0x2e3/0x340 net/core/dev.c:7961
   __dev_set_rx_mode+0x21f/0x300 net/core/dev.c:8066
   dev_uc_add+0xa1/0xb0 net/core/dev_addr_lists.c:592
   macvlan_open+0x54a/0x8b0 drivers/net/macvlan.c:627
   __dev_open+0x231/0x3c0 net/core/dev.c:1436
   __dev_change_flags+0x4df/0x620 net/core/dev.c:8154
   rtnl_configure_link+0xec/0x250 net/core/rtnetlink.c:3015
   __rtnl_newlink+0xf3f/0x1590 net/core/rtnetlink.c:3351
   rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3391
   rtnetlink_rcv_msg+0x44e/0xad0 net/core/rtnetlink.c:5454
   netlink_rcv_skb+0x15a/0x410 net/netlink/af_netlink.c:2469
   netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
   netlink_unicast+0x537/0x740 net/netlink/af_netlink.c:1329
   netlink_sendmsg+0x882/0xe10 net/netlink/af_netlink.c:1918
   sock_sendmsg_nosec net/socket.c:652 [inline]
   sock_sendmsg+0xcf/0x120 net/socket.c:672
   ____sys_sendmsg+0x6bf/0x7e0 net/socket.c:2362
   ___sys_sendmsg+0x100/0x170 net/socket.c:2416
   __sys_sendmsg+0xec/0x1b0 net/socket.c:2449
   do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
   entry_SYSCALL_64_after_hwframe+0x49/0xb3


stack backtrace:
CPU: 0 PID: 29072 Comm: syz-executor.1 Not tainted 5.7.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x188/0x20d lib/dump_stack.c:118
 print_bad_irq_dependency kernel/locking/lockdep.c:2132 [inline]
 check_irq_usage.cold+0x566/0x6de kernel/locking/lockdep.c:2330
 check_prev_add kernel/locking/lockdep.c:2519 [inline]
 check_prevs_add kernel/locking/lockdep.c:2620 [inline]
 validate_chain kernel/locking/lockdep.c:3237 [inline]
 __lock_acquire+0x2ac9/0x4c50 kernel/locking/lockdep.c:4355
 lock_acquire+0x1f2/0x8f0 kernel/locking/lockdep.c:4934
 __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
 _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151
 spin_lock include/linux/spinlock.h:353 [inline]
 peernet2id_alloc+0xcd/0x3f0 net/core/net_namespace.c:254
 rtnl_fill_link_netnsid net/core/rtnetlink.c:1565 [inline]
 rtnl_fill_ifinfo+0x1e7c/0x39b0 net/core/rtnetlink.c:1751
 rtmsg_ifinfo_build_skb+0xcd/0x1a0 net/core/rtnetlink.c:3699
 rtmsg_ifinfo_event.part.0+0x49/0xe0 net/core/rtnetlink.c:3731
 rtmsg_ifinfo_event net/core/rtnetlink.c:3742 [inline]
 rtmsg_ifinfo+0x7f/0xa0 net/core/rtnetlink.c:3740
 __dev_notify_flags+0x235/0x2c0 net/core/dev.c:8188
 __dev_set_promiscuity+0x191/0x210 net/core/dev.c:7964
 dev_set_promiscuity+0x4f/0xe0 net/core/dev.c:7984
 macsec_dev_change_rx_flags+0x13b/0x170 drivers/net/macsec.c:3582
 dev_change_rx_flags net/core/dev.c:7917 [inline]
 __dev_set_promiscuity.cold+0x2e3/0x340 net/core/dev.c:7961
 __dev_set_rx_mode+0x21f/0x300 net/core/dev.c:8066
 dev_uc_add+0xa1/0xb0 net/core/dev_addr_lists.c:592
 macvlan_open+0x54a/0x8b0 drivers/net/macvlan.c:627
 __dev_open+0x231/0x3c0 net/core/dev.c:1436
 __dev_change_flags+0x4df/0x620 net/core/dev.c:8154
 rtnl_configure_link+0xec/0x250 net/core/rtnetlink.c:3015
 __rtnl_newlink+0xf3f/0x1590 net/core/rtnetlink.c:3351
 rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3391
 rtnetlink_rcv_msg+0x44e/0xad0 net/core/rtnetlink.c:5454
 netlink_rcv_skb+0x15a/0x410 net/netlink/af_netlink.c:2469
 netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
 netlink_unicast+0x537/0x740 net/netlink/af_netlink.c:1329
 netlink_sendmsg+0x882/0xe10 net/netlink/af_netlink.c:1918
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:672
 ____sys_sendmsg+0x6bf/0x7e0 net/socket.c:2362
 ___sys_sendmsg+0x100/0x170 net/socket.c:2416
 __sys_sendmsg+0xec/0x1b0 net/socket.c:2449
 do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
 entry_SYSCALL_64_after_hwframe+0x49/0xb3
RIP: 0033:0x45ca69
Code: 0d b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 db b6 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fcfbfa49c78 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000000000500f80 RCX: 000000000045ca69
RDX: 0000000000000000 RSI: 0000000020000080 RDI: 0000000000000004
RBP: 000000000078bf00 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00000000ffffffff
R13: 0000000000000a04 R14: 00000000004cce0c R15: 00007fcfbfa4a6d4
Crashes (4):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Maintainers
ci-upstream-net-this-kasan-gce	2020/06/02 04:53	net	bdc48fa1	a0331e89	.config	log	report	davem@davemloft.net, dhowells@redhat.com, edumazet@google.com, gnault@redhat.com, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, nicolas.dichtel@6wind.com
ci-upstream-net-this-kasan-gce	2020/05/11 01:15	net	090e28b2	8742a2b9	.config	log	report	davem@davemloft.net, dhowells@redhat.com, edumazet@google.com, gnault@redhat.com, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, nicolas.dichtel@6wind.com
ci-upstream-net-kasan-gce	2020/05/24 05:07	net-next	54b9aca0	96c92ad3	.config	log	report	davem@davemloft.net, dhowells@redhat.com, edumazet@google.com, gnault@redhat.com, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, nicolas.dichtel@6wind.com
ci-upstream-net-kasan-gce	2020/03/17 09:30	net-next	86e85bf6	749688d2	.config	log	report	davem@davemloft.net, dhowells@redhat.com, edumazet@google.com, gnault@redhat.com, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, nicolas.dichtel@6wind.com