general protection fault in fq_codel_enqueue

Status: fixed on 2020/07/17 17:58
Subsystems: net
[Documentation on labels]
Fix commit: 9274124f023b net: stricter validation of untrusted gso packets
First crash: 2293d, last: 2208d
Cause bisection: introduced by (bisect log) :
commit 7170e6045a6a8b33f4fa5753589dc77b16198e2d
Author: Doron Roberts-Kedes <doronrk@fb.com>
Date: Wed Jun 6 16:33:28 2018 +0000

  strparser: Add __strp_unpause and use it in ktls.

Crash: general protection fault in batadv_iv_ogm_queue_add (log)
Repro: C syz .config
  
▶ ▼ Similar bugs (13)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream general protection fault in fq_codel_enqueue (3) net 2 syz, C inconclusive 5 1489d 1735d 22/29 fixed on 2023/02/24 13:50
linux-4.19 general protection fault in fq_codel_enqueue 2 syz, C done 5 2260d 2288d 1/1 fixed on 2020/06/21 14:03
linux-6.1 BUG: unable to handle kernel paging request in fq_codel_enqueue 8 13 312d 362d 0/3 auto-obsoleted due to no activity on 2025/11/29 22:34
linux-6.1 BUG: unable to handle kernel paging request in fq_codel_enqueue (2) 8 11 3d02h 92d 0/3 upstream: reported on 2026/04/29 00:07
linux-4.19 general protection fault in fq_codel_enqueue (2) 2 syz, C error 14 1430d 2161d 0/1 upstream: reported C repro on 2020/08/28 22:42
linux-5.15 general protection fault in fq_codel_enqueue (2) origin:lts-only 2 syz, C 11 2d14h 92d 0/3 upstream: reported C repro on 2026/04/29 01:27
android-5-10 general protection fault in fq_codel_enqueue (2) 2 2 829d 831d 0/2 auto-obsoleted due to no activity on 2024/07/20 23:55
android-5-15 general protection fault in fq_codel_enqueue 2 1 859d 859d 0/2 auto-obsoleted due to no activity on 2024/06/21 01:28
linux-6.1 general protection fault in fq_codel_enqueue 2 1 196d 196d 0/3 auto-obsoleted due to no activity on 2026/04/25 11:32
linux-4.14 general protection fault in fq_codel_enqueue 2 syz, C inconclusive 6 1692d 2284d 0/1 upstream: reported C repro on 2020/04/27 21:56
linux-5.15 general protection fault in fq_codel_enqueue 2 3 230d 358d 0/3 auto-obsoleted due to no activity on 2026/03/21 20:16
upstream general protection fault in fq_codel_enqueue (2) 2 syz, C done 34 1762d 2161d 0/29 closed as invalid on 2021/10/07 21:22
android-5-10 general protection fault in fq_codel_enqueue 2 1 1463d 1463d 0/2 auto-obsoleted due to no activity on 2022/10/25 22:19

Sample crash report:
general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN
KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
CPU: 0 PID: 7036 Comm: syz-executor027 Not tainted 5.7.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:dequeue_head net/sched/sch_fq_codel.c:120 [inline]
RIP: 0010:fq_codel_drop net/sched/sch_fq_codel.c:168 [inline]
RIP: 0010:fq_codel_enqueue+0xa75/0x11b0 net/sched/sch_fq_codel.c:230
Code: 27 fb 44 3b 64 24 70 0f 83 dd 00 00 00 e8 d3 70 27 fb 48 8b 44 24 40 80 38 00 0f 85 5a 05 00 00 49 8b 06 48 89 c2 48 c1 ea 03 <42> 80 3c 2a 00 0f 85 52 05 00 00 48 8b 10 49 89 16 48 89 c2 48 c1
RSP: 0018:ffffc900010976a0 EFLAGS: 00010246
RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffc90001097880
RDX: 0000000000000000 RSI: ffffffff864bcddd RDI: 0000000000000000
RBP: ffffc900010977b0 R08: ffff88808bee62c0 R09: fffffbfff185df44
R10: ffffffff8c2efa1f R11: fffffbfff185df43 R12: 0000000000000400
R13: dffffc0000000000 R14: ffff888086240000 R15: ffffc90001097880
FS:  0000000002055880(0000) GS:ffff8880ae600000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020000100 CR3: 0000000094c8e000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 __dev_xmit_skb net/core/dev.c:3710 [inline]
 __dev_queue_xmit+0x154a/0x30a0 net/core/dev.c:4021
 packet_snd net/packet/af_packet.c:2979 [inline]
 packet_sendmsg+0x24fd/0x5e90 net/packet/af_packet.c:3004
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:672
 sock_write_iter+0x289/0x3c0 net/socket.c:1004
 call_write_iter include/linux/fs.h:1907 [inline]
 new_sync_write+0x4a2/0x700 fs/read_write.c:484
 __vfs_write+0xc9/0x100 fs/read_write.c:497
 vfs_write+0x268/0x5d0 fs/read_write.c:559
 ksys_write+0x1ee/0x250 fs/read_write.c:612
 do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
 entry_SYSCALL_64_after_hwframe+0x49/0xb3
RIP: 0033:0x440599
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 fb 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fff444744f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00000000004a173e RCX: 0000000000440599
RDX: 000000000000006c RSI: 00000000200003c0 RDI: 0000000000000005
RBP: 54c6c2ff093a6d32 R08: 00000000004002c8 R09: 00000000004002c8
R10: 00000000004002c8 R11: 0000000000000246 R12: 0000000000010000
R13: 0000000000401eb0 R14: 0000000000000000 R15: 0000000000000000
Modules linked in:
---[ end trace 6ca6d2b81633e941 ]---
RIP: 0010:dequeue_head net/sched/sch_fq_codel.c:120 [inline]
RIP: 0010:fq_codel_drop net/sched/sch_fq_codel.c:168 [inline]
RIP: 0010:fq_codel_enqueue+0xa75/0x11b0 net/sched/sch_fq_codel.c:230
Code: 27 fb 44 3b 64 24 70 0f 83 dd 00 00 00 e8 d3 70 27 fb 48 8b 44 24 40 80 38 00 0f 85 5a 05 00 00 49 8b 06 48 89 c2 48 c1 ea 03 <42> 80 3c 2a 00 0f 85 52 05 00 00 48 8b 10 49 89 16 48 89 c2 48 c1
RSP: 0018:ffffc900010976a0 EFLAGS: 00010246
RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffc90001097880
RDX: 0000000000000000 RSI: ffffffff864bcddd RDI: 0000000000000000
RBP: ffffc900010977b0 R08: ffff88808bee62c0 R09: fffffbfff185df44
R10: ffffffff8c2efa1f R11: fffffbfff185df43 R12: 0000000000000400
R13: dffffc0000000000 R14: ffff888086240000 R15: ffffc90001097880
FS:  0000000002055880(0000) GS:ffff8880ae600000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020000100 CR3: 0000000094c8e000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Crashes (25):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/05/25 11:41 upstream 9cb1fd0efd19 11284182 .config console log report syz C ci-upstream-kasan-gce-root
2020/05/25 11:07 upstream 9cb1fd0efd19 11284182 .config console log report syz C ci-upstream-kasan-gce-selinux-root
2020/05/24 11:24 upstream 423b8baf18a8 96c92ad3 .config console log report syz C ci-upstream-kasan-gce-smack-root
2020/05/22 10:49 upstream d2f8825ab78e 5afa2ddd .config console log report syz C ci-upstream-kasan-gce
2020/04/24 09:21 upstream c578ddb39e56 2e44d63e .config console log report syz C ci-upstream-kasan-gce
2020/04/24 07:40 upstream c578ddb39e56 2e44d63e .config console log report syz C ci-upstream-kasan-gce-root
2020/05/22 10:45 upstream d2f8825ab78e 5afa2ddd .config console log report syz C ci-upstream-kasan-gce-386
2020/04/24 10:24 upstream c578ddb39e56 2e44d63e .config console log report syz C ci-upstream-kasan-gce-386
2020/05/22 10:46 net-old 57ebc8f08504 5afa2ddd .config console log report syz C ci-upstream-net-this-kasan-gce
2020/04/24 10:19 net-old 63edbcceef61 2e44d63e .config console log report syz C ci-upstream-net-this-kasan-gce
2020/05/22 10:47 net-next-old 2a330b533462 5afa2ddd .config console log report syz C ci-upstream-net-kasan-gce
2020/04/24 10:09 net-next-old b86a0373855b 2e44d63e .config console log report syz C ci-upstream-net-kasan-gce
2020/05/22 10:52 linux-next ac935d227366 5afa2ddd .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2020/05/11 11:05 linux-next ac935d227366 f8f57555 .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2020/07/13 01:20 upstream 4437dd6e8f71 9ebcc5b1 .config console log report ci-upstream-kasan-gce
2020/05/04 21:40 upstream 9851a0dee7c2 9941337c .config console log report ci-upstream-kasan-gce
2020/04/24 05:49 upstream c578ddb39e56 2e44d63e .config console log report ci-upstream-kasan-gce-root
2020/04/19 09:01 upstream 50cc09c18985 365fba24 .config console log report ci-upstream-kasan-gce
2020/05/06 10:20 net-old 38212bb31fe9 35b8eb30 .config console log report ci-upstream-net-this-kasan-gce
2020/04/29 20:29 net-old 981230749123 496a08ae .config console log report ci-upstream-net-this-kasan-gce
2020/04/24 12:30 net-old 7c74b0bec918 03d97a1b .config console log report ci-upstream-net-this-kasan-gce
2020/04/19 11:14 net-old 441870ee4240 365fba24 .config console log report ci-upstream-net-this-kasan-gce
2020/04/30 14:28 net-next-old 323e395f197f 3698959a .config console log report ci-upstream-net-kasan-gce
2020/07/10 20:26 linux-next b966b5cf7179 edf162e8 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/04/24 10:54 linux-next ac935d227366 2e44d63e .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.