WARNING in slave_kobj

WARNING in slave_kobj_release
Status: upstream: reported C repro on 2021/02/16 16:57
Reported-by: syzbot+bfda097c12a00c8cae67@syzkaller.appspotmail.com
Fix commit: 35d96e631860 bonding: init notify_work earlier to avoid uninitialized use
Patched on: [ci-qemu-upstream ci-qemu-upstream-386 ci-qemu2-arm64 ci-qemu2-arm64-compat ci-qemu2-arm64-mte ci-qemu2-riscv64 ci-upstream-bpf-kasan-gce ci-upstream-bpf-next-kasan-gce ci-upstream-gce-leak ci-upstream-kasan-gce ci-upstream-kasan-gce-386 ci-upstream-kasan-gce-root ci-upstream-kasan-gce-selinux-root ci-upstream-kasan-gce-smack-root ci-upstream-kmsan-gce ci-upstream-kmsan-gce-386 ci-upstream-linux-next-kasan-gce-root ci-upstream-net-kasan-gce ci-upstream-net-this-kasan-gce ci2-upstream-kcsan-gce ci2-upstream-usb], missing on: [ci-qemu2-arm32]
First crash: 162d, last: 74d

Cause bisection: introduced by (bisect log) :
commit dcd479e10a0510522a5d88b29b8f79ea3467d501
Author: Johannes Berg <johannes.berg@intel.com>
Date: Fri Oct 9 12:17:11 2020 +0000

mac80211: always wind down STA state

Crash: BUG: sleeping function called from invalid context in sta_info_move_state (log)
Repro: C syz .config

Patch testing requests:
Created	Duration	User	Patch	Repo	Result
2021/02/21 17:34	22m	pvalerio@redhat.com		git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git master	report log

Sample crash report:

R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffd2f280090
R13: 00007ffd2f2800b0 R14: 00007ffd2f280088 R15: 0000000000000000
kobject_add_internal failed for bonding_slave (error: -12 parent: ipvlan1)
------------[ cut here ]------------
ODEBUG: assert_init not available (active state 0) object type: timer_list hint: 0x0
WARNING: CPU: 0 PID: 8425 at lib/debugobjects.c:508 debug_print_object lib/debugobjects.c:505 [inline]
WARNING: CPU: 0 PID: 8425 at lib/debugobjects.c:508 debug_object_assert_init+0x1fa/0x250 lib/debugobjects.c:890
Modules linked in:
CPU: 0 PID: 8425 Comm: syz-executor866 Not tainted 5.11.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:debug_print_object lib/debugobjects.c:505 [inline]
RIP: 0010:debug_object_assert_init+0x1fa/0x250 lib/debugobjects.c:890
Code: e8 3b 17 ee fd 4c 8b 45 00 48 c7 c7 40 dc 0d 8a 48 c7 c6 a0 d8 0d 8a 48 c7 c2 80 de 0d 8a 31 c9 49 89 d9 31 c0 e8 66 17 7a fd <0f> 0b ff 05 5a 89 e6 09 48 83 c5 38 48 89 e8 48 c1 e8 03 42 80 3c
RSP: 0018:ffffc90001afeda8 EFLAGS: 00010046
RAX: 2bba7eb7734aa500 RBX: 0000000000000000 RCX: ffff888020a30000
RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000
RBP: ffffffff89b0ac20 R08: ffffffff815fb522 R09: ffffed1017384004
R10: ffffed1017384004 R11: 0000000000000000 R12: dffffc0000000000
R13: ffff888024ccb940 R14: 0000000000000000 R15: ffffffff9020efa8
FS:  00000000019db300(0000) GS:ffff8880b9c00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fb44efdf000 CR3: 00000000120f2000 CR4: 00000000001506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 debug_timer_assert_init kernel/time/timer.c:737 [inline]
 debug_assert_init kernel/time/timer.c:782 [inline]
 del_timer+0x3d/0x310 kernel/time/timer.c:1202
 try_to_grab_pending+0xbd/0x9e0 kernel/workqueue.c:1252
 __cancel_work_timer+0x84/0x540 kernel/workqueue.c:3098
 slave_kobj_release+0x50/0xd0 drivers/net/bonding/bond_main.c:1467
 kobject_cleanup+0x1c9/0x280 lib/kobject.c:705
 bond_kobj_init drivers/net/bonding/bond_main.c:1488 [inline]
 bond_alloc_slave drivers/net/bonding/bond_main.c:1505 [inline]
 bond_enslave+0x630/0x57e0 drivers/net/bonding/bond_main.c:1707
 do_set_master net/core/rtnetlink.c:2519 [inline]
 do_setlink+0xcf6/0x3d00 net/core/rtnetlink.c:2715
 __rtnl_newlink net/core/rtnetlink.c:3376 [inline]
 rtnl_newlink+0x146b/0x1b00 net/core/rtnetlink.c:3491
 rtnetlink_rcv_msg+0x887/0xd60 net/core/rtnetlink.c:5553
 netlink_rcv_skb+0x190/0x3a0 net/netlink/af_netlink.c:2494
 netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline]
 netlink_unicast+0x786/0x940 net/netlink/af_netlink.c:1330
 netlink_sendmsg+0x9ae/0xd50 net/netlink/af_netlink.c:1919
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg net/socket.c:672 [inline]
 ____sys_sendmsg+0x519/0x800 net/socket.c:2345
 ___sys_sendmsg net/socket.c:2399 [inline]
 __sys_sendmsg+0x2bf/0x370 net/socket.c:2432
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x4498e9
Code: 4f 01 00 85 c0 b8 00 00 00 00 48 0f 44 c3 5b c3 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd2f280058 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000000000000004 RCX: 00000000004498e9
RDX: 0000000000000000 RSI: 00000000200001c0 RDI: 0000000000000004
RBP: 0000000000000004 R08: 0000000000000001 R09: 000000000000000a
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffd2f280090
R13: 00007ffd2f2800b0 R14: 00007ffd2f280088 R15: 0000000000000000

Fix bisection attempts:
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	VM info	Title
ci-upstream-kasan-gce-smack-root	2021/05/16 04:11	upstream	63d1cb53e26a	98682e5e	.config	log	report	syz	C
ci-upstream-kasan-gce-smack-root	2021/03/18 14:45	upstream	6417f03132a6	98682e5e	.config	log	report	syz	C

Crashes (3):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	VM info	Title
ci-upstream-kasan-gce-smack-root	2021/02/16 14:04	upstream	f40ddce88593	98682e5e	.config	log	report	syz	C		WARNING in slave_kobj_release
ci-upstream-kasan-gce-smack-root	2021/04/16 03:49	upstream	7e25f40eab52	c59079a6	.config	log	report			info	WARNING in slave_kobj_release
ci-upstream-kasan-gce-smack-root	2021/02/16 13:44	upstream	f40ddce88593	98682e5e	.config	log	report			info	WARNING in slave_kobj_release