KCSAN: data-race in __trace_trigger_soft_disabled / apply_subsystem_event_filter

Status: moderation: reported on 2026/11/21 01:42
Subsystems: trace
Labels: prio:low race:harmful
[Documentation on labels]
Reported-by: syzbot+802d5ce90f309ada0a13@syzkaller.appspotmail.com
First crash: 2h40m, last: 2h40m
✨ AI-generated root cause summary:

filter_disable() (and its counterpart event_set_filtered_flag()) in kernel/trace/trace_events_filter.c updates struct trace_event_file::flags using non-atomic read-modify-write operations (file->flags &= ~EVENT_FILE_FL_FILTERED) instead of atomic bit operations (test_and_clear_bit()/test_and_set_bit()). Meanwhile, tracepoint handlers such as trace_trigger_soft_disabled() and __trace_trigger_soft_disabled() read file->flags locklessly without READ_ONCE(). Writing a failing subsystem filter via subsystem_filter_write() triggers filter_disable() while sched_switch concurrently executes __trace_trigger_soft_disabled() on another CPU, causing a KCSAN data race on file->flags.

▶ ▼ ✨ Full AI root cause analysis
Based on kernel commit d0f871bfb831:

Root Cause Analysis

The KCSAN data race occurs on the flags field (unsigned long flags) of struct trace_event_file (include/linux/trace_events.h:680) between a non-atomic write in filter_disable() and a lockless read in __trace_trigger_soft_disabled().

1. Non-atomic bit updates in kernel/trace/trace_events_filter.c

As documented in struct trace_event_file (include/linux/trace_events.h:672-678):

"The bits must be set atomically to prevent races from other writers. Reads of flags do not need to be in sync as they occur in critical sections."

While other subsystems (kernel/trace/trace_events.c, kernel/trace/trace_events_trigger.c) use set_bit() / clear_bit() to update file->flags, filter_disable() (kernel/trace/trace_events_filter.c:1321-1329) and event_set_filtered_flag() (kernel/trace/trace_events_filter.c:2288-2296) perform plain non-atomic read-modify-write operations:

static void filter_disable(struct trace_event_file *file)
{
	unsigned long old_flags = file->flags;

	file->flags &= ~EVENT_FILE_FL_FILTERED;

	if (old_flags != file->flags)
		trace_buffered_event_disable();
}
static inline void event_set_filtered_flag(struct trace_event_file *file)
{
	unsigned long old_flags = file->flags;

	file->flags |= EVENT_FILE_FL_FILTERED;

	if (old_flags != file->flags)
		trace_buffered_event_enable();
}

In addition to racing with lockless tracepoint readers, these non-atomic RMW sequences can race with event_enable_trigger() (kernel/trace/trace_events_trigger.c:1670-1680), which calls set_bit() / clear_bit() on EVENT_FILE_FL_SOFT_DISABLED_BIT in tracepoint context without holding event_mutex. That can cause lost updates to EVENT_FILE_FL_SOFT_DISABLED_BIT or cause old_flags != file->flags to evaluate true spuriously and miscount trace_buffered_event_ref.

2. Unmarked lockless reads in tracepoint paths

On the reader side, tracepoint handlers execute without holding event_mutex and read file->flags with plain loads rather than READ_ONCE():

3. Triggering Sequence

  1. CPU 0 (writer): Task 5433 writes a filter string to a tracefs subsystem filter file (subsystem_filter_write() -> apply_subsystem_event_filter(), acquiring event_mutex). create_system_filter() -> process_system_preds() (kernel/trace/trace_events_filter.c:2329-2331) iterates over events in the subsystem (dir); when process_preds() returns an error for an event, it invokes filter_disable(file), which writes file->flags &= ~EVENT_FILE_FL_FILTERED at kernel/trace/trace_events_filter.c:1325.
  2. CPU 1 (reader): Concurrently, task 5440 hits the sched_switch tracepoint (__schedule() -> trace_event_raw_event_sched_switch() -> trace_trigger_soft_disabled() -> __trace_trigger_soft_disabled()), reading file->flags at kernel/trace/trace_events_trigger.c:217 without event_mutex or READ_ONCE().

Fix Direction

  • Replace the non-atomic RMW in filter_disable() and event_set_filtered_flag() (kernel/trace/trace_events_filter.c) with test_and_clear_bit(EVENT_FILE_FL_FILTERED_BIT, &file->flags) and test_and_set_bit(EVENT_FILE_FL_FILTERED_BIT, &file->flags).
  • Use READ_ONCE(file->flags) (or data_race() / test_bit()) in lockless readers such as trace_trigger_soft_disabled() (include/linux/trace_events.h) and __trace_trigger_soft_disabled() (kernel/trace/trace_events_trigger.c), as well as __event_trigger_test_discard() and trace_event_buffer_lock_reserve().
▶ ▼ ✨ AI Jobs (2)
ID Workflow Result Correct Bug Created Started Finished Revision
1a3b51fe assessment-security DenialOfService: ❌ Exploitable: ❌ FilesystemTrigger: ❌ FuzzingArtifact: ❌ MemoryCorruption: ❌ NetworkNeedsSetup: ❌ NetworkTrigger: ❌ PeripheralTrigger: ❌ RemoteTrigger: ❌ Unprivileged: ❌ UserNamespace: ❌ VMGuestTrigger: ❌ VMHostTrigger: ❌ ❓ KCSAN: data-race in __trace_trigger_soft_disabled / apply_subsystem_event_filter 2026/11/21 01:18 2026/11/21 01:18 2026/11/21 01:22 60a1d40d
d7eba4fe assessment-kcsan Benign: ❌ ❓ KCSAN: data-race in __trace_trigger_soft_disabled / apply_subsystem_event_filter 2026/11/21 01:17 2026/11/21 01:17 2026/11/21 01:41 60a1d40d

Sample crash report:
==================================================================
BUG: KCSAN: data-race in __trace_trigger_soft_disabled / apply_subsystem_event_filter

write to 0xffff888100172888 of 8 bytes by task 5433 on cpu 0:
 filter_disable kernel/trace/trace_events_filter.c:1325 [inline]
 process_system_preds kernel/trace/trace_events_filter.c:2331 [inline]
 create_system_filter kernel/trace/trace_events_filter.c:2486 [inline]
 apply_subsystem_event_filter+0x28f/0xcd0 kernel/trace/trace_events_filter.c:2574
 subsystem_filter_write+0x79/0xd0 kernel/trace/trace_events.c:2523
 vfs_write+0x24f/0x9b0 fs/read_write.c:665
 ksys_write+0xdc/0x1a0 fs/read_write.c:719
 __do_sys_write fs/read_write.c:730 [inline]
 __se_sys_write fs/read_write.c:727 [inline]
 __x64_sys_write+0x40/0x50 fs/read_write.c:727
 x64_sys_call+0x154e/0x2550 arch/x86/include/generated/asm/syscalls_64.h:2
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x11e/0x3a0 arch/x86/entry/syscall_64.c:89
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

read to 0xffff888100172888 of 8 bytes by task 5440 on cpu 1:
 __trace_trigger_soft_disabled+0x20/0x1a0 kernel/trace/trace_events_trigger.c:217
 trace_trigger_soft_disabled include/linux/trace_events.h:777 [inline]
 do_trace_event_raw_event_sched_switch include/trace/events/sched.h:220 [inline]
 trace_event_raw_event_sched_switch+0x186/0x1a0 include/trace/events/sched.h:220
 __traceiter_sched_switch+0x3f/0x60 include/trace/events/sched.h:220
 __do_trace_sched_switch include/trace/events/sched.h:220 [inline]
 trace_sched_switch include/trace/events/sched.h:220 [inline]
 __schedule+0xc3d/0xd30 kernel/sched/core.c:7383
 preempt_schedule_common+0x12/0x40 kernel/sched/core.c:7565
 preempt_schedule_thunk+0x16/0x40 arch/x86/entry/thunk.S:12
 __raw_spin_unlock include/linux/spinlock_api_smp.h:201 [inline]
 _raw_spin_unlock+0x1e/0x30 kernel/locking/spinlock.c:213
 spin_unlock include/linux/spinlock.h:401 [inline]
 zap_pte_range mm/memory.c:2076 [inline]
 zap_pmd_range mm/memory.c:2134 [inline]
 zap_pud_range mm/memory.c:2162 [inline]
 zap_p4d_range mm/memory.c:2183 [inline]
 __zap_vma_range+0x273e/0x2ed0 mm/memory.c:2223
 unmap_vmas+0x216/0x310 mm/memory.c:2292
 exit_mmap+0x1a2/0x650 mm/mmap.c:1315
 __mmput+0x28/0x1f0 kernel/fork.c:1192
 mmput+0x51/0x60 kernel/fork.c:1215
 exit_mm+0x12d/0x1d0 kernel/exit.c:586
 do_exit+0x44a/0x1530 kernel/exit.c:967
 do_group_exit+0xfe/0x140 kernel/exit.c:1123
 get_signal+0xc49/0xd30 kernel/signal.c:3113
 arch_do_signal_or_restart+0x96/0x480 arch/x86/kernel/signal.c:337
 __exit_to_user_mode_loop kernel/entry/common.c:66 [inline]
 exit_to_user_mode_loop+0x161/0x940 kernel/entry/common.c:101
 __exit_to_user_mode_prepare include/linux/irq-entry-common.h:207 [inline]
 syscall_exit_to_user_mode_prepare include/linux/irq-entry-common.h:230 [inline]
 syscall_exit_to_user_mode include/linux/entry-common.h:343 [inline]
 do_syscall_64+0x23b/0x3a0 arch/x86/entry/syscall_64.c:107
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

Reported by Kernel Concurrency Sanitizer on:
CPU: 1 UID: 0 PID: 5440 Comm: syz.1.454 Not tainted syzkaller #0 PREEMPT(lazy) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/06/2026
==================================================================

Crashes (1):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2026/11/21 00:18 upstream d0f871bfb831 b2c69459 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in __trace_trigger_soft_disabled / apply_subsystem_event_filter
* Struck through repros no longer work on HEAD.