syzbot


KASAN: use-after-free Write in dst_release

Status: fixed on 2018/05/08 18:30
Subsystems: net
[Documentation on labels]
Fix commit: bfacfb457b36 pptp: remove a buggy dst release in pptp_connect()
First crash: 2212d, last: 2202d
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream KASAN: use-after-free Write in dst_release (2) net C 3 2090d 2091d 8/26 fixed on 2018/08/08 18:10

Sample crash report:
==================================================================
BUG: KASAN: use-after-free in atomic_dec_return include/asm-generic/atomic-instrumented.h:198 [inline]
BUG: KASAN: use-after-free in dst_release+0x27/0xa0 net/core/dst.c:185
Write of size 4 at addr ffff8801c6959e40 by task syzkaller871835/5987

CPU: 1 PID: 5987 Comm: syzkaller871835 Not tainted 4.16.0+ #11
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x1a7/0x27d lib/dump_stack.c:53
 print_address_description+0x73/0x250 mm/kasan/report.c:256
 kasan_report_error mm/kasan/report.c:354 [inline]
 kasan_report+0x23c/0x360 mm/kasan/report.c:412
 check_memory_region_inline mm/kasan/kasan.c:260 [inline]
 check_memory_region+0x137/0x190 mm/kasan/kasan.c:267
 kasan_check_write+0x14/0x20 mm/kasan/kasan.c:278
 atomic_dec_return include/asm-generic/atomic-instrumented.h:198 [inline]
 dst_release+0x27/0xa0 net/core/dst.c:185
 sk_dst_set include/net/sock.h:1812 [inline]
 sk_dst_reset include/net/sock.h:1824 [inline]
 sock_setbindtodevice net/core/sock.c:610 [inline]
 sock_setsockopt+0x431/0x1b20 net/core/sock.c:707
 SYSC_setsockopt net/socket.c:1845 [inline]
 SyS_setsockopt+0x2ff/0x360 net/socket.c:1828
 do_syscall_64+0x281/0x940 arch/x86/entry/common.c:287
 entry_SYSCALL_64_after_hwframe+0x42/0xb7
RIP: 0033:0x4427a9
RSP: 002b:00007ffcdc766e08 EFLAGS: 00000217 ORIG_RAX: 0000000000000036
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00000000004427a9
RDX: 0000000000000019 RSI: 0000000000000001 RDI: 0000000000000003
RBP: 0000000000000000 R08: 0000000000000010 R09: 0000000000000000
R10: 00000000200010c0 R11: 0000000000000217 R12: 0000000000007950
R13: 00000000006cf448 R14: 0000000000000000 R15: 0000000000000000

Allocated by task 5987:
 save_stack+0x43/0xd0 mm/kasan/kasan.c:447
 set_track mm/kasan/kasan.c:459 [inline]
 kasan_kmalloc+0xad/0xe0 mm/kasan/kasan.c:552
 kasan_slab_alloc+0x12/0x20 mm/kasan/kasan.c:489
 kmem_cache_alloc+0x12e/0x760 mm/slab.c:3542
 dst_alloc+0x11f/0x1a0 net/core/dst.c:104
 rt_dst_alloc+0xe9/0x540 net/ipv4/route.c:1520
 __mkroute_output net/ipv4/route.c:2265 [inline]
 ip_route_output_key_hash_rcu+0xa49/0x2c60 net/ipv4/route.c:2493
 ip_route_output_key_hash+0x20b/0x370 net/ipv4/route.c:2322
 __ip_route_output_key include/net/route.h:126 [inline]
 ip_route_output_flow+0x26/0xa0 net/ipv4/route.c:2577
 ip_route_output_ports include/net/route.h:163 [inline]
 pptp_connect+0xa84/0x1170 drivers/net/ppp/pptp.c:453
 SYSC_connect+0x213/0x4a0 net/socket.c:1639
 SyS_connect+0x24/0x30 net/socket.c:1620
 do_syscall_64+0x281/0x940 arch/x86/entry/common.c:287
 entry_SYSCALL_64_after_hwframe+0x42/0xb7

Freed by task 5986:
 save_stack+0x43/0xd0 mm/kasan/kasan.c:447
 set_track mm/kasan/kasan.c:459 [inline]
 __kasan_slab_free+0x11a/0x170 mm/kasan/kasan.c:520
 kasan_slab_free+0xe/0x10 mm/kasan/kasan.c:527
 __cache_free mm/slab.c:3486 [inline]
 kmem_cache_free+0x83/0x2a0 mm/slab.c:3744
 dst_destroy+0x266/0x380 net/core/dst.c:140
 dst_destroy_rcu+0x16/0x20 net/core/dst.c:153
 __rcu_reclaim kernel/rcu/rcu.h:178 [inline]
 rcu_do_batch kernel/rcu/tree.c:2675 [inline]
 invoke_rcu_callbacks kernel/rcu/tree.c:2930 [inline]
 __rcu_process_callbacks kernel/rcu/tree.c:2897 [inline]
 rcu_process_callbacks+0xd6c/0x17b0 kernel/rcu/tree.c:2914
 __do_softirq+0x2d7/0xb85 kernel/softirq.c:285

The buggy address belongs to the object at ffff8801c6959e00
 which belongs to the cache ip_dst_cache of size 168
The buggy address is located 64 bytes inside of
 168-byte region [ffff8801c6959e00, ffff8801c6959ea8)
The buggy address belongs to the page:
page:ffffea00071a5640 count:1 mapcount:0 mapping:ffff8801c6959000 index:0x0
flags: 0x2fffc0000000100(slab)
raw: 02fffc0000000100 ffff8801c6959000 0000000000000000 0000000100000010
raw: ffffea0006be4ee0 ffffea0007142860 ffff8801d7de3300 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff8801c6959d00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 ffff8801c6959d80: 00 00 00 00 00 fc fc fc fc fc fc fc fc fc fc fc
>ffff8801c6959e00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                                           ^
 ffff8801c6959e80: fb fb fb fb fb fc fc fc fc fc fc fc fc fc fc fc
 ffff8801c6959f00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (832):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2018/04/03 02:17 upstream 86bbbebac193 676bd07e .config console log report syz C ci-upstream-kasan-gce-root
2018/04/03 01:54 upstream 86bbbebac193 676bd07e .config console log report syz C ci-upstream-kasan-gce
2018/04/03 02:09 upstream 86bbbebac193 676bd07e .config console log report syz ci-upstream-kasan-gce-386
2018/04/05 13:13 upstream 3e968c9f1401 5e1ccffc .config console log report ci-upstream-kasan-gce
2018/04/03 22:37 upstream f2d285669aae 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/03 22:04 upstream f2d285669aae 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/03 15:10 upstream 642e7fd23353 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/03 14:20 upstream 642e7fd23353 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/03 09:11 upstream 642e7fd23353 676bd07e .config console log report ci-upstream-kasan-gce
2018/04/03 09:05 upstream 642e7fd23353 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/03 09:00 upstream 86bbbebac193 676bd07e .config console log report ci-upstream-kasan-gce
2018/04/03 05:49 upstream 86bbbebac193 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/03 04:49 upstream 86bbbebac193 676bd07e .config console log report ci-upstream-kasan-gce
2018/04/03 04:07 upstream 86bbbebac193 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/03 04:04 upstream 86bbbebac193 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/03 03:44 upstream 86bbbebac193 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/03 03:01 upstream 86bbbebac193 676bd07e .config console log report ci-upstream-kasan-gce
2018/04/03 02:56 upstream 86bbbebac193 676bd07e .config console log report ci-upstream-kasan-gce
2018/04/03 01:10 upstream 86bbbebac193 676bd07e .config console log report ci-upstream-kasan-gce
2018/04/03 00:53 upstream 86bbbebac193 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/03 00:45 upstream 86bbbebac193 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/02 19:47 upstream 86bbbebac193 676bd07e .config console log report ci-upstream-kasan-gce
2018/04/07 00:30 upstream f2d285669aae d613535f .config console log report ci-upstream-kasan-gce-386
2018/04/06 10:22 upstream f2d285669aae 4f1152d4 .config console log report ci-upstream-kasan-gce-386
2018/04/06 06:41 upstream f2d285669aae a932eae6 .config console log report ci-upstream-kasan-gce-386
2018/04/06 04:44 upstream f2d285669aae a932eae6 .config console log report ci-upstream-kasan-gce-386
2018/04/06 02:49 upstream f2d285669aae a932eae6 .config console log report ci-upstream-kasan-gce-386
2018/04/05 20:24 upstream f2d285669aae 5e1ccffc .config console log report ci-upstream-kasan-gce-386
2018/04/05 17:05 upstream f2d285669aae 5e1ccffc .config console log report ci-upstream-kasan-gce-386
2018/04/12 20:06 net-next-old 17dec0a94915 eb2295de .config console log report ci-upstream-net-kasan-gce
2018/04/10 19:01 net-next-old 17dec0a94915 8b8de427 .config console log report ci-upstream-net-kasan-gce
2018/04/10 17:48 net-next-old 17dec0a94915 8e873e9d .config console log report ci-upstream-net-kasan-gce
2018/04/09 10:35 net-next-old 17dec0a94915 f13fb445 .config console log report ci-upstream-net-kasan-gce
2018/04/08 04:48 net-next-old 17dec0a94915 66f22a7f .config console log report ci-upstream-net-kasan-gce
2018/04/05 11:06 net-next-old 17dec0a94915 5e1ccffc .config console log report ci-upstream-net-kasan-gce
2018/04/04 11:58 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:39 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:39 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:38 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:37 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:36 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:36 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:33 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:33 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:30 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:29 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:27 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:25 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:25 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:24 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:19 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:19 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:18 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:11 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
2018/04/04 00:03 net-next-old 4608f064532c 676bd07e .config console log report ci-upstream-net-kasan-gce
* Struck through repros no longer work on HEAD.