kernel BUG at include/linux/mm.h:LINE! (5)

kernel BUG at include/linux/mm.h:LINE! (5)
Status: fixed on 2020/01/08 01:07
Reported-by: syzbot+5013d47539cdd43e7098@syzkaller.appspotmail.com
Fix commit: 9354544c net/tls: fix page double free on TX cleanup
First crash: 725d, last: 654d

Cause bisection: introduced by (bisect log) :
commit 94850257cf0f88b20db7644f28bfedc7d284de15
Author: Boris Pismenny <borisp@mellanox.com>
Date: Wed Feb 27 15:38:03 2019 +0000

tls: Fix tls_device handling of partial records

Crash: kernel BUG at include/linux/mm.h:LINE! (log)
Repro: C syz .config

Fix bisection: fixed by (bisect log) :
commit 9354544cbccf68da1b047f8fb7b47630e3c8a59d
Author: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Date: Mon Jun 24 04:26:58 2019 +0000

net/tls: fix page double free on TX cleanup

similar bugs (7):
Kernel	Title	Repro	Cause bisect	Fix bisect	Count	Last	Reported	Patched	Status
upstream	kernel BUG at include/linux/mm.h:LINE! (3)	C			14	730d	730d	0/21	closed as invalid on 2019/02/27 20:54
linux-4.19	kernel BUG at include/linux/mm.h:LINE!	C			27	4d17h	681d	0/1	upstream: reported C repro on 2019/04/17 12:33
upstream	kernel BUG at include/linux/mm.h:LINE!	syz			68	995d	1032d	6/21	fixed on 2018/06/07 13:52
upstream	kernel BUG at include/linux/mm.h:LINE! (2)	C			1009	730d	994d	12/21	fixed on 2019/02/26 22:09
upstream	kernel BUG at include/linux/mm.h:LINE! (6)	C	error	error	8	81d	313d	0/21	upstream: reported C repro on 2020/04/19 15:28
linux-4.14	kernel BUG at include/linux/mm.h:LINE!				1	443d	443d	0/1	auto-closed as invalid on 2020/04/08 20:20
upstream	kernel BUG at include/linux/mm.h:LINE! (4)				2	728d	727d	0/21	closed as invalid on 2019/03/02 20:05

Sample crash report:

flags: 0x1fffc0000000000()
raw: 01fffc0000000000 ffffea00025f6208 ffff88812fffc878 0000000000000000
raw: 0000000000000000 0000000000000003 00000000ffffff7f 0000000000000000
page dumped because: VM_BUG_ON_PAGE(page_ref_count(page) == 0)
------------[ cut here ]------------
kernel BUG at include/linux/mm.h:546!
invalid opcode: 0000 [#1] PREEMPT SMP KASAN
CPU: 0 PID: 7872 Comm: syz-executor445 Not tainted 5.0.0-rc7+ #95
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:put_page_testzero include/linux/mm.h:546 [inline]
RIP: 0010:put_page include/linux/mm.h:992 [inline]
RIP: 0010:__skb_frag_unref include/linux/skbuff.h:2837 [inline]
RIP: 0010:skb_release_data+0x5a5/0x7b0 net/core/skbuff.c:571
Code: f0 fe ff e9 b6 fb ff ff e8 38 b9 01 fc 4c 8d 63 ff e9 c8 fc ff ff e8 2a b9 01 fc 48 c7 c6 80 c2 fe 87 4c 89 e7 e8 bb c6 2a fc <0f> 0b e8 14 b9 01 fc 4d 8d 66 0e 48 b8 00 00 00 00 00 fc ff df 4c
RSP: 0018:ffff888086a0f708 EFLAGS: 00010293
RAX: ffff8880a3590440 RBX: ffffea00025dfa34 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff81990662 RDI: ffffea00025dfa38
RBP: ffff888086a0f770 R08: 000000000000003e R09: ffffed1015d03ef9
R10: ffffed1015d03ef8 R11: ffff8880ae81f7c7 R12: ffffea00025dfa00
R13: ffff8880a4398c40 R14: 0000000000000001 R15: dffffc0000000000
FS:  00007fba67236700(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fba67235e78 CR3: 0000000099c9f000 CR4: 00000000001406f0
Call Trace:
 skb_release_all+0x4d/0x60 net/core/skbuff.c:631
 __kfree_skb+0x16/0x30 net/core/skbuff.c:645
 sk_wmem_free_skb include/net/sock.h:1463 [inline]
 tcp_write_queue_purge+0x253/0x7d0 net/ipv4/tcp.c:2543
 tcp_disconnect+0x402/0x1890 net/ipv4/tcp.c:2583
 tcp_close+0xe37/0x10c0 net/ipv4/tcp.c:2384
 tls_sk_proto_close+0x40d/0x7a0 net/tls/tls_main.c:291
 inet_release+0x105/0x1f0 net/ipv4/af_inet.c:428
 inet6_release+0x53/0x80 net/ipv6/af_inet6.c:473
 __sock_release+0xd3/0x2b0 net/socket.c:579
 sock_close+0x1b/0x30 net/socket.c:1162
 __fput+0x2df/0x8d0 fs/file_table.c:278
 ____fput+0x16/0x20 fs/file_table.c:309
 task_work_run+0x14a/0x1c0 kernel/task_work.c:113
 exit_task_work include/linux/task_work.h:22 [inline]
 do_exit+0x92c/0x2fd0 kernel/exit.c:875
 do_group_exit+0x135/0x370 kernel/exit.c:979
 get_signal+0x399/0x1d50 kernel/signal.c:2575
 do_signal+0x87/0x1940 arch/x86/kernel/signal.c:816
 exit_to_usermode_loop+0x244/0x2c0 arch/x86/entry/common.c:162
 prepare_exit_to_usermode arch/x86/entry/common.c:197 [inline]
 syscall_return_slowpath arch/x86/entry/common.c:268 [inline]
 do_syscall_64+0x52d/0x610 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x447589
Code: 6e 4d 6f 64 65 00 69 43 75 72 72 4f 66 66 73 00 69 4d 61 78 46 69 6c 65 53 69 7a 65 00 69 4d 61 78 46 69 6c 65 73 00 69 46 69 <6c> 65 4e 75 6d 44 69 67 69 74 73 00 62 44 65 6c 65 74 65 4f 6e 43
RSP: 002b:00007fba67235d98 EFLAGS: 00000246 ORIG_RAX: 00000000000000ca
RAX: fffffffffffffe00 RBX: 00000000006ddc68 RCX: 0000000000447589
RDX: 0000000000000000 RSI: 0000000000000080 RDI: 00000000006ddc68
RBP: 00000000006ddc60 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00000000006ddc6c
R13: 0030656c69662f2e R14: 0000000000000000 R15: 0000000000000000
Modules linked in:
---[ end trace 3c84b12f07d7d40a ]---
RIP: 0010:put_page_testzero include/linux/mm.h:546 [inline]
RIP: 0010:put_page include/linux/mm.h:992 [inline]
RIP: 0010:__skb_frag_unref include/linux/skbuff.h:2837 [inline]
RIP: 0010:skb_release_data+0x5a5/0x7b0 net/core/skbuff.c:571
Code: f0 fe ff e9 b6 fb ff ff e8 38 b9 01 fc 4c 8d 63 ff e9 c8 fc ff ff e8 2a b9 01 fc 48 c7 c6 80 c2 fe 87 4c 89 e7 e8 bb c6 2a fc <0f> 0b e8 14 b9 01 fc 4d 8d 66 0e 48 b8 00 00 00 00 00 fc ff df 4c
RSP: 0018:ffff888086a0f708 EFLAGS: 00010293
RAX: ffff8880a3590440 RBX: ffffea00025dfa34 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff81990662 RDI: ffffea00025dfa38
RBP: ffff888086a0f770 R08: 000000000000003e R09: ffffed1015d03ef9
R10: ffffed1015d03ef8 R11: ffff8880ae81f7c7 R12: ffffea00025dfa00
R13: ffff8880a4398c40 R14: 0000000000000001 R15: dffffc0000000000
FS:  00007fba67236700(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fba67235e78 CR3: 0000000099c9f000 CR4: 00000000001406f0

Crashes (129):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro
ci-upstream-net-kasan-gce	2019/03/04 22:22	net-next	9e9322e5	7c693b52	.config	log	report	syz	C
ci-upstream-kasan-gce-root	2019/04/26 23:40	upstream	d0473f97	b617407b	.config	log	report
ci-upstream-kasan-gce	2019/04/08 07:33	upstream	fcf88917	c34fde03	.config	log	report
ci-upstream-kasan-gce-smack-root	2019/03/27 01:12	upstream	14c741de	55684ce1	.config	log	report
ci-upstream-kasan-gce-smack-root	2019/03/25 08:49	upstream	8c2ffd91	2c86e0a5	.config	log	report
ci-upstream-kasan-gce	2019/03/22 13:27	upstream	0939221e	dce6e62f	.config	log	report
ci-upstream-kasan-gce	2019/03/21 14:08	upstream	54c49016	427ea487	.config	log	report
ci-upstream-kasan-gce-root	2019/03/06 22:41	upstream	afe6fe70	18215b8d	.config	log	report
ci-upstream-net-this-kasan-gce	2019/05/13 23:04	net	69dda13f	7c305b44	.config	log	report
ci-upstream-net-this-kasan-gce	2019/04/14 05:37	net	ed0de45a	c402d8f1	.config	log	report
ci-upstream-net-this-kasan-gce	2019/04/09 03:59	net	e063f459	995065ff	.config	log	report
ci-upstream-net-this-kasan-gce	2019/04/04 16:55	net	ef0efcd3	6a475fff	.config	log	report
ci-upstream-net-this-kasan-gce	2019/03/31 07:04	net	288ac524	0c624d4d	.config	log	report
ci-upstream-net-this-kasan-gce	2019/03/30 22:42	net	288ac524	0c624d4d	.config	log	report
ci-upstream-net-this-kasan-gce	2019/03/30 14:36	net	4d31c4fa	c35ee0ea	.config	log	report
ci-upstream-net-this-kasan-gce	2019/03/28 06:09	net	1a9df9e2	f94f56fe	.config	log	report
ci-upstream-net-this-kasan-gce	2019/03/28 04:11	net	1a9df9e2	f94f56fe	.config	log	report
ci-upstream-net-this-kasan-gce	2019/03/27 16:23	net	8c838f53	4e668495	.config	log	report
ci-upstream-net-this-kasan-gce	2019/03/26 12:42	net	27602e2c	55684ce1	.config	log	report
ci-upstream-net-this-kasan-gce	2019/03/25 04:28	net	526949e8	2c86e0a5	.config	log	report
ci-upstream-net-this-kasan-gce	2019/03/23 23:43	net	c8248c6c	a2cef203	.config	log	report
ci-upstream-net-this-kasan-gce	2019/03/23 03:27	net	5f543a54	3361bde5	.config	log	report
ci-upstream-net-kasan-gce	2019/03/28 22:51	net-next	356d71e0	14c58f8d	.config	log	report
ci-upstream-net-kasan-gce	2019/03/28 16:17	net-next	356d71e0	f94f56fe	.config	log	report
ci-upstream-net-kasan-gce	2019/03/28 00:42	net-next	5133a4a8	4e668495	.config	log	report
ci-upstream-net-kasan-gce	2019/03/27 22:25	net-next	5133a4a8	4e668495	.config	log	report
ci-upstream-net-kasan-gce	2019/03/27 18:53	net-next	5133a4a8	4e668495	.config	log	report
ci-upstream-net-kasan-gce	2019/03/27 03:00	net-next	be67101f	55684ce1	.config	log	report
ci-upstream-net-kasan-gce	2019/03/26 20:52	net-next	be67101f	55684ce1	.config	log	report
ci-upstream-net-kasan-gce	2019/03/25 17:34	net-next	68cc2999	2c86e0a5	.config	log	report
ci-upstream-net-kasan-gce	2019/03/19 06:45	net-next	ffa91253	46264c32	.config	log	report
ci-upstream-net-kasan-gce	2019/03/18 21:23	net-next	3b319ee2	4656beca	.config	log	report
ci-upstream-net-kasan-gce	2019/03/17 11:25	net-next	3b319ee2	ba18afea	.config	log	report
ci-upstream-net-kasan-gce	2019/03/17 07:50	net-next	3b319ee2	bab43553	.config	log	report
ci-upstream-net-kasan-gce	2019/03/17 05:42	net-next	3b319ee2	bab43553	.config	log	report
ci-upstream-net-kasan-gce	2019/03/17 03:12	net-next	3b319ee2	bab43553	.config	log	report
ci-upstream-net-kasan-gce	2019/03/17 00:35	net-next	3b319ee2	bab43553	.config	log	report
ci-upstream-net-kasan-gce	2019/03/16 18:13	net-next	3b319ee2	bab43553	.config	log	report
ci-upstream-net-kasan-gce	2019/03/16 16:46	net-next	3b319ee2	bab43553	.config	log	report
ci-upstream-net-kasan-gce	2019/03/16 14:15	net-next	3b319ee2	bab43553	.config	log	report
ci-upstream-net-kasan-gce	2019/03/16 10:04	net-next	3b319ee2	bab43553	.config	log	report
ci-upstream-net-kasan-gce	2019/03/16 08:50	net-next	3b319ee2	bab43553	.config	log	report
ci-upstream-net-kasan-gce	2019/03/16 07:27	net-next	3b319ee2	bab43553	.config	log	report
ci-upstream-net-kasan-gce	2019/03/16 03:21	net-next	3b319ee2	bab43553	.config	log	report
ci-upstream-net-kasan-gce	2019/03/15 23:14	net-next	3b319ee2	bab43553	.config	log	report
ci-upstream-net-kasan-gce	2019/03/15 20:26	net-next	3b319ee2	bab43553	.config	log	report
ci-upstream-net-kasan-gce	2019/03/15 18:01	net-next	3b319ee2	bab43553	.config	log	report
ci-upstream-net-kasan-gce	2019/03/15 05:31	net-next	3b319ee2	d72db19b	.config	log	report
ci-upstream-net-kasan-gce	2019/03/15 02:46	net-next	3b319ee2	d72db19b	.config	log	report
ci-upstream-net-kasan-gce	2019/03/14 23:29	net-next	3b319ee2	d72db19b	.config	log	report
ci-upstream-net-kasan-gce	2019/03/14 21:40	net-next	3b319ee2	d72db19b	.config	log	report
ci-upstream-net-kasan-gce	2019/03/04 08:05	net-next	a9836336	7c693b52	.config	log	report