syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
kworker/u4:6/2893 is trying to acquire lock:
ffff888023fb0d00 (team->team_lock_key#2){+.+.}-{3:3}, at: team_del_slave+0x32/0x1c0 drivers/net/team/team.c:1997

but task is already holding lock:
ffff88807bd40768 (&rdev->wiphy.mtx){+.+.}-{3:3}, at: wiphy_lock include/net/cfg80211.h:5777 [inline]
ffff88807bd40768 (&rdev->wiphy.mtx){+.+.}-{3:3}, at: ieee80211_remove_interfaces+0x292/0x680 net/mac80211/iface.c:2332

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&rdev->wiphy.mtx){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x129/0xcc0 kernel/locking/mutex.c:747
       wiphy_lock include/net/cfg80211.h:5777 [inline]
       ieee80211_open+0x144/0x200 net/mac80211/iface.c:458
       __dev_open+0x2bc/0x430 net/core/dev.c:1506
       dev_open+0xab/0x170 net/core/dev.c:1542
       team_port_add drivers/net/team/team.c:1223 [inline]
       team_add_slave+0xae7/0x2660 drivers/net/team/team.c:1983
       do_set_master net/core/rtnetlink.c:2706 [inline]
       do_setlink+0xe14/0x3fb0 net/core/rtnetlink.c:2912
       __rtnl_newlink net/core/rtnetlink.c:3703 [inline]
       rtnl_newlink+0x175b/0x2020 net/core/rtnetlink.c:3750
       rtnetlink_rcv_msg+0x7c7/0xf10 net/core/rtnetlink.c:6472
       netlink_rcv_skb+0x216/0x480 net/netlink/af_netlink.c:2545
       netlink_unicast_kernel net/netlink/af_netlink.c:1320 [inline]
       netlink_unicast+0x751/0x8d0 net/netlink/af_netlink.c:1346
       netlink_sendmsg+0x8c1/0xbe0 net/netlink/af_netlink.c:1894
       sock_sendmsg_nosec net/socket.c:730 [inline]
       __sock_sendmsg net/socket.c:745 [inline]
       ____sys_sendmsg+0x5bf/0x950 net/socket.c:2595
       ___sys_sendmsg+0x220/0x290 net/socket.c:2649
       __sys_sendmsg net/socket.c:2678 [inline]
       __do_sys_sendmsg net/socket.c:2687 [inline]
       __se_sys_sendmsg+0x1a5/0x270 net/socket.c:2685
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (team->team_lock_key#2){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
       lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x129/0xcc0 kernel/locking/mutex.c:747
       team_del_slave+0x32/0x1c0 drivers/net/team/team.c:1997
       team_device_event+0x28d/0xa20 drivers/net/team/team.c:3041
       notifier_call_chain+0x197/0x390 kernel/notifier.c:93
       call_netdevice_notifiers_extack net/core/dev.c:2064 [inline]
       call_netdevice_notifiers net/core/dev.c:2078 [inline]
       unregister_netdevice_many_notify+0xf36/0x1810 net/core/dev.c:11086
       unregister_netdevice_many net/core/dev.c:11142 [inline]
       unregister_netdevice_queue+0x324/0x360 net/core/dev.c:11022
       unregister_netdevice include/linux/netdevice.h:3137 [inline]
       _cfg80211_unregister_wdev+0x16b/0x580 net/wireless/core.c:1215
       ieee80211_remove_interfaces+0x496/0x680 net/mac80211/iface.c:2351
       ieee80211_unregister_hw+0x5d/0x2a0 net/mac80211/main.c:1517
       mac80211_hwsim_del_radio+0x274/0x450 drivers/net/wireless/virtual/mac80211_hwsim.c:5413
       hwsim_exit_net+0x585/0x640 drivers/net/wireless/virtual/mac80211_hwsim.c:6290
       ops_exit_list net/core/net_namespace.c:173 [inline]
       cleanup_net+0x6f4/0xb90 net/core/net_namespace.c:652
       process_one_work kernel/workqueue.c:2634 [inline]
       process_scheduled_works+0xa45/0x15b0 kernel/workqueue.c:2711
       worker_thread+0xa55/0xfc0 kernel/workqueue.c:2792
       kthread+0x2fa/0x390 kernel/kthread.c:388
       ret_from_fork+0x48/0x80 arch/x86/kernel/process.c:152
       ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:293

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&rdev->wiphy.mtx);
                               lock(team->team_lock_key#2);
                               lock(&rdev->wiphy.mtx);
  lock(team->team_lock_key#2);

 *** DEADLOCK ***

5 locks held by kworker/u4:6/2893:
 #0: ffff888017873938 ((wq_completion)netns){+.+.}-{0:0}, at: process_one_work kernel/workqueue.c:2609 [inline]
 #0: ffff888017873938 ((wq_completion)netns){+.+.}-{0:0}, at: process_scheduled_works+0x957/0x15b0 kernel/workqueue.c:2711
 #1: ffffc9000bcb7d00 (net_cleanup_work){+.+.}-{0:0}, at: process_one_work kernel/workqueue.c:2609 [inline]
 #1: ffffc9000bcb7d00 (net_cleanup_work){+.+.}-{0:0}, at: process_scheduled_works+0x957/0x15b0 kernel/workqueue.c:2711
 #2: ffffffff8dfaeed0 (pernet_ops_rwsem){++++}-{3:3}, at: cleanup_net+0x136/0xb90 net/core/net_namespace.c:606
 #3: ffffffff8dfbbd08 (rtnl_mutex){+.+.}-{3:3}, at: ieee80211_unregister_hw+0x55/0x2a0 net/mac80211/main.c:1510
 #4: ffff88807bd40768 (&rdev->wiphy.mtx){+.+.}-{3:3}, at: wiphy_lock include/net/cfg80211.h:5777 [inline]
 #4: ffff88807bd40768 (&rdev->wiphy.mtx){+.+.}-{3:3}, at: ieee80211_remove_interfaces+0x292/0x680 net/mac80211/iface.c:2332

stack backtrace:
CPU: 0 PID: 2893 Comm: kworker/u4:6 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
Workqueue: netns cleanup_net
Call Trace:
 <TASK>
 dump_stack_lvl+0x16c/0x230 lib/dump_stack.c:106
 check_noncircular+0x2bd/0x3c0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
 lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x129/0xcc0 kernel/locking/mutex.c:747
 team_del_slave+0x32/0x1c0 drivers/net/team/team.c:1997
 team_device_event+0x28d/0xa20 drivers/net/team/team.c:3041
 notifier_call_chain+0x197/0x390 kernel/notifier.c:93
 call_netdevice_notifiers_extack net/core/dev.c:2064 [inline]
 call_netdevice_notifiers net/core/dev.c:2078 [inline]
 unregister_netdevice_many_notify+0xf36/0x1810 net/core/dev.c:11086
 unregister_netdevice_many net/core/dev.c:11142 [inline]
 unregister_netdevice_queue+0x324/0x360 net/core/dev.c:11022
 unregister_netdevice include/linux/netdevice.h:3137 [inline]
 _cfg80211_unregister_wdev+0x16b/0x580 net/wireless/core.c:1215
 ieee80211_remove_interfaces+0x496/0x680 net/mac80211/iface.c:2351
 ieee80211_unregister_hw+0x5d/0x2a0 net/mac80211/main.c:1517
 mac80211_hwsim_del_radio+0x274/0x450 drivers/net/wireless/virtual/mac80211_hwsim.c:5413
 hwsim_exit_net+0x585/0x640 drivers/net/wireless/virtual/mac80211_hwsim.c:6290
 ops_exit_list net/core/net_namespace.c:173 [inline]
 cleanup_net+0x6f4/0xb90 net/core/net_namespace.c:652
 process_one_work kernel/workqueue.c:2634 [inline]
 process_scheduled_works+0xa45/0x15b0 kernel/workqueue.c:2711
 worker_thread+0xa55/0xfc0 kernel/workqueue.c:2792
 kthread+0x2fa/0x390 kernel/kthread.c:388
 ret_from_fork+0x48/0x80 arch/x86/kernel/process.c:152
 ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:293
 </TASK>
team0: Port device wlan1 removed
hsr_slave_0: left promiscuous mode
hsr_slave_1: left promiscuous mode
batman_adv: batadv0: Interface deactivated: batadv_slave_0
batman_adv: batadv0: Removing interface: batadv_slave_0
batman_adv: batadv0: Interface deactivated: batadv_slave_1
batman_adv: batadv0: Removing interface: batadv_slave_1
bridge_slave_1: left allmulticast mode
bridge_slave_1: left promiscuous mode
bridge0: port 2(bridge_slave_1) entered disabled state
bridge_slave_0: left allmulticast mode
bridge_slave_0: left promiscuous mode
bridge0: port 1(bridge_slave_0) entered disabled state
veth1_macvtap: left promiscuous mode
veth0_macvtap: left promiscuous mode
veth1_vlan: left promiscuous mode
veth0_vlan: left promiscuous mode
team0 (unregistering): Port device team_slave_1 removed
team0 (unregistering): Port device team_slave_0 removed
bond0 (unregistering): (slave bond_slave_1): Releasing backup interface
bond0 (unregistering): (slave bond_slave_0): Releasing backup interface
bond0 (unregistering): Released all slaves