syzbot


possible deadlock in mnt_want_write (2)

Status: upstream: reported C repro on 2021/06/15 16:59
Reported-by: syzbot+b42fe626038981fb7bfa@syzkaller.appspotmail.com
First crash: 600d, last: 22h12m

Cause bisection: introduced by (bisect log) [no-op commit]:
commit b9fc8b4a591811546fec2dbef7e9f809362100c9
Author: Grant Seltzer <grantseltzer@gmail.com>
Date: Mon Feb 22 19:58:46 2021 +0000

  bpf: Add kernel/modules BTF presence checks to bpftool feature command

Crash: WARNING in kvm_wait (log)
Repro: C syz .config
similar bugs (4):
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in mnt_want_write C done done 662 847d 1654d 17/24 fixed on 2020/11/16 12:12
linux-4.19 possible deadlock in mnt_want_write romfs C 713 5d02h 1384d 0/1 upstream: reported C repro on 2019/04/19 16:54
android-49 possible deadlock in mnt_want_write 1 1637d 1637d 0/3 auto-closed as invalid on 2019/02/22 14:57
linux-4.14 possible deadlock in mnt_want_write ubifs C 10134 18h15m 1379d 0/1 upstream: reported C repro on 2019/04/25 05:09
Last patch testing requests:
Created Duration User Patch Repo Result
2022/07/03 07:07 19m hdanton@sina.com patch http://kernel.source.codeaurora.cn/pub/scm/linux/kernel/git/torvalds/linux.git 089866061428 OK log
2022/07/03 01:34 17m hdanton@sina.com patch http://kernel.source.codeaurora.cn/pub/scm/linux/kernel/git/torvalds/linux.git 089866061428 error

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.1.0-rc3-syzkaller-00152-gf2f32f8af2b0 #0 Not tainted
------------------------------------------------------
syz-executor276/3616 is trying to acquire lock:
ffff88814bdf2460 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393

but task is already holding lock:
ffff88801e13e1a0 (&iint->mutex){+.+.}-{3:3}, at: process_measurement+0x7ab/0x1bd0 security/integrity/ima/ima_main.c:260

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&iint->mutex){+.+.}-{3:3}:
       lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668
       __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
       process_measurement+0x7ab/0x1bd0 security/integrity/ima/ima_main.c:260
       ima_file_check+0xd8/0x130 security/integrity/ima/ima_main.c:517
       do_open fs/namei.c:3559 [inline]
       path_openat+0x2642/0x2df0 fs/namei.c:3713
       do_filp_open+0x264/0x4f0 fs/namei.c:3740
       do_sys_openat2+0x124/0x4e0 fs/open.c:1310
       do_sys_open fs/open.c:1326 [inline]
       __do_sys_openat fs/open.c:1342 [inline]
       __se_sys_openat fs/open.c:1337 [inline]
       __x64_sys_openat+0x243/0x290 fs/open.c:1337
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (sb_writers#4){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3097 [inline]
       check_prevs_add kernel/locking/lockdep.c:3216 [inline]
       validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831
       __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055
       lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1826 [inline]
       sb_start_write+0x4d/0x1a0 include/linux/fs.h:1901
       mnt_want_write+0x3b/0x80 fs/namespace.c:393
       ovl_maybe_copy_up+0x124/0x190 fs/overlayfs/copy_up.c:1083
       ovl_open+0xf3/0x290 fs/overlayfs/file.c:152
       do_dentry_open+0x85f/0x11b0 fs/open.c:882
       vfs_open fs/open.c:1013 [inline]
       dentry_open+0xc1/0x120 fs/open.c:1029
       ima_calc_file_hash+0x15b/0x1ca0 security/integrity/ima/ima_crypto.c:558
       ima_collect_measurement+0x444/0x8c0 security/integrity/ima/ima_api.c:292
       process_measurement+0xf4b/0x1bd0 security/integrity/ima/ima_main.c:337
       ima_file_check+0xd8/0x130 security/integrity/ima/ima_main.c:517
       do_open fs/namei.c:3559 [inline]
       path_openat+0x2642/0x2df0 fs/namei.c:3713
       do_filp_open+0x264/0x4f0 fs/namei.c:3740
       do_sys_openat2+0x124/0x4e0 fs/open.c:1310
       do_sys_open fs/open.c:1326 [inline]
       __do_sys_open fs/open.c:1334 [inline]
       __se_sys_open fs/open.c:1330 [inline]
       __x64_sys_open+0x221/0x270 fs/open.c:1330
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&iint->mutex);
                               lock(sb_writers#4);
                               lock(&iint->mutex);
  lock(sb_writers#4);

 *** DEADLOCK ***

1 lock held by syz-executor276/3616:
 #0: ffff88801e13e1a0 (&iint->mutex){+.+.}-{3:3}, at: process_measurement+0x7ab/0x1bd0 security/integrity/ima/ima_main.c:260

stack backtrace:
CPU: 0 PID: 3616 Comm: syz-executor276 Not tainted 6.1.0-rc3-syzkaller-00152-gf2f32f8af2b0 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/11/2022
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1b1/0x28e lib/dump_stack.c:106
 check_noncircular+0x2cc/0x390 kernel/locking/lockdep.c:2177
 check_prev_add kernel/locking/lockdep.c:3097 [inline]
 check_prevs_add kernel/locking/lockdep.c:3216 [inline]
 validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831
 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055
 lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1826 [inline]
 sb_start_write+0x4d/0x1a0 include/linux/fs.h:1901
 mnt_want_write+0x3b/0x80 fs/namespace.c:393
 ovl_maybe_copy_up+0x124/0x190 fs/overlayfs/copy_up.c:1083
 ovl_open+0xf3/0x290 fs/overlayfs/file.c:152
 do_dentry_open+0x85f/0x11b0 fs/open.c:882
 vfs_open fs/open.c:1013 [inline]
 dentry_open+0xc1/0x120 fs/open.c:1029
 ima_calc_file_hash+0x15b/0x1ca0 security/integrity/ima/ima_crypto.c:558
 ima_collect_measurement+0x444/0x8c0 security/integrity/ima/ima_api.c:292
 process_measurement+0xf4b/0x1bd0 security/integrity/ima/ima_main.c:337
 ima_file_check+0xd8/0x130 security/integrity/ima/ima_main.c:517
 do_open fs/namei.c:3559 [inline]
 path_openat+0x2642/0x2df0 fs/namei.c:3713
 do_filp_open+0x264/0x4f0 fs/namei.c:3740
 do_sys_openat2+0x124/0x4e0 fs/open.c:1310
 do_sys_open fs/open.c:1326 [inline]
 __do_sys_open fs/open.c:1334 [inline]
 __se_sys_open fs/open.c:1330 [inline]
 __x64_sys_open+0x221/0x270 fs/open.c:1330
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f6067c69e29
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 b1 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffcfd5e2da8 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 0030656c69662f2e RCX: 00007f6067c69e29
RDX: 0000000000000000 RSI: 000000000000007f RDI: 0000000020000180
RBP: 0000000020000040 R08: 00007ffcfd5e2f48 R09: 00007ffcfd5e2f48
R10: 00007ffcfd5e2f48 R11: 0000000000000246 R12: 00007f6067c2d6b0
R13: 431bde82d7b634db R14: 0000000000000000 R15: 0000000000000000
 </TASK>
syz-executor276 (3616) used greatest stack depth: 16088 bytes left

Crashes (339):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Title
ci2-upstream-fs 2022/11/03 23:00 upstream f2f32f8af2b0 6d752409 .config strace log report syz C [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci-upstream-kasan-gce-smack-root 2022/07/02 17:27 upstream 089866061428 1434eec0 .config console log report syz C possible deadlock in mnt_want_write
ci2-upstream-fs 2023/02/01 15:31 upstream c0b67534c95c 9a6f477c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/02/01 14:13 upstream c0b67534c95c 9a6f477c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/31 23:11 upstream 22b8077d0fce b68fb8d6 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/31 07:33 upstream 6d796c50f84c b68fb8d6 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/30 17:20 upstream 6d796c50f84c b68fb8d6 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/30 00:48 upstream ab072681eabe 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/28 20:22 upstream 5af6ce704936 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/28 16:48 upstream 5af6ce704936 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/27 08:05 upstream 7c46948a6e9c 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/25 04:18 upstream fb6e71db53f3 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/24 21:06 upstream 7bf70dbb1882 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/24 11:24 upstream 7bf70dbb1882 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/24 04:36 upstream 7bf70dbb1882 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/23 11:11 upstream 2475bf0250de 44388686 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/22 01:34 upstream f883675bf652 cc0f9968 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/21 08:14 upstream edc00350d205 cc0f9968 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/20 18:29 upstream d368967cb103 dd15ff29 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/20 16:51 upstream d368967cb103 dd15ff29 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/20 15:00 upstream d368967cb103 dd15ff29 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/19 16:29 upstream 7287904c8771 66fca3ae .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/18 20:47 upstream c1649ec55708 4620c2d9 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/18 18:08 upstream c1649ec55708 4620c2d9 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/18 09:07 upstream 6e50979a9c87 42660d9e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/18 02:30 upstream 6e50979a9c87 42660d9e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/17 21:42 upstream 6e50979a9c87 42660d9e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/17 20:08 upstream 6e50979a9c87 42660d9e .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/17 15:14 upstream d532dd102151 a63719e7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci-upstream-kasan-gce-smack-root 2023/01/16 18:53 upstream 5dc4c995db9e a63719e7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/16 15:47 upstream 5dc4c995db9e a63719e7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/16 14:30 upstream 5dc4c995db9e a63719e7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/15 00:40 upstream 97ec4d559d93 a63719e7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/14 17:39 upstream 97ec4d559d93 a63719e7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/13 10:53 upstream c757fc92a3f7 96166539 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/12 13:59 upstream e8f60cd7db24 96166539 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/12 07:23 upstream 7dd4b804e080 96166539 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/11 18:27 upstream 7dd4b804e080 96166539 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/11 08:14 upstream 40c18f363a08 48bc529a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/10 22:17 upstream 5a41237ad1d4 48bc529a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/10 21:16 upstream 5a41237ad1d4 48bc529a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/10 13:06 upstream 5a41237ad1d4 48bc529a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/10 04:38 upstream 1fe4fd6f5cad 48bc529a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/10 01:57 upstream 1fe4fd6f5cad 48bc529a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/09 07:28 upstream 1fe4fd6f5cad 1dac8c7a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/08 22:37 upstream 9b43a525db12 1dac8c7a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/08 15:04 upstream 9b43a525db12 1dac8c7a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/08 04:45 upstream 0a71553536d2 1dac8c7a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/07 09:25 upstream 1f5abbd77e2c 1dac8c7a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/07 05:37 upstream 1f5abbd77e2c 1dac8c7a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci2-upstream-fs 2023/01/04 17:31 upstream 69b41ac87e4a 1dac8c7a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in mnt_want_write
ci-upstream-kasan-gce-smack-root 2021/06/11 16:55 upstream 06af8679449d 1ba81399 .config console log report info possible deadlock in mnt_want_write
* Struck through repros no longer work on HEAD.