general protection fault in skb_release

general protection fault in skb_release_data (2)
Status: upstream: reported C repro on 2020/09/09 09:58
Reported-by: syzbot+ccfa5775bc1bda21ddd1@syzkaller.appspotmail.com
First crash: 133d, last: 24d

Cause bisection: introduced by (bisect log) [merge commit]:
commit 6b25e21fa6f26d0f0d45f161d169029411c84286
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Wed Oct 12 01:12:22 2016 +0000

Merge tag 'drm-for-v4.9' of git://people.freedesktop.org/~airlied/linux

Crash: WARNING in nf_unregister_net_hook (log)
Repro: C syz .config

similar bugs (4):
Kernel	Title	Repro	Fix bisect	Count	Last	Reported	Patched	Status
linux-4.19	general protection fault in skb_release_data	C	error	2	131d	134d	0/1	upstream: reported C repro on 2020/09/07 04:13
android-49	general protection fault in skb_release_data			1	1255d	1255d	1/3	fixed on 2017/10/23 20:15
linux-4.14	general protection fault in skb_release_data	C		1	12d	132d	0/1	upstream: reported C repro on 2020/09/08 19:28
upstream	general protection fault in skb_release_data	syz		198	1251d	1252d	3/17	fixed on 2017/10/24 06:54

Sample crash report:

general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] PREEMPT SMP KASAN
KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f]
CPU: 0 PID: 6962 Comm: syz-executor163 Not tainted 5.9.0-rc5-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:compound_head include/linux/page-flags.h:182 [inline]
RIP: 0010:put_page include/linux/mm.h:1172 [inline]
RIP: 0010:__skb_frag_unref include/linux/skbuff.h:3014 [inline]
RIP: 0010:skb_release_data+0x232/0x910 net/core/skbuff.c:604
Code: 48 c1 e8 03 42 80 3c 30 00 0f 85 ea 05 00 00 48 8b 0c 24 49 63 c4 48 c1 e0 04 48 8b 6c 08 30 48 8d 7d 08 48 89 f8 48 c1 e8 03 <42> 80 3c 30 00 0f 85 ba 05 00 00 48 8b 5d 08 31 ff 49 89 dd 41 83
RSP: 0018:ffffc90000007a48 EFLAGS: 00010202
RAX: 0000000000000001 RBX: 0000000000000002 RCX: ffff88809d97e0c0
RDX: ffff88809d29a100 RSI: ffffffff86649685 RDI: 0000000000000008
RBP: 0000000000000000 R08: 0000000000000000 R09: ffffffff8b591e8f
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: ffff88809d97e0c0 R14: dffffc0000000000 R15: ffff88809d97e0f0
FS:  00007f7ff5879700(0000) GS:ffff8880ae400000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00000000200004c0 CR3: 000000009cf0a000 CR4: 00000000001506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <IRQ>
 skb_release_all net/core/skbuff.c:664 [inline]
 __kfree_skb net/core/skbuff.c:678 [inline]
 kfree_skb.part.0+0xc2/0x350 net/core/skbuff.c:696
 kfree_skb+0x7d/0x100 include/linux/refcount.h:270
 validate_xmit_skb+0x9d9/0xf00 net/core/dev.c:3664
 __dev_queue_xmit+0x990/0x2d70 net/core/dev.c:4128
 mrp_queue_xmit net/802/mrp.c:351 [inline]
 mrp_join_timer+0x8a/0xc0 net/802/mrp.c:595
 call_timer_fn+0x1ac/0x760 kernel/time/timer.c:1413
 expire_timers kernel/time/timer.c:1458 [inline]
 __run_timers.part.0+0x67c/0xaa0 kernel/time/timer.c:1755
 __run_timers kernel/time/timer.c:1736 [inline]
 run_timer_softirq+0xb3/0x1d0 kernel/time/timer.c:1768
 __do_softirq+0x1f8/0xb23 kernel/softirq.c:298
 asm_call_on_stack+0xf/0x20 arch/x86/entry/entry_64.S:706
 </IRQ>
 __run_on_irqstack arch/x86/include/asm/irq_stack.h:22 [inline]
 run_on_irqstack_cond arch/x86/include/asm/irq_stack.h:48 [inline]
 do_softirq_own_stack+0x9d/0xd0 arch/x86/kernel/irq_64.c:77
 invoke_softirq kernel/softirq.c:393 [inline]
 __irq_exit_rcu kernel/softirq.c:423 [inline]
 irq_exit_rcu+0x235/0x280 kernel/softirq.c:435
 sysvec_apic_timer_interrupt+0x51/0xf0 arch/x86/kernel/apic/apic.c:1091
 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:581
RIP: 0010:arch_local_irq_restore arch/x86/include/asm/paravirt.h:770 [inline]
RIP: 0010:console_unlock+0xb4a/0xe60 kernel/printk/printk.c:2509
Code: 89 48 c1 e8 03 42 80 3c 38 00 0f 85 18 03 00 00 48 83 3d 60 87 9d 08 00 0f 84 90 01 00 00 e8 6d 5b 17 00 48 8b 7c 24 30 57 9d <0f> 1f 44 00 00 8b 5c 24 64 31 ff 89 de e8 b4 57 17 00 85 db 0f 84
RSP: 0018:ffffc90001716ed0 EFLAGS: 00000293
RAX: 0000000000000000 RBX: 0000000000000200 RCX: 0000000000000006
RDX: ffff88809d29a100 RSI: ffffffff815ee453 RDI: 0000000000000293
RBP: 0000000000000000 R08: 0000000000000001 R09: ffffffff8d0b79e7
R10: fffffbfff1a16f3c R11: 0000000000000000 R12: ffffffff84eac090
R13: 000000000000003d R14: ffffffff8aba4650 R15: dffffc0000000000
 vprintk_emit+0x2ff/0x740 kernel/printk/printk.c:2029
 vprintk_func+0x8d/0x1d4 kernel/printk/printk_safe.c:393
 printk+0xba/0xed kernel/printk/printk.c:2078
 __dev_set_promiscuity.cold+0x55/0x35f net/core/dev.c:8076
 __dev_change_flags+0x3af/0x660 net/core/dev.c:8294
 rtnl_configure_link+0xee/0x230 net/core/rtnetlink.c:3123
 __rtnl_newlink+0x10b6/0x1740 net/core/rtnetlink.c:3460
 rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3500
 rtnetlink_rcv_msg+0x44e/0xad0 net/core/rtnetlink.c:5563
 netlink_rcv_skb+0x15a/0x430 net/netlink/af_netlink.c:2470
 netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline]
 netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1330
 netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1919
 sock_sendmsg_nosec net/socket.c:651 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:671
 ____sys_sendmsg+0x6e8/0x810 net/socket.c:2353
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2407
 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2440
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x446ec9
Code: e8 bc b4 02 00 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 2b 08 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f7ff5878db8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000006dbc68 RCX: 0000000000446ec9
RDX: 0000000000000000 RSI: 0000000020000280 RDI: 0000000000000005
RBP: 00000000006dbc60 R08: 0000000000000005 R09: 0000000000000000
R10: 0000000000000008 R11: 0000000000000246 R12: 00000000006dbc6c
R13: 00007ffef56cebbf R14: 00007f7ff58799c0 R15: 0000000000000064
Modules linked in:
---[ end trace 483cb1693a33737a ]---
RIP: 0010:compound_head include/linux/page-flags.h:182 [inline]
RIP: 0010:put_page include/linux/mm.h:1172 [inline]
RIP: 0010:__skb_frag_unref include/linux/skbuff.h:3014 [inline]
RIP: 0010:skb_release_data+0x232/0x910 net/core/skbuff.c:604
Code: 48 c1 e8 03 42 80 3c 30 00 0f 85 ea 05 00 00 48 8b 0c 24 49 63 c4 48 c1 e0 04 48 8b 6c 08 30 48 8d 7d 08 48 89 f8 48 c1 e8 03 <42> 80 3c 30 00 0f 85 ba 05 00 00 48 8b 5d 08 31 ff 49 89 dd 41 83
RSP: 0018:ffffc90000007a48 EFLAGS: 00010202
RAX: 0000000000000001 RBX: 0000000000000002 RCX: ffff88809d97e0c0
RDX: ffff88809d29a100 RSI: ffffffff86649685 RDI: 0000000000000008
RBP: 0000000000000000 R08: 0000000000000000 R09: ffffffff8b591e8f
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: ffff88809d97e0c0 R14: dffffc0000000000 R15: ffff88809d97e0f0
FS:  00007f7ff5879700(0000) GS:ffff8880ae400000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00000000200004c0 CR3: 000000009cf0a000 CR4: 00000000001506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Fix bisection attempts:
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro
ci-upstream-kasan-gce-selinux-root	2020/12/26 03:24	upstream	61d79136	9564d2e9	.config	log	report	syz	C
ci-upstream-kasan-gce-selinux-root	2020/11/26 03:06	upstream	fa02fcd9	9564d2e9	.config	log	report	syz	C
ci-upstream-kasan-gce-selinux-root	2020/10/27 01:07	upstream	4525c878	9564d2e9	.config	log	report	syz	C

Crashes (7):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	Maintainers
ci-upstream-kasan-gce-selinux-root	2020/09/20 21:21	upstream	325d0eab	9564d2e9	.config	log	report	syz	C	davem@davemloft.net, keescook@chromium.org, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pankaj.laxminarayan.bharadiya@intel.com
ci-upstream-kasan-gce-root	2020/09/15 23:50	upstream	fc4f28bb	6989d6f6	.config	log	report	syz	C	davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
ci-upstream-kasan-gce-smack-root	2020/09/10 14:17	upstream	34d4ddd3	409809d8	.config	log	report	syz	C	davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
ci-upstream-net-this-kasan-gce	2020/09/08 13:03	net	19162fd4	abf9ba4f	.config	log	report	syz	C	davem@davemloft.net, keescook@chromium.org, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pankaj.laxminarayan.bharadiya@intel.com
ci-upstream-net-kasan-gce	2020/09/08 09:49	net-next	bb1416ad	abf9ba4f	.config	log	report	syz	C	davem@davemloft.net, keescook@chromium.org, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pankaj.laxminarayan.bharadiya@intel.com
ci-upstream-linux-next-kasan-gce-root	2020/09/27 00:48	linux-next	d1d2220c	2d5ea0cb	.config	log	report	syz	C	davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
ci-upstream-net-kasan-gce	2020/09/08 08:43	net-next	bb1416ad	abf9ba4f	.config	log	report			davem@davemloft.net, keescook@chromium.org, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pankaj.laxminarayan.bharadiya@intel.com