KCSAN: data-race in ring_buffer_lock_reserve / ring_buffer_lock_reserve

Status: moderation: reported on 2026/11/21 00:01
Subsystems: trace
Labels: race:benign prio:low
[Documentation on labels]
Reported-by: syzbot+a7bd73c289ce4675e279@syzkaller.appspotmail.com
First crash: 3d13h, last: 3d06h
✨ AI-generated root cause summary:

KCSAN (with CONFIG_KCSAN_INTERRUPT_WATCHER=y) reports a data race on the 4-byte per-CPU bitmask cpu_buffer->current_context in trace_recursive_lock() (kernel/trace/ring_buffer.c) when an IPI (sysvec_call_function_single) preempts task context on the same CPU between the read at line 4485 and the write at line 4504, and itself calls ring_buffer_lock_reserve() -> trace_recursive_lock(). Because cpu_buffer->current_context is accessed using plain C reads and writes rather than READ_ONCE()/WRITE_ONCE() or data_race(), KCSAN flags the interleaved access by the interrupt handler. However, the race is benign because preemption is disabled and any interrupting context on the same CPU always pairs trace_recursive_lock() with trace_recursive_unlock() before returning, restoring cpu_buffer->current_context to its exact pre-interrupt value.

▶ ▼ ✨ Full AI root cause analysis
Based on kernel commit 666539eecdf4:

Root Cause Analysis

The KCSAN report is triggered by an unmarked read/write of the per-CPU recursion-tracking bitmask cpu_buffer->current_context (unsigned int in struct ring_buffer_per_cpu) inside trace_recursive_lock() (kernel/trace/ring_buffer.c:4482-4507), which is inlined into ring_buffer_lock_reserve() (kernel/trace/ring_buffer.c:5068).

Mechanism

  1. Task context on CPU 0: process_one_work() emits the workqueue_execute_end tracepoint, calling ring_buffer_lock_reserve(). It disables preemption via preempt_disable_notrace(), selects the CPU 0 struct ring_buffer_per_cpu *cpu_buffer, and enters trace_recursive_lock(cpu_buffer).
  2. Watchpoint setup: At kernel/trace/ring_buffer.c:4485, trace_recursive_lock() performs a plain load:
    unsigned int val = cpu_buffer->current_context;
    
    With CONFIG_KCSAN_INTERRUPT_WATCHER=y, KCSAN sets a watchpoint on &cpu_buffer->current_context and delays execution inside kcsan_setup_watchpoint() (kernel/kcsan/core.c:622).
  3. Interrupt context on CPU 0: During that delay, an IPI (sysvec_call_function_single -> __sysvec_call_function_single()) arrives on CPU 0 and emits the call_function_single_entry tracepoint (arch/x86/include/asm/trace/irq_vectors.h:98). This also calls ring_buffer_lock_reserve() -> trace_recursive_lock(cpu_buffer) on the same CPU 0 cpu_buffer.
  4. Conflicting write: The interrupt handler reads cpu_buffer->current_context, sets its context bit (RB_CTX_IRQ), and performs a plain store at kernel/trace/ring_buffer.c:4504:
    val |= (1 << (bit + cpu_buffer->nest));
    cpu_buffer->current_context = val;
    
    This triggers KCSAN's watchpoint, reporting a 4-byte read/write data race on cpu_buffer->current_context.

Why the Race Occurs and Invariants

  • kernel/trace/Makefile only disables KCSAN instrumentation (KCSAN_SANITIZE := n) when CONFIG_FUNCTION_TRACER is enabled; with function tracing disabled and CONFIG_KCSAN_INTERRUPT_WATCHER=y enabled, KCSAN instruments kernel/trace/ring_buffer.c and monitors accesses across interrupt boundaries on the same CPU.
  • trace_recursive_lock() (lines 4485, 4504) and trace_recursive_unlock() (lines 4512–4513) access cpu_buffer->current_context via plain C reads/writes without READ_ONCE()/WRITE_ONCE() or data_race().
  • Logically, the protocol preserves cpu_buffer->current_context across same-CPU interrupts:
    • ring_buffer_lock_reserve() disables preemption before calling trace_recursive_lock(), so only higher-priority interrupt contexts (softirq, hardirq, NMI) on the same CPU can preempt it.
    • Whenever trace_recursive_lock() in the interrupted task reaches line 4504, at most the task's RB_CTX_NORMAL bit (bit 4) was set and RB_CTX_TRANSITION (bit 0) was clear. An interrupting IRQ handler sets a strictly lower context bit (RB_CTX_IRQ, bit 2, or RB_CTX_NMI, bit 1) and always calls trace_recursive_unlock() (either on rb_reserve_next_event() failure at ring_buffer.c:5078 or on commit in ring_buffer_unlock_commit() at ring_buffer.c:4584 / ring_buffer_discard_commit() at ring_buffer.c:5167) before returning from the interrupt.
    • trace_recursive_unlock() clears the lowest set bit at or above cpu_buffer->nest (current_context &= current_context - (1 << cpu_buffer->nest)), which restores cpu_buffer->current_context to its exact pre-interrupt value before the task resumes at line 4504.

Annotating the accesses to cpu_buffer->current_context in trace_recursive_lock() and trace_recursive_unlock() with READ_ONCE() / WRITE_ONCE() (or data_race() if compiler reordering/tearing is otherwise prevented) resolves the KCSAN report.

▶ ▼ ✨ AI Jobs (2)
ID Workflow Result Correct Bug Created Started Finished Revision
b1a832a0 assessment-security DenialOfService: ❌ Exploitable: ❌ FilesystemTrigger: ❌ FuzzingArtifact: ❌ MemoryCorruption: ❌ NetworkNeedsSetup: ❌ NetworkTrigger: ❌ PeripheralTrigger: ❌ RemoteTrigger: ❌ Unprivileged: ❌ UserNamespace: ❌ VMGuestTrigger: ❌ VMHostTrigger: ❌ ❓ KCSAN: data-race in ring_buffer_lock_reserve / ring_buffer_lock_reserve 2026/11/19 20:23 2026/11/19 20:23 2026/11/19 20:30 229865fb
483826f8 assessment-kcsan Benign: ✅ ❓ KCSAN: data-race in ring_buffer_lock_reserve / ring_buffer_lock_reserve 2026/11/19 20:22 2026/11/19 20:22 2026/11/19 20:25 229865fb

Sample crash report:
==================================================================
BUG: KCSAN: data-race in ring_buffer_lock_reserve / ring_buffer_lock_reserve

write to 0xffff88810007a838 of 4 bytes by interrupt on cpu 0:
 trace_recursive_lock kernel/trace/ring_buffer.c:4504 [inline]
 ring_buffer_lock_reserve+0x210/0x9c0 kernel/trace/ring_buffer.c:5068
 __trace_buffer_lock_reserve kernel/trace/trace.h:1674 [inline]
 trace_event_buffer_lock_reserve+0x14a/0x300 kernel/trace/trace.c:1935
 trace_event_buffer_reserve+0x120/0x180 kernel/trace/trace_events.c:724
 do_trace_event_raw_event_x86_irq_vector arch/x86/include/asm/trace/irq_vectors.h:12 [inline]
 trace_event_raw_event_x86_irq_vector+0x9a/0x160 arch/x86/include/asm/trace/irq_vectors.h:12
 __do_trace_call_function_single_entry arch/x86/include/asm/trace/irq_vectors.h:98 [inline]
 trace_call_function_single_entry arch/x86/include/asm/trace/irq_vectors.h:98 [inline]
 __sysvec_call_function_single+0x8a/0x120 arch/x86/kernel/smp.c:270
 instr_sysvec_call_function_single arch/x86/kernel/smp.c:267 [inline]
 sysvec_call_function_single+0x66/0x80 arch/x86/kernel/smp.c:267
 asm_sysvec_call_function_single+0x1a/0x20 arch/x86/include/asm/idtentry.h:681
 native_pause arch/x86/include/asm/vdso/processor.h:13 [inline]
 delay_tsc+0x43/0xa0 arch/x86/lib/delay.c:76
 udelay include/asm-generic/delay.h:64 [inline]
 delay_access kernel/kcsan/core.c:332 [inline]
 kcsan_setup_watchpoint+0x255/0x3f0 kernel/kcsan/core.c:622
 trace_recursive_lock kernel/trace/ring_buffer.c:4485 [inline]
 ring_buffer_lock_reserve+0x14e/0x9c0 kernel/trace/ring_buffer.c:5068
 __trace_buffer_lock_reserve kernel/trace/trace.h:1674 [inline]
 trace_event_buffer_lock_reserve+0x14a/0x300 kernel/trace/trace.c:1935
 trace_event_buffer_reserve+0x120/0x180 kernel/trace/trace_events.c:724
 do_trace_event_raw_event_workqueue_execute_end include/trace/events/workqueue.h:111 [inline]
 trace_event_raw_event_workqueue_execute_end+0x83/0x160 include/trace/events/workqueue.h:111
 __do_trace_workqueue_execute_end include/trace/events/workqueue.h:111 [inline]
 trace_workqueue_execute_end include/trace/events/workqueue.h:111 [inline]
 process_one_work kernel/workqueue.c:3500 [inline]
 process_scheduled_works+0x9ff/0xab0 kernel/workqueue.c:3578
 worker_thread+0x56c/0x770 kernel/workqueue.c:3659
 kthread+0x248/0x2a0 kernel/kthread.c:436
 ret_from_fork+0x146/0x330 arch/x86/kernel/process.c:158
 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245

read to 0xffff88810007a838 of 4 bytes by task 662 on cpu 0:
 trace_recursive_lock kernel/trace/ring_buffer.c:4485 [inline]
 ring_buffer_lock_reserve+0x14e/0x9c0 kernel/trace/ring_buffer.c:5068
 __trace_buffer_lock_reserve kernel/trace/trace.h:1674 [inline]
 trace_event_buffer_lock_reserve+0x14a/0x300 kernel/trace/trace.c:1935
 trace_event_buffer_reserve+0x120/0x180 kernel/trace/trace_events.c:724
 do_trace_event_raw_event_workqueue_execute_end include/trace/events/workqueue.h:111 [inline]
 trace_event_raw_event_workqueue_execute_end+0x83/0x160 include/trace/events/workqueue.h:111
 __do_trace_workqueue_execute_end include/trace/events/workqueue.h:111 [inline]
 trace_workqueue_execute_end include/trace/events/workqueue.h:111 [inline]
 process_one_work kernel/workqueue.c:3500 [inline]
 process_scheduled_works+0x9ff/0xab0 kernel/workqueue.c:3578
 worker_thread+0x56c/0x770 kernel/workqueue.c:3659
 kthread+0x248/0x2a0 kernel/kthread.c:436
 ret_from_fork+0x146/0x330 arch/x86/kernel/process.c:158
 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245

Reported by Kernel Concurrency Sanitizer on:
CPU: 0 UID: 0 PID: 662 Comm: kworker/u8:10 Not tainted syzkaller #0 PREEMPT(lazy) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/06/2026
Workqueue: events_unbound nsim_dev_trap_report_work
==================================================================

Crashes (2):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2026/11/17 18:08 upstream 666539eecdf4 122f94d5 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in ring_buffer_lock_reserve / ring_buffer_lock_reserve
2026/11/17 11:05 upstream 666539eecdf4 43af6cac .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in ring_buffer_lock_reserve / ring_buffer_lock_reserve
* Struck through repros no longer work on HEAD.