syzbot


possible deadlock in j1939_sk_queue_drop_all
Status: upstream: reported on 2021/09/08 09:41
Reported-by: syzbot+3bd970a1887812621b4c@syzkaller.appspotmail.com
First crash: 264d, last: 40d

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
5.18.0-rc2-syzkaller-00275-g59250f8a7f3a #0 Not tainted
------------------------------------------------------
syz-executor.5/31383 is trying to acquire lock:
ffff8880259885c0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline]
ffff8880259885c0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_drop_all+0x40/0x2f0 net/can/j1939/socket.c:139

but task is already holding lock:
ffff88801d5410d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline]
ffff88801d5410d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: j1939_sk_netdev_event_netdown+0x28/0x160 net/can/j1939/socket.c:1266

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&priv->j1939_socks_lock){+.-.}-{2:2}:
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:354 [inline]
       j1939_sk_errqueue+0x9f/0x1a0 net/can/j1939/socket.c:1078
       __j1939_session_cancel+0x3b9/0x460 net/can/j1939/transport.c:1124
       j1939_tp_rxtimer.cold+0x1f6/0x24f net/can/j1939/transport.c:1249
       __run_hrtimer kernel/time/hrtimer.c:1685 [inline]
       __hrtimer_run_queues+0x609/0xe50 kernel/time/hrtimer.c:1749
       hrtimer_run_softirq+0x17b/0x360 kernel/time/hrtimer.c:1766
       __do_softirq+0x29b/0x9c2 kernel/softirq.c:558
       run_ksoftirqd kernel/softirq.c:921 [inline]
       run_ksoftirqd+0x2d/0x60 kernel/softirq.c:913
       smpboot_thread_fn+0x645/0x9c0 kernel/smpboot.c:164
       kthread+0x2e9/0x3a0 kernel/kthread.c:376
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298

-> #1 (&priv->active_session_list_lock){+.-.}-{2:2}:
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:354 [inline]
       j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
       j1939_session_activate+0x43/0x4b0 net/can/j1939/transport.c:1553
       j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline]
       j1939_sk_queue_activate_next+0x29b/0x460 net/can/j1939/socket.c:205
       j1939_session_deactivate_activate_next+0xc8/0xd3 net/can/j1939/transport.c:1101
       j1939_xtp_rx_abort_one.cold+0x20b/0x33c net/can/j1939/transport.c:1340
       j1939_xtp_rx_abort net/can/j1939/transport.c:1351 [inline]
       j1939_tp_cmd_recv net/can/j1939/transport.c:2100 [inline]
       j1939_tp_recv+0xb28/0xcb0 net/can/j1939/transport.c:2133
       j1939_can_recv+0x6ff/0x9a0 net/can/j1939/main.c:108
       deliver net/can/af_can.c:574 [inline]
       can_rcv_filter+0x5d4/0x8d0 net/can/af_can.c:608
       can_receive+0x31d/0x580 net/can/af_can.c:665
       can_rcv+0x120/0x1c0 net/can/af_can.c:696
       __netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:5405
       __netif_receive_skb+0x24/0x1b0 net/core/dev.c:5519
       process_backlog+0x3a0/0x7c0 net/core/dev.c:5847
       __napi_poll+0xb3/0x6e0 net/core/dev.c:6413
       napi_poll net/core/dev.c:6480 [inline]
       net_rx_action+0x8ec/0xc60 net/core/dev.c:6567
       __do_softirq+0x29b/0x9c2 kernel/softirq.c:558
       run_ksoftirqd kernel/softirq.c:921 [inline]
       run_ksoftirqd+0x2d/0x60 kernel/softirq.c:913
       smpboot_thread_fn+0x645/0x9c0 kernel/smpboot.c:164
       kthread+0x2e9/0x3a0 kernel/kthread.c:376
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298

-> #0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}:
       check_prev_add kernel/locking/lockdep.c:3065 [inline]
       check_prevs_add kernel/locking/lockdep.c:3188 [inline]
       validate_chain kernel/locking/lockdep.c:3803 [inline]
       __lock_acquire+0x2ac6/0x56c0 kernel/locking/lockdep.c:5029
       lock_acquire kernel/locking/lockdep.c:5641 [inline]
       lock_acquire+0x1ab/0x510 kernel/locking/lockdep.c:5606
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:354 [inline]
       j1939_sk_queue_drop_all+0x40/0x2f0 net/can/j1939/socket.c:139
       j1939_sk_netdev_event_netdown+0x7b/0x160 net/can/j1939/socket.c:1272
       j1939_netdev_notify+0x199/0x1d0 net/can/j1939/main.c:372
       notifier_call_chain+0xb5/0x200 kernel/notifier.c:84
       call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1938
       call_netdevice_notifiers_extack net/core/dev.c:1976 [inline]
       call_netdevice_notifiers net/core/dev.c:1990 [inline]
       __dev_notify_flags+0x1da/0x2b0 net/core/dev.c:8473
       dev_change_flags+0x112/0x170 net/core/dev.c:8509
       do_setlink+0x96d/0x3a20 net/core/rtnetlink.c:2731
       __rtnl_newlink+0xdf8/0x1760 net/core/rtnetlink.c:3416
       rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3531
       rtnetlink_rcv_msg+0x413/0xb80 net/core/rtnetlink.c:5993
       netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2496
       netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
       netlink_unicast+0x543/0x7f0 net/netlink/af_netlink.c:1345
       netlink_sendmsg+0x904/0xe00 net/netlink/af_netlink.c:1921
       sock_sendmsg_nosec net/socket.c:705 [inline]
       sock_sendmsg+0xcf/0x120 net/socket.c:725
       ____sys_sendmsg+0x6e2/0x800 net/socket.c:2413
       ___sys_sendmsg+0xf3/0x170 net/socket.c:2467
       __sys_sendmsg+0xe5/0x1b0 net/socket.c:2496
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x44/0xae

other info that might help us debug this:

Chain exists of:
  &jsk->sk_session_queue_lock --> &priv->active_session_list_lock --> &priv->j1939_socks_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&priv->j1939_socks_lock);
                               lock(&priv->active_session_list_lock);
                               lock(&priv->j1939_socks_lock);
  lock(&jsk->sk_session_queue_lock);

 *** DEADLOCK ***

2 locks held by syz-executor.5/31383:
 #0: ffffffff8d54fd68 (rtnl_mutex){+.+.}-{3:3}, at: rtnl_lock net/core/rtnetlink.c:72 [inline]
 #0: ffffffff8d54fd68 (rtnl_mutex){+.+.}-{3:3}, at: rtnetlink_rcv_msg+0x3be/0xb80 net/core/rtnetlink.c:5990
 #1: ffff88801d5410d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline]
 #1: ffff88801d5410d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: j1939_sk_netdev_event_netdown+0x28/0x160 net/can/j1939/socket.c:1266

stack backtrace:
CPU: 1 PID: 31383 Comm: syz-executor.5 Not tainted 5.18.0-rc2-syzkaller-00275-g59250f8a7f3a #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2145
 check_prev_add kernel/locking/lockdep.c:3065 [inline]
 check_prevs_add kernel/locking/lockdep.c:3188 [inline]
 validate_chain kernel/locking/lockdep.c:3803 [inline]
 __lock_acquire+0x2ac6/0x56c0 kernel/locking/lockdep.c:5029
 lock_acquire kernel/locking/lockdep.c:5641 [inline]
 lock_acquire+0x1ab/0x510 kernel/locking/lockdep.c:5606
 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
 _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178
 spin_lock_bh include/linux/spinlock.h:354 [inline]
 j1939_sk_queue_drop_all+0x40/0x2f0 net/can/j1939/socket.c:139
 j1939_sk_netdev_event_netdown+0x7b/0x160 net/can/j1939/socket.c:1272
 j1939_netdev_notify+0x199/0x1d0 net/can/j1939/main.c:372
 notifier_call_chain+0xb5/0x200 kernel/notifier.c:84
 call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1938
 call_netdevice_notifiers_extack net/core/dev.c:1976 [inline]
 call_netdevice_notifiers net/core/dev.c:1990 [inline]
 __dev_notify_flags+0x1da/0x2b0 net/core/dev.c:8473
 dev_change_flags+0x112/0x170 net/core/dev.c:8509
 do_setlink+0x96d/0x3a20 net/core/rtnetlink.c:2731
 __rtnl_newlink+0xdf8/0x1760 net/core/rtnetlink.c:3416
 rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3531
 rtnetlink_rcv_msg+0x413/0xb80 net/core/rtnetlink.c:5993
 netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2496
 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
 netlink_unicast+0x543/0x7f0 net/netlink/af_netlink.c:1345
 netlink_sendmsg+0x904/0xe00 net/netlink/af_netlink.c:1921
 sock_sendmsg_nosec net/socket.c:705 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:725
 ____sys_sendmsg+0x6e2/0x800 net/socket.c:2413
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2467
 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2496
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7ff5f36890e9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff5f4775168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007ff5f379c030 RCX: 00007ff5f36890e9
RDX: 0000000000000000 RSI: 0000000020000140 RDI: 0000000000000003
RBP: 00007ff5f36e308d R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ff5f3ccfb1f R14: 00007ff5f4775300 R15: 0000000000022000
 </TASK>
net_ratelimit: 35 callbacks suppressed
A link change request failed with some changes committed already. Interface vxcan0 may have been left with an inconsistent configuration, please check.

Crashes (174):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Title
ci-upstream-kasan-gce 2022/04/16 07:43 upstream 59250f8a7f3a 8bcc32a6 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce 2022/03/18 21:18 upstream 551acdc3c3d2 e2d91b1d .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce 2022/02/04 22:26 upstream dcb85f85fa6f e13a05ed .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-selinux-root 2022/02/03 13:41 upstream 88808fbbead4 4ebb2798 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce 2022/02/02 03:47 upstream 9f7fb8de5d9b 4ebb2798 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-smack-root 2022/02/01 02:01 upstream 26291c54e111 6b7c57fe .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce 2022/01/31 23:04 upstream 26291c54e111 6b7c57fe .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce 2022/01/31 00:59 upstream 24f4db1f3a27 495e00c5 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-selinux-root 2022/01/30 23:53 upstream 26291c54e111 495e00c5 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-selinux-root 2022/01/29 23:18 upstream f8c7e4ede46f 495e00c5 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce 2022/01/29 11:27 upstream 169387e2aa29 495e00c5 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce 2022/01/29 10:20 upstream 169387e2aa29 495e00c5 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-root 2022/01/28 18:35 upstream df0001545b27 495e00c5 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-selinux-root 2022/01/27 12:36 upstream 626b2dda7651 2cbffd88 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce 2022/01/26 15:47 upstream 0280e3c58f92 2cbffd88 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce 2022/01/25 22:51 upstream 0280e3c58f92 2cbffd88 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce 2022/01/25 07:48 upstream a08b41ab9e2e 2cbffd88 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce 2022/01/25 03:16 upstream dd81e1c7d5fb 2cbffd88 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-selinux-root 2022/01/24 22:50 upstream dd81e1c7d5fb 2cbffd88 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-selinux-root 2022/01/24 20:18 upstream dd81e1c7d5fb 2cbffd88 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-selinux-root 2022/01/23 18:33 upstream dd81e1c7d5fb 214351e1 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-selinux-root 2022/01/22 18:27 upstream 0809edbae347 214351e1 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-smack-root 2022/01/22 15:09 upstream 0809edbae347 214351e1 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce 2022/01/21 04:19 upstream 2c271fe77d52 ab3d9f17 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce 2022/01/20 16:19 upstream fa2e1ba3e9e3 b838eb76 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-smack-root 2022/01/19 21:47 upstream 1d1df41c5a33 5da9499f .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce 2022/01/19 18:37 upstream e9f5cbc0c851 0620189b .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-386 2022/04/04 03:42 upstream 09bb8856d4a7 79a2a8fc .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-qemu-upstream-386 2022/02/05 02:25 upstream cff7f2237c2b e13a05ed .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-386 2022/02/04 12:29 upstream dcb85f85fa6f a3e470b2 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-386 2022/01/31 10:58 upstream 26291c54e111 6b7c57fe .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-386 2022/01/30 00:38 upstream f8c7e4ede46f 495e00c5 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-386 2022/01/29 13:15 upstream 169387e2aa29 495e00c5 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-386 2022/01/27 10:25 upstream 626b2dda7651 2cbffd88 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-386 2022/01/25 20:45 upstream 0280e3c58f92 2cbffd88 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-386 2022/01/24 21:33 upstream dd81e1c7d5fb 2cbffd88 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-386 2022/01/24 18:46 upstream dd81e1c7d5fb 2cbffd88 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-386 2022/01/23 20:12 upstream dd81e1c7d5fb 214351e1 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-386 2022/01/23 07:45 upstream 1c52283265a4 214351e1 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-386 2022/01/22 19:40 upstream 0809edbae347 214351e1 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-386 2022/01/22 17:07 upstream 0809edbae347 214351e1 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-386 2022/01/21 05:41 upstream 2c271fe77d52 ab3d9f17 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-386 2022/01/20 18:24 upstream fa2e1ba3e9e3 b838eb76 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-kasan-gce-386 2022/01/20 15:17 upstream fa2e1ba3e9e3 b838eb76 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-net-this-kasan-gce 2022/02/09 17:35 net 23de0d7b6f0e 0b33604d .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-net-kasan-gce 2021/11/10 03:45 net-next cc0356d6a02e 55fa030c .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-net-kasan-gce 2021/09/04 19:28 net-next 29ce8f970107 d236a457 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-linux-next-kasan-gce-root 2022/02/16 04:17 linux-next ef6b35306dd8 8b9ca619 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-linux-next-kasan-gce-root 2022/02/03 10:54 linux-next 2d3d8c7643a5 4ebb2798 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-linux-next-kasan-gce-root 2022/02/01 15:30 linux-next 711428e8f370 c1c1631d .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-linux-next-kasan-gce-root 2022/01/31 12:01 linux-next 887a333c44eb 6b7c57fe .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-linux-next-kasan-gce-root 2022/01/24 15:50 linux-next 74e5dee6a5b9 214351e1 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-linux-next-kasan-gce-root 2022/01/21 02:53 linux-next c94951012a74 ab3d9f17 .config log report info possible deadlock in j1939_sk_queue_drop_all
ci-upstream-linux-next-kasan-gce-root 2022/01/20 06:30 linux-next 7fc5253f5a13 5da9499f .config log report info possible deadlock in j1939_sk_queue_drop_all