syzbot

ntfs3(loop8): Mark volume as dirty due to NTFS errors
======================================================
WARNING: possible circular locking dependency detected
6.16.0-syzkaller #0 Not tainted
------------------------------------------------------
syz.8.2394/12867 is trying to acquire lock:
ffff88804a006a68 (&sb->s_type->i_mutex_key#30){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline]
ffff88804a006a68 (&sb->s_type->i_mutex_key#30){+.+.}-{4:4}, at: ntfs_file_mmap+0x525/0x730 fs/ntfs3/file.c:313

but task is already holding lock:
ffff88807e4d15e0 (&mm->mmap_lock){++++}-{4:4}, at: mmap_write_lock_killable include/linux/mmap_lock.h:374 [inline]
ffff88807e4d15e0 (&mm->mmap_lock){++++}-{4:4}, at: vm_mmap_pgoff+0x1bd/0x4c0 mm/util.c:577

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&mm->mmap_lock){++++}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
       gup_fast_fallback+0x22e/0x2260 mm/gup.c:3347
       iov_iter_extract_user_pages lib/iov_iter.c:1846 [inline]
       iov_iter_extract_pages+0x35a/0x5e0 lib/iov_iter.c:1909
       dio_refill_pages fs/direct-io.c:172 [inline]
       dio_get_page fs/direct-io.c:213 [inline]
       do_direct_IO fs/direct-io.c:915 [inline]
       __blockdev_direct_IO+0x114f/0x33d0 fs/direct-io.c:1243
       blockdev_direct_IO include/linux/fs.h:3477 [inline]
       ntfs_direct_IO+0x20b/0x410 fs/ntfs3/inode.c:813
       generic_file_direct_write+0x1db/0x3e0 mm/filemap.c:4046
       __generic_file_write_iter+0x11d/0x230 mm/filemap.c:4215
       ntfs_file_write_iter+0x71c/0x820 fs/ntfs3/file.c:1197
       new_sync_write fs/read_write.c:593 [inline]
       vfs_write+0x54b/0xa90 fs/read_write.c:686
       ksys_write+0x145/0x250 fs/read_write.c:738
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&sb->s_type->i_mutex_key#30){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3168 [inline]
       check_prevs_add kernel/locking/lockdep.c:3287 [inline]
       validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911
       __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
       down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:869 [inline]
       ntfs_file_mmap+0x525/0x730 fs/ntfs3/file.c:313
       call_mmap include/linux/fs.h:2286 [inline]
       mmap_file mm/internal.h:167 [inline]
       __mmap_new_file_vma mm/vma.c:2405 [inline]
       __mmap_new_vma mm/vma.c:2467 [inline]
       __mmap_region mm/vma.c:2622 [inline]
       mmap_region+0x127a/0x1f30 mm/vma.c:2692
       do_mmap+0xc45/0x10d0 mm/mmap.c:561
       vm_mmap_pgoff+0x31b/0x4c0 mm/util.c:579
       ksys_mmap_pgoff+0x51f/0x760 mm/mmap.c:607
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&mm->mmap_lock);
                               lock(&sb->s_type->i_mutex_key#30);
                               lock(&mm->mmap_lock);
  lock(&sb->s_type->i_mutex_key#30);

 *** DEADLOCK ***

1 lock held by syz.8.2394/12867:
 #0: ffff88807e4d15e0 (&mm->mmap_lock){++++}-{4:4}, at: mmap_write_lock_killable include/linux/mmap_lock.h:374 [inline]
 #0: ffff88807e4d15e0 (&mm->mmap_lock){++++}-{4:4}, at: vm_mmap_pgoff+0x1bd/0x4c0 mm/util.c:577

stack backtrace:
CPU: 0 UID: 0 PID: 12867 Comm: syz.8.2394 Not tainted 6.16.0-syzkaller #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2046
 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3168 [inline]
 check_prevs_add kernel/locking/lockdep.c:3287 [inline]
 validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911
 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
 down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
 inode_lock include/linux/fs.h:869 [inline]
 ntfs_file_mmap+0x525/0x730 fs/ntfs3/file.c:313
 call_mmap include/linux/fs.h:2286 [inline]
 mmap_file mm/internal.h:167 [inline]
 __mmap_new_file_vma mm/vma.c:2405 [inline]
 __mmap_new_vma mm/vma.c:2467 [inline]
 __mmap_region mm/vma.c:2622 [inline]
 mmap_region+0x127a/0x1f30 mm/vma.c:2692
 do_mmap+0xc45/0x10d0 mm/mmap.c:561
 vm_mmap_pgoff+0x31b/0x4c0 mm/util.c:579
 ksys_mmap_pgoff+0x51f/0x760 mm/mmap.c:607
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f07f818e9a9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f07f9014038 EFLAGS: 00000246 ORIG_RAX: 0000000000000009
RAX: ffffffffffffffda RBX: 00007f07f83b5fa0 RCX: 00007f07f818e9a9
RDX: 00000000027fffff RSI: 0000000000600000 RDI: 0000200000000000
RBP: 00007f07f8210d69 R08: 0000000000000004 R09: 0000000000003000
R10: 0000000004002011 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f07f83b5fa0 R15: 00007ffc7bfaa7c8
 </TASK>