syzbot

loop1: detected capacity change from 0 to 1024
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.1.2363/14441 is trying to acquire lock:
ffff8880711f8e88 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1b3/0x1950 fs/hfsplus/extents.c:455

but task is already holding lock:
ffff888022aae0b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfsplus_find_init+0x150/0x1c0 fs/hfsplus/bfind.c:28

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&tree->tree_lock/1){+.+.}-{3:3}:
       __mutex_lock_common+0x1eb/0x2390 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hfsplus_find_init+0x150/0x1c0 fs/hfsplus/bfind.c:28
       hfsplus_file_truncate+0x38c/0xb40 fs/hfsplus/extents.c:580
       hfsplus_setattr+0x1c0/0x280 fs/hfsplus/inode.c:267
       notify_change+0xbcd/0xee0 fs/attr.c:505
       do_truncate+0x197/0x220 fs/open.c:65
       vfs_truncate+0x262/0x2f0 fs/open.c:111
       do_sys_truncate+0xdc/0x190 fs/open.c:134
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
       lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1eb/0x2390 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hfsplus_file_extend+0x1b3/0x1950 fs/hfsplus/extents.c:455
       hfsplus_bmap_reserve+0x11e/0x4f0 fs/hfsplus/btree.c:357
       __hfsplus_ext_write_extent+0x28d/0x5b0 fs/hfsplus/extents.c:104
       __hfsplus_ext_cache_extent+0x89/0xe20 fs/hfsplus/extents.c:186
       hfsplus_file_truncate+0x467/0xb40 fs/hfsplus/extents.c:597
       hfsplus_setattr+0x1c0/0x280 fs/hfsplus/inode.c:267
       notify_change+0xbcd/0xee0 fs/attr.c:505
       do_truncate+0x197/0x220 fs/open.c:65
       vfs_truncate+0x262/0x2f0 fs/open.c:111
       do_sys_truncate+0xdc/0x190 fs/open.c:134
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&tree->tree_lock/1);
                               lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&tree->tree_lock/1);
  lock(&HFSPLUS_I(inode)->extents_lock);

 *** DEADLOCK ***

4 locks held by syz.1.2363/14441:
 #0: ffff888074500460 (sb_writers#27){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:386
 #1: ffff88807dabe180 (&sb->s_type->i_mutex_key#33){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #1: ffff88807dabe180 (&sb->s_type->i_mutex_key#33){+.+.}-{3:3}, at: do_truncate+0x183/0x220 fs/open.c:63
 #2: ffff88807dabdf88 (&hip->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x2a0/0xb40 fs/hfsplus/extents.c:574
 #3: ffff888022aae0b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfsplus_find_init+0x150/0x1c0 fs/hfsplus/bfind.c:28

stack backtrace:
CPU: 1 PID: 14441 Comm: syz.1.2363 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x230 lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
 __mutex_lock_common+0x1eb/0x2390 kernel/locking/mutex.c:596
 __mutex_lock kernel/locking/mutex.c:729 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
 hfsplus_file_extend+0x1b3/0x1950 fs/hfsplus/extents.c:455
 hfsplus_bmap_reserve+0x11e/0x4f0 fs/hfsplus/btree.c:357
 __hfsplus_ext_write_extent+0x28d/0x5b0 fs/hfsplus/extents.c:104
 __hfsplus_ext_cache_extent+0x89/0xe20 fs/hfsplus/extents.c:186
 hfsplus_file_truncate+0x467/0xb40 fs/hfsplus/extents.c:597
 hfsplus_setattr+0x1c0/0x280 fs/hfsplus/inode.c:267
 notify_change+0xbcd/0xee0 fs/attr.c:505
 do_truncate+0x197/0x220 fs/open.c:65
 vfs_truncate+0x262/0x2f0 fs/open.c:111
 do_sys_truncate+0xdc/0x190 fs/open.c:134
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f3e41840fc9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f3e3faa8038 EFLAGS: 00000246 ORIG_RAX: 000000000000004c
RAX: ffffffffffffffda RBX: 00007f3e41a97fa0 RCX: 00007f3e41840fc9
RDX: 0000000000000000 RSI: 000000000000fbb0 RDI: 0000200000000000
RBP: 00007f3e418c3f91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f3e41a98038 R14: 00007f3e41a97fa0 R15: 00007fff2dff4b38
 </TASK>