syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.4.1309/8134 is trying to acquire lock:
ffff888050da6648 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1b3/0x1950 fs/hfsplus/extents.c:455

but task is already holding lock:
ffff88805000e0b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfsplus_find_init+0x150/0x1c0 fs/hfsplus/bfind.c:28

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&tree->tree_lock/1){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x120/0xaf0 kernel/locking/mutex.c:747
       hfsplus_find_init+0x150/0x1c0 fs/hfsplus/bfind.c:28
       hfsplus_ext_read_extent fs/hfsplus/extents.c:216 [inline]
       hfsplus_get_block+0x8da/0x1530 fs/hfsplus/extents.c:268
       block_read_full_folio+0x3c9/0xed0 fs/buffer.c:2271
       read_pages+0x5fd/0x840 mm/readahead.c:181
       page_cache_ra_unbounded+0x690/0x770 mm/readahead.c:270
       page_cache_sync_readahead include/linux/pagemap.h:1248 [inline]
       filemap_get_pages mm/filemap.c:2665 [inline]
       filemap_read+0x5ff/0x2f80 mm/filemap.c:2759
       generic_file_read_iter+0x115/0x670 mm/filemap.c:2914
       __kernel_read+0x2dc/0x6b0 fs/read_write.c:428
       integrity_kernel_read+0x86/0xd0 security/integrity/iint.c:228
       ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:485 [inline]
       ima_calc_file_shash security/integrity/ima/ima_crypto.c:516 [inline]
       ima_calc_file_hash+0x96b/0x17c0 security/integrity/ima/ima_crypto.c:573
       ima_collect_measurement+0x4b3/0xac0 security/integrity/ima/ima_api.c:293
       process_measurement+0xfae/0x1a10 security/integrity/ima/ima_main.c:351
       ima_file_check+0xc2/0x100 security/integrity/ima/ima_main.c:534
       do_open fs/namei.c:3636 [inline]
       path_openat+0x2679/0x2e70 fs/namei.c:3791
       do_filp_open+0x1c1/0x3c0 fs/namei.c:3818
       do_sys_openat2+0x142/0x490 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1345
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
       lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x120/0xaf0 kernel/locking/mutex.c:747
       hfsplus_file_extend+0x1b3/0x1950 fs/hfsplus/extents.c:455
       hfsplus_bmap_reserve+0x11e/0x4f0 fs/hfsplus/btree.c:358
       __hfsplus_ext_write_extent+0x28d/0x5b0 fs/hfsplus/extents.c:104
       __hfsplus_ext_cache_extent+0x89/0xe20 fs/hfsplus/extents.c:186
       hfsplus_file_truncate+0x455/0xb30 fs/hfsplus/extents.c:597
       hfsplus_setattr+0x1c0/0x280 fs/hfsplus/inode.c:269
       notify_change+0xc74/0xf40 fs/attr.c:499
       do_truncate+0x197/0x220 fs/open.c:65
       vfs_truncate+0x262/0x2f0 fs/open.c:111
       do_sys_truncate+0xdc/0x190 fs/open.c:134
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&tree->tree_lock/1);
                               lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&tree->tree_lock/1);
  lock(&HFSPLUS_I(inode)->extents_lock);

 *** DEADLOCK ***

4 locks held by syz.4.1309/8134:
 #0: ffff88807381e460 (sb_writers#20){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:402
 #1: ffff888050da3240 (&sb->s_type->i_mutex_key#37){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff888050da3240 (&sb->s_type->i_mutex_key#37){+.+.}-{3:3}, at: do_truncate+0x183/0x220 fs/open.c:63
 #2: ffff888050da3048 (&hip->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x28f/0xb30 fs/hfsplus/extents.c:574
 #3: ffff88805000e0b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfsplus_find_init+0x150/0x1c0 fs/hfsplus/bfind.c:28

stack backtrace:
CPU: 1 PID: 8134 Comm: syz.4.1309 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x22e lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x120/0xaf0 kernel/locking/mutex.c:747
 hfsplus_file_extend+0x1b3/0x1950 fs/hfsplus/extents.c:455
 hfsplus_bmap_reserve+0x11e/0x4f0 fs/hfsplus/btree.c:358
 __hfsplus_ext_write_extent+0x28d/0x5b0 fs/hfsplus/extents.c:104
 __hfsplus_ext_cache_extent+0x89/0xe20 fs/hfsplus/extents.c:186
 hfsplus_file_truncate+0x455/0xb30 fs/hfsplus/extents.c:597
 hfsplus_setattr+0x1c0/0x280 fs/hfsplus/inode.c:269
 notify_change+0xc74/0xf40 fs/attr.c:499
 do_truncate+0x197/0x220 fs/open.c:65
 vfs_truncate+0x262/0x2f0 fs/open.c:111
 do_sys_truncate+0xdc/0x190 fs/open.c:134
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f068838efc9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f06892e2038 EFLAGS: 00000246 ORIG_RAX: 000000000000004c
RAX: ffffffffffffffda RBX: 00007f06885e6090 RCX: 00007f068838efc9
RDX: 0000000000000000 RSI: 000000000000fbb0 RDI: 0000200000000000
RBP: 00007f0688411f91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f06885e6128 R14: 00007f06885e6090 R15: 00007ffe0d8bb778
 </TASK>