syzbot

ocfs2: Mounting device (7,8) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.16.0-rc5-syzkaller-00266-g3f31a806a62e #0 Not tainted
------------------------------------------------------
syz.8.3324/21029 is trying to acquire lock:
ffff8880416bdf40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline]
ffff8880416bdf40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}, at: ocfs2_move_extent fs/ocfs2/move_extents.c:640 [inline]
ffff8880416bdf40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}, at: __ocfs2_move_extents_range+0x1a68/0x3370 fs/ocfs2/move_extents.c:860

but task is already holding lock:
ffff8880416b5f40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline]
ffff8880416b5f40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: ocfs2_move_extent fs/ocfs2/move_extents.c:632 [inline]
ffff8880416b5f40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: __ocfs2_move_extents_range+0x1374/0x3370 fs/ocfs2/move_extents.c:860

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
       down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:869 [inline]
       __ocfs2_flush_truncate_log+0x33c/0x10e0 fs/ocfs2/alloc.c:6054
       ocfs2_flush_truncate_log+0x4f/0x70 fs/ocfs2/alloc.c:6084
       ocfs2_sync_fs+0x116/0x310 fs/ocfs2/super.c:406
       sync_filesystem+0x1cf/0x230 fs/sync.c:66
       generic_shutdown_super+0x6f/0x2c0 fs/super.c:622
       kill_block_super+0x44/0x90 fs/super.c:1755
       deactivate_locked_super+0xbc/0x130 fs/super.c:474
       cleanup_mnt+0x425/0x4c0 fs/namespace.c:1417
       task_work_run+0x1d4/0x260 kernel/task_work.c:227
       resume_user_mode_work include/linux/resume_user_mode.h:50 [inline]
       exit_to_user_mode_loop+0xec/0x110 kernel/entry/common.c:114
       exit_to_user_mode_prepare include/linux/entry-common.h:330 [inline]
       syscall_exit_to_user_mode_work include/linux/entry-common.h:414 [inline]
       syscall_exit_to_user_mode include/linux/entry-common.h:449 [inline]
       do_syscall_64+0x2bd/0x3b0 arch/x86/entry/syscall_64.c:100
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3168 [inline]
       check_prevs_add kernel/locking/lockdep.c:3287 [inline]
       validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911
       __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
       down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:869 [inline]
       ocfs2_move_extent fs/ocfs2/move_extents.c:640 [inline]
       __ocfs2_move_extents_range+0x1a68/0x3370 fs/ocfs2/move_extents.c:860
       ocfs2_move_extents+0x378/0x960 fs/ocfs2/move_extents.c:927
       ocfs2_ioctl_move_extents+0x53e/0x710 fs/ocfs2/move_extents.c:1053
       ocfs2_ioctl+0x191/0x750 fs/ocfs2/ioctl.c:946
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:907 [inline]
       __se_sys_ioctl+0xfc/0x170 fs/ioctl.c:893
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5);

 *** DEADLOCK ***

5 locks held by syz.8.3324/21029:
 #0: ffff8880369e4428 (sb_writers#30){.+.+}-{0:0}, at: mnt_want_write_file+0x60/0x200 fs/namespace.c:601
 #1: ffff8880416bc2c0 (&sb->s_type->i_mutex_key#38){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline]
 #1: ffff8880416bc2c0 (&sb->s_type->i_mutex_key#38){+.+.}-{4:4}, at: ocfs2_move_extents+0x1a2/0x960 fs/ocfs2/move_extents.c:905
 #2: ffff8880416bbf60 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_move_extents+0x36b/0x960 fs/ocfs2/move_extents.c:925
 #3: ffff8880416b89c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline]
 #3: ffff8880416b89c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x15e/0x4640 fs/ocfs2/suballoc.c:788
 #4: ffff8880416b5f40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline]
 #4: ffff8880416b5f40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: ocfs2_move_extent fs/ocfs2/move_extents.c:632 [inline]
 #4: ffff8880416b5f40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: __ocfs2_move_extents_range+0x1374/0x3370 fs/ocfs2/move_extents.c:860

stack backtrace:
CPU: 0 UID: 0 PID: 21029 Comm: syz.8.3324 Not tainted 6.16.0-rc5-syzkaller-00266-g3f31a806a62e #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2046
 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3168 [inline]
 check_prevs_add kernel/locking/lockdep.c:3287 [inline]
 validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911
 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
 down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
 inode_lock include/linux/fs.h:869 [inline]
 ocfs2_move_extent fs/ocfs2/move_extents.c:640 [inline]
 __ocfs2_move_extents_range+0x1a68/0x3370 fs/ocfs2/move_extents.c:860
 ocfs2_move_extents+0x378/0x960 fs/ocfs2/move_extents.c:927
 ocfs2_ioctl_move_extents+0x53e/0x710 fs/ocfs2/move_extents.c:1053
 ocfs2_ioctl+0x191/0x750 fs/ocfs2/ioctl.c:946
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:907 [inline]
 __se_sys_ioctl+0xfc/0x170 fs/ioctl.c:893
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fd3d678e929
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fd3d45f6038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007fd3d69b5fa0 RCX: 00007fd3d678e929
RDX: 00002000000000c0 RSI: 0000000040406f06 RDI: 0000000000000004
RBP: 00007fd3d6810b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fd3d69b5fa0 R15: 00007fff74f61e18
 </TASK>