syzbot


panic: unhandled af

Status: fixed on 2020/01/09 12:20
Reported-by: syzbot+92be143c2dd1746cf2af@syzkaller.appspotmail.com
Fix commit: 4804479228fb Check address family of pf ioctl(2) DIOCNATLOOK parameter at kernel entry instead of calling panic() due to unhandled af. Reported-by: syzbot+92be143c2dd1746cf2af@syzkaller.appspotmail.com from Benjamin Baier
First crash: 1059d, last: 1057d
duplicates (12):
Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
panic: unhandled af 226 C 2 1060d 1060d 0/3 closed as dup on 2020/01/03 12:49
panic: unhandled af 38 C 2 1062d 1062d 0/3 closed as dup on 2020/01/03 12:47
panic: unhandled af 152 C 2 1059d 1059d 0/3 closed as dup on 2020/01/03 12:49
panic: unhandled af 210 C 2 1060d 1060d 0/3 closed as dup on 2020/01/03 12:48
panic: unhandled af 115 C 2 1060d 1060d 0/3 closed as dup on 2020/01/03 12:49
panic: unhandled af 1 C 2 1060d 1060d 0/3 closed as dup on 2020/01/03 12:49
panic: unhandled af 0 C 2 1061d 1061d 0/3 closed as dup on 2020/01/03 12:47
panic: unhandled af 66 C 2 1060d 1061d 0/3 closed as dup on 2020/01/03 12:48
panic: unhandled af 254 C 2 1061d 1061d 0/3 closed as dup on 2020/01/03 12:48
panic: unhandled af 105 C 3 1061d 1062d 0/3 closed as dup on 2020/01/03 12:46
panic: unhandled af 173 C 2 1061d 1061d 0/3 closed as dup on 2020/01/03 12:47
panic: unhandled af 187 C 2 1060d 1060d 0/3 closed as dup on 2020/01/03 12:49
similar bugs (3):
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
openbsd panic: unhandled af (3) syz 7 871d 880d 0/3 closed as invalid on 2020/10/03 07:42
openbsd panic: unhandled af (4) syz 11 309d 338d 3/3 fixed on 2022/01/25 13:33
openbsd panic: unhandled af (2) C 22 883d 909d 3/3 fixed on 2020/06/28 14:37

Sample crash report:
login: panic: unhandled af 0
Stopped at      db_enter+0x18:  addq    $0x8,%rsp
    TID    PID    UID     PRFLAGS     PFLAGS  CPU  COMMAND
*431504  21063      0         0x2          0    0K syz-executor1752
 418029  65764      0        0x12          0    1  sshd
db_enter() at db_enter+0x18 sys/arch/amd64/amd64/db_interface.c:398
panic(ffffffff821d7d9a) at panic+0x15c sys/kern/subr_prf.c:207
unhandled_af(0) at unhandled_af+0x16
pf_addrcpy(ffff800020b1aef8,ffff800020b1b1f0,0) at pf_addrcpy+0x99 sys/net/pf.c:409
pfioctl(4900,c0504417,ffff800020b1b1f0,1,ffff800020ad8010) at pfioctl+0x43cf sys/net/pf_ioctl.c:1827
VOP_IOCTL(fffffd806f6cd360,c0504417,ffff800020b1b1f0,1,fffffd807f7be960,ffff800020ad8010) at VOP_IOCTL+0x88 sys/kern/vfs_vops.c:291
vn_ioctl(fffffd807726cb48,c0504417,ffff800020b1b1f0,ffff800020ad8010) at vn_ioctl+0xb7 sys/kern/vfs_vnops.c:533
sys_ioctl(ffff800020ad8010,ffff800020b1b308,ffff800020b1b350) at sys_ioctl+0x5b9
syscall(ffff800020b1b3d0) at syscall+0x4a4 mi_syscall sys/sys/syscall_mi.h:92 [inline]
syscall(ffff800020b1b3d0) at syscall+0x4a4 sys/arch/amd64/amd64/trap.c:555
Xsyscall() at Xsyscall+0x128
end of kernel
end trace frame: 0x7f7ffffe3020, count: 5
https://www.openbsd.org/ddb.html describes the minimum info required in bug
reports.  Insufficient info makes it difficult to find and fix bugs.
ddb{0}> 
ddb{0}> set $lines = 0
ddb{0}> set $maxwidth = 0
ddb{0}> show panic
unhandled af 0
ddb{0}> trace
db_enter() at db_enter+0x18 sys/arch/amd64/amd64/db_interface.c:398
panic(ffffffff821d7d9a) at panic+0x15c sys/kern/subr_prf.c:207
unhandled_af(0) at unhandled_af+0x16
pf_addrcpy(ffff800020b1aef8,ffff800020b1b1f0,0) at pf_addrcpy+0x99 sys/net/pf.c:409
pfioctl(4900,c0504417,ffff800020b1b1f0,1,ffff800020ad8010) at pfioctl+0x43cf sys/net/pf_ioctl.c:1827
VOP_IOCTL(fffffd806f6cd360,c0504417,ffff800020b1b1f0,1,fffffd807f7be960,ffff800020ad8010) at VOP_IOCTL+0x88 sys/kern/vfs_vops.c:291
vn_ioctl(fffffd807726cb48,c0504417,ffff800020b1b1f0,ffff800020ad8010) at vn_ioctl+0xb7 sys/kern/vfs_vnops.c:533
sys_ioctl(ffff800020ad8010,ffff800020b1b308,ffff800020b1b350) at sys_ioctl+0x5b9
syscall(ffff800020b1b3d0) at syscall+0x4a4 mi_syscall sys/sys/syscall_mi.h:92 [inline]
syscall(ffff800020b1b3d0) at syscall+0x4a4 sys/arch/amd64/amd64/trap.c:555
Xsyscall() at Xsyscall+0x128
end of kernel
end trace frame: 0x7f7ffffe3020, count: -10
ddb{0}> show registers
rdi                                0
rsi                              0x1
rbp               0xffff800020b1adb0
rbx               0xffff800020b1ae60
rdx                             0x8b
rcx                              0x2
rax                              0x1
r8                0xffffffff81dfe84f    kprintf+0x16f
r9                               0x1
r10               0x7736dfac603f6f46
r11               0xf665b2eda11a7d66
r12                     0x3000000008
r13               0xffff800020b1adc0
r14                            0x100
r15                              0x1
rip               0xffffffff81f3d998    db_enter+0x18
cs                               0x8
rflags                         0x246
rsp               0xffff800020b1ada0
ss                              0x10
db_enter+0x18:  addq    $0x8,%rsp
ddb{0}> show proc
PROC (syz-executor1752) pid=431504 stat=onproc
    flags process=2<EXEC> proc=0
    pri=55, usrpri=55, nice=20
    forw=0xffffffffffffffff, list=0xffff800020ad9158,0xffffffff82623980
    process=0xffff800020aa2e30 user=0xffff800020b16000, vmspace=0xfffffd806e7ac738
    estcpu=5, cpticks=1, pctcpu=0.0
    user=0, sys=1, intr=0
ddb{0}> ps
   PID     TID   PPID    UID  S       FLAGS  WAIT          COMMAND
*21063  431504   7484      0  7         0x2                syz-executor1752
  7484   33041  65764      0  3    0x10008a  pause         ksh
 65764  418029  79424      0  7        0x12                sshd
 70273  167258      1      0  3    0x100083  ttyin         getty
 79424   75019      1      0  3        0x80  select        sshd
 78750  521666  13035     74  3    0x100092  bpf           pflogd
 13035  492831      1      0  3        0x80  netio         pflogd
 60502  182800  16925     73  3    0x100090  kqread        syslogd
 16925  454247      1      0  3    0x100082  netio         syslogd
 55311  304130      1     77  3    0x100090  poll          dhclient
 48653    6440      1      0  3        0x80  poll          dhclient
  4473  397383      0      0  3     0x14200  pgzero        zerothread
 18039  500865      0      0  3     0x14200  aiodoned      aiodoned
    53  203989      0      0  3     0x14200  syncer        update
 68871   11892      0      0  3     0x14200  cleaner       cleaner
  6244  517957      0      0  3     0x14200  reaper        reaper
 55735  270555      0      0  3     0x14200  pgdaemon      pagedaemon
 74135  508795      0      0  3     0x14200  bored         crynlk
 66851  442842      0      0  3     0x14200  bored         crypto
 67467   32370      0      0  3  0x40014200  acpi0         acpi0
 73355  402318      0      0  3  0x40014200                idle1
 20275  316376      0      0  3     0x14200  bored         softnet
 41026  151323      0      0  3     0x14200  bored         systqmp
 45962  392753      0      0  3     0x14200  bored         systq
 99167  261102      0      0  3  0x40014200  bored         softclock
 48668   64127      0      0  3  0x40014200                idle0
  4338    1734      0      0  3     0x14200  bored         smr
     1  238076      0      0  3        0x82  wait          init
     0       0     -1      0  3     0x10200  scheduler     swapper
ddb{0}> show all locks
Process 21063 (syz-executor1752) thread 0xffff800020ad8010 (431504)
exclusive rwlock netlock r = 0 (0xffffffff82471638)
#0  witness_lock+0x52e sys/kern/subr_witness.c:1163
#1  pfioctl+0x15f sys/net/pf_ioctl.c:1028
#2  VOP_IOCTL+0x88 sys/kern/vfs_vops.c:291
#3  vn_ioctl+0xb7 sys/kern/vfs_vnops.c:533
#4  sys_ioctl+0x5b9
#5  syscall+0x4a4 mi_syscall sys/sys/syscall_mi.h:92 [inline]
#5  syscall+0x4a4 sys/arch/amd64/amd64/trap.c:555
#6  Xsyscall+0x128
exclusive kernel_lock &kernel_lock r = 0 (0xffffffff8261e160)
#0  witness_lock+0x52e sys/kern/subr_witness.c:1163
#1  syscall+0x400 mi_syscall sys/sys/syscall_mi.h:83 [inline]
#1  syscall+0x400 sys/arch/amd64/amd64/trap.c:555
#2  Xsyscall+0x128
Process 65764 (sshd) thread 0xffff800020ad98c0 (418029)
exclusive rwlock pipeglk r = 0 (0xffffffff824a30f0)
#0  witness_lock+0x52e sys/kern/subr_witness.c:1163
#1  pipe_read+0x1ac sys/kern/sys_pipe.c:409
#2  dofilereadv+0x1a2 sys/kern/sys_generic.c:236
#3  sys_read+0x83 sys/kern/sys_generic.c:156
#4  syscall+0x4a4 mi_syscall sys/sys/syscall_mi.h:92 [inline]
#4  syscall+0x4a4 sys/arch/amd64/amd64/trap.c:555
#5  Xsyscall+0x128
ddb{0}> show malloc
           Type InUse  MemUse  HighUse   Limit  Requests Type Lim
         devbuf  9461   6393K    6394K  78643K     10552        0
            pcb    13      8K       8K  78643K        13        0
         rtable    61      2K       2K  78643K       127        0
         ifaddr    29      8K       8K  78643K        30        0
       counters    39     33K      33K  78643K        39        0
       ioctlops     0      0K       4K  78643K      1467        0
          mount     1      1K       1K  78643K         1        0
         vnodes  1181     74K      74K  78643K      1186        0
      UFS quota     1     32K      32K  78643K         1        0
      UFS mount     5     36K      36K  78643K         5        0
            shm     2      1K       1K  78643K         2        0
         VM map     2      1K       1K  78643K         2        0
            sem     2      0K       0K  78643K         2        0
        dirhash    12      2K       2K  78643K        12        0
           ACPI  1809    196K     290K  78643K     12766        0
      file desc     1      0K       0K  78643K         1        0
           proc    59     63K      71K  78643K       358        0
    NFS srvsock     1      0K       0K  78643K         1        0
     NFS daemon     1     16K      16K  78643K         1        0
       in_multi    11      0K       0K  78643K        11        0
    ether_multi     1      0K       0K  78643K         1        0
    ISOFS mount     1     32K      32K  78643K         1        0
  MSDOSFS mount     1     16K      16K  78643K         1        0
           ttys    19     95K      95K  78643K        19        0
           exec     0      0K       1K  78643K       177        0
        pagedep     1      8K       8K  78643K         1        0
       inodedep     1     32K      32K  78643K         1        0
         newblk     1      0K       0K  78643K         1        0
        VM swap     7     26K      26K  78643K         7        0
       UVM amap    66      3K       4K  78643K       816        0
       UVM aobj     2      2K       2K  78643K         2        0
        memdesc     1      4K       4K  78643K         1        0
    crypto data     1      1K       1K  78643K         1        0
            NDP     4      0K       0K  78643K         4        0
           temp    26   3007K    3071K  78643K      1978        0
      SYN cache     2     16K      16K  78643K         2        0
ddb{0}> show all pools
Name      Size Requests Fail Releases Pgreq Pgrel Npage Hiwat Minpg Maxpg Idle
arp         64        2    0        0     1     0     1     1     0     8    0
plcache    128       20    0        0     1     0     1     1     0     8    0
rtpcb       80       15    0       13     1     0     1     1     0     8    0
rtentry    112       23    0        1     1     0     1     1     0     8    0
unpcb      120       29    0       19     1     0     1     1     0     8    0
syncache   264        5    0        5     1     0     1     1     0     8    1
tcpcb      544        8    0        5     1     0     1     1     0     8    0
inpcb      280       29    0       23     1     0     1     1     0     8    0
pfosfp      40      846    0      423     5     0     5     5     0     8    0
pfosfpen   112     1428    0      714    21     0    21    21     0     8    0
pfstitem    24        8    0        0     1     0     1     1     0     8    0
pfstkey    112        8    0        0     1     0     1     1     0     8    0
pfstate    328        8    0        0     1     0     1     1     0     8    0
pfrule     1360      21    0       16     2     1     1     2     0     8    0
art_heap8  4096       1    0        0     1     0     1     1     0     8    0
art_heap4  256       96    0        0     6     0     6     6     0     8    0
art_table   32       97    0        0     1     0     1     1     0     8    0
art_node    16       22    0        2     1     0     1     1     0     8    0
dirhash    1024      17    0        0     3     0     3     3     0     8    0
dino1pl    128     1401    0       16    45     0    45    45     0     8    0
ffsino     272     1401    0       16    93     0    93    93     0     8    0
nchpl      144     1577    0       34    58     0    58    58     0     8    0
uvmvnodes   72     1411    0        0    26     0    26    26     0     8    0
vnodes     208     1411    0        0    75     0    75    75     0     8    0
namei      1024    3773    0     3773     1     0     1     1     0     8    1
percpumem   16       30    0        0     1     0     1     1     0     8    0
scxspl     192     2519    0     2519     2     0     2     2     0     8    2
plimitpl   152       14    0        8     1     0     1     1     0     8    0
sigapl     432      204    0      192     2     0     2     2     0     8    0
knotepl    112        5    0        0     1     0     1     1     0     8    0
kqueuepl   104        1    0        0     1     0     1     1     0     8    0
pipepl     112      128    0      121     1     0     1     1     0     8    0
fdescpl    488      205    0      192     3     0     3     3     0     8    0
filepl     152      997    0      948     2     0     2     2     0     8    0
lockfpl    104        5    0        4     1     0     1     1     0     8    0
lockfspl    48        3    0        2     1     0     1     1     0     8    0
sessionpl  112       18    0        9     1     0     1     1     0     8    0
pgrppl      48       18    0        9     1     0     1     1     0     8    0
ucredpl     96       52    0       43     1     0     1     1     0     8    0
zombiepl   144      192    0      192     1     0     1     1     0     8    1
processpl  904      220    0      192     4     0     4     4     0     8    0
procpl     632      220    0      192     3     0     3     3     0     8    0
sockpl     384       73    0       55     2     0     2     2     0     8    0
mcl4k      4096       2    0        0     1     0     1     1     0     8    0
mcl2k      2048      72    0        0     9     0     9     9     0     8    0
mtagpl      80        2    0        0     1     0     1     1     0     8    0
mbufpl     256       90    0        0     6     0     6     6     0     8    0
bufpl      280     2200    0      274   138     0   138   138     0     8    0
anonpl      16    19267    0    18019     7     1     6     7     0   125    0
amapchunkpl 152     525    0      487     2     0     2     2     0   158    0
amappl16   192       30    0       28     1     0     1     1     0     8    0
amappl15   184       50    0       47     1     0     1     1     0     8    0
amappl14   176       15    0       14     1     0     1     1     0     8    0
amappl12   160        1    0        1     1     0     1     1     0     8    1
amappl11   152       53    0       38     1     0     1     1     0     8    0
amappl10   144        6    0        3     1     0     1     1     0     8    0
amappl9    136      420    0      419     1     0     1     1     0     8    0
amappl8    128       68    0       64     1     0     1     1     0     8    0
amappl7    120       76    0       68     1     0     1     1     0     8    0
amappl6    112       48    0       45     1     0     1     1     0     8    0
amappl5    104      135    0      119     1     0     1     1     0     8    0
amappl4     96      466    0      440     1     0     1     1     0     8    0
amappl3     88      108    0      101     1     0     1     1     0     8    0
amappl2     80      778    0      720     2     0     2     2     0     8    0
amappl1     72    13874    0    13449    15     3    12    15     0     8    2
amappl      80      408    0      387     1     0     1     1     0    84    0
dma4096    4096       1    0        1     1     1     0     1     0     8    0
dma256     256        6    0        6     1     1     0     1     0     8    0
dma128     128      253    0      253     1     1     0     1     0     8    0
dma64       64        6    0        6     1     1     0     1     0     8    0
dma32       32        7    0        7     1     1     0     1     0     8    0
dma16       16       18    0       17     1     0     1     1     0     8    0
aobjpl      64        1    0        0     1     0     1     1     0     8    0
uaddrrnd    24      205    0      192     1     0     1     1     0     8    0
uaddrbest   32        2    0        0     1     0     1     1     0     8    0
uaddr       24      205    0      192     1     0     1     1     0     8    0
vmmpekpl   168     5347    0     5326     1     0     1     1     0     8    0
vmmpepl    168    29796    0    28940    49     2    47    49     0   357    5
vmsppl     368      204    0      192     2     0     2     2     0     8    0
pdppl      4096     417    0      384     5     0     5     5     0     8    0
pvpl        32    79275    0    76270    29     0    29    29     0   265    2
pmappl     232      204    0      192     1     0     1     1     0     8    0
extentpl    40       46    0       29     1     0     1     1     0     8    0
phpool     112      136    0        3     4     0     4     4     0     8    0

Crashes (21):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Title
ci-openbsd-multicore 2020/01/03 11:41 openbsd e22fe1b6b6d2 9dcc1191 .config log report syz C
ci-openbsd-multicore 2020/01/03 11:09 openbsd e22fe1b6b6d2 9dcc1191 .config log report syz
ci-openbsd-multicore 2020/01/05 05:16 openbsd d9ef20e24f31 68256974 .config log report
ci-openbsd-main 2020/01/05 02:14 openbsd d9ef20e24f31 68256974 .config log report
ci-openbsd-multicore 2020/01/04 10:13 openbsd 8761fbd57358 68256974 .config log report
ci-openbsd-main 2020/01/04 04:15 openbsd 7945b8879d45 76d86b16 .config log report
ci-openbsd-main 2020/01/04 04:12 openbsd 7945b8879d45 76d86b16 .config log report
ci-openbsd-multicore 2020/01/04 03:55 openbsd 7945b8879d45 76d86b16 .config log report
ci-openbsd-multicore 2020/01/04 00:11 openbsd 7945b8879d45 76d86b16 .config log report
ci-openbsd-main 2020/01/03 22:59 openbsd 7945b8879d45 76d86b16 .config log report
ci-openbsd-main 2020/01/03 19:09 openbsd e22fe1b6b6d2 9dcc1191 .config log report
ci-openbsd-main 2020/01/03 18:47 openbsd e22fe1b6b6d2 9dcc1191 .config log report
ci-openbsd-main 2020/01/03 17:34 openbsd e22fe1b6b6d2 9dcc1191 .config log report
ci-openbsd-main 2020/01/03 17:13 openbsd e22fe1b6b6d2 9dcc1191 .config log report
ci-openbsd-multicore 2020/01/03 14:52 openbsd e22fe1b6b6d2 9dcc1191 .config log report
ci-openbsd-multicore 2020/01/03 13:19 openbsd e22fe1b6b6d2 9dcc1191 .config log report
ci-openbsd-multicore 2020/01/03 12:41 openbsd e22fe1b6b6d2 9dcc1191 .config log report
ci-openbsd-main 2020/01/03 12:19 openbsd e22fe1b6b6d2 9dcc1191 .config log report
ci-openbsd-multicore 2020/01/03 11:28 openbsd e22fe1b6b6d2 9dcc1191 .config log report
ci-openbsd-main 2020/01/03 11:27 openbsd e22fe1b6b6d2 9dcc1191 .config log report
ci-openbsd-multicore 2020/01/03 10:54 openbsd e22fe1b6b6d2 9dcc1191 .config log report
* Struck through repros no longer work on HEAD.