memory leak in tcindex_set

memory leak in tcindex_set_parms
Status: upstream: reported C repro on 2020/02/04 17:58
Reported-by: syzbot+f0bbb2287b8993d4fa74@syzkaller.appspotmail.com
First crash: 116d, last: 5d12h

Sample crash report:

executing program
BUG: memory leak
unreferenced object 0xffff8881180c7b00 (size 256):
  comm "syz-executor755", pid 6676, jiffies 4294941760 (age 13.390s)
  hex dump (first 32 bytes):
    00 78 8a 19 81 88 ff ff 00 00 00 00 00 00 00 00  .x..............
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<00000000b84bdad2>] kmalloc include/linux/slab.h:555 [inline]
    [<00000000b84bdad2>] kmalloc_array include/linux/slab.h:596 [inline]
    [<00000000b84bdad2>] kcalloc include/linux/slab.h:608 [inline]
    [<00000000b84bdad2>] tcf_exts_init include/net/pkt_cls.h:223 [inline]
    [<00000000b84bdad2>] tcindex_set_parms+0xb0/0x9b0 net/sched/cls_tcindex.c:339
    [<0000000009e58481>] tcindex_change+0xcf/0x110 net/sched/cls_tcindex.c:546
    [<000000004bb8be04>] tc_new_tfilter+0x4d1/0xda0 net/sched/cls_api.c:2169
    [<00000000928845ef>] rtnetlink_rcv_msg+0x3a5/0x4b0 net/core/rtnetlink.c:5445
    [<000000000a28add7>] netlink_rcv_skb+0x5a/0x180 net/netlink/af_netlink.c:2469
    [<00000000288b69e8>] netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
    [<00000000288b69e8>] netlink_unicast+0x20a/0x2f0 net/netlink/af_netlink.c:1329
    [<000000008bb60692>] netlink_sendmsg+0x2b5/0x560 net/netlink/af_netlink.c:1918
    [<00000000143353fa>] sock_sendmsg_nosec net/socket.c:652 [inline]
    [<00000000143353fa>] sock_sendmsg+0x4c/0x60 net/socket.c:672
    [<000000009eb18c09>] ____sys_sendmsg+0x2c0/0x2f0 net/socket.c:2362
    [<00000000456f3c85>] ___sys_sendmsg+0x8a/0xd0 net/socket.c:2416
    [<00000000ab40a212>] __sys_sendmsg+0x77/0xe0 net/socket.c:2449
    [<00000000ca8613f9>] do_syscall_64+0x6e/0x220 arch/x86/entry/common.c:295
    [<000000007a00f58e>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

BUG: memory leak
unreferenced object 0xffff8881180c7800 (size 256):
  comm "syz-executor755", pid 6676, jiffies 4294941760 (age 13.390s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<000000005f4ce791>] kmalloc include/linux/slab.h:555 [inline]
    [<000000005f4ce791>] kmalloc_array include/linux/slab.h:596 [inline]
    [<000000005f4ce791>] kcalloc include/linux/slab.h:608 [inline]
    [<000000005f4ce791>] tcf_exts_init include/net/pkt_cls.h:223 [inline]
    [<000000005f4ce791>] tcindex_alloc_perfect_hash net/sched/cls_tcindex.c:312 [inline]
    [<000000005f4ce791>] tcindex_alloc_perfect_hash+0x8e/0xf0 net/sched/cls_tcindex.c:302
    [<000000005407b6a5>] tcindex_set_parms+0x887/0x9b0 net/sched/cls_tcindex.c:433
    [<0000000009e58481>] tcindex_change+0xcf/0x110 net/sched/cls_tcindex.c:546
    [<000000004bb8be04>] tc_new_tfilter+0x4d1/0xda0 net/sched/cls_api.c:2169
    [<00000000928845ef>] rtnetlink_rcv_msg+0x3a5/0x4b0 net/core/rtnetlink.c:5445
    [<000000000a28add7>] netlink_rcv_skb+0x5a/0x180 net/netlink/af_netlink.c:2469
    [<00000000288b69e8>] netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
    [<00000000288b69e8>] netlink_unicast+0x20a/0x2f0 net/netlink/af_netlink.c:1329
    [<000000008bb60692>] netlink_sendmsg+0x2b5/0x560 net/netlink/af_netlink.c:1918
    [<00000000143353fa>] sock_sendmsg_nosec net/socket.c:652 [inline]
    [<00000000143353fa>] sock_sendmsg+0x4c/0x60 net/socket.c:672
    [<000000009eb18c09>] ____sys_sendmsg+0x2c0/0x2f0 net/socket.c:2362
    [<00000000456f3c85>] ___sys_sendmsg+0x8a/0xd0 net/socket.c:2416
    [<00000000ab40a212>] __sys_sendmsg+0x77/0xe0 net/socket.c:2449
    [<00000000ca8613f9>] do_syscall_64+0x6e/0x220 arch/x86/entry/common.c:295
    [<000000007a00f58e>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

BUG: memory leak
unreferenced object 0xffff8881180c7700 (size 256):
  comm "syz-executor755", pid 6676, jiffies 4294941760 (age 13.390s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<000000005f4ce791>] kmalloc include/linux/slab.h:555 [inline]
    [<000000005f4ce791>] kmalloc_array include/linux/slab.h:596 [inline]
    [<000000005f4ce791>] kcalloc include/linux/slab.h:608 [inline]
    [<000000005f4ce791>] tcf_exts_init include/net/pkt_cls.h:223 [inline]
    [<000000005f4ce791>] tcindex_alloc_perfect_hash net/sched/cls_tcindex.c:312 [inline]
    [<000000005f4ce791>] tcindex_alloc_perfect_hash+0x8e/0xf0 net/sched/cls_tcindex.c:302
    [<000000005407b6a5>] tcindex_set_parms+0x887/0x9b0 net/sched/cls_tcindex.c:433
    [<0000000009e58481>] tcindex_change+0xcf/0x110 net/sched/cls_tcindex.c:546
    [<000000004bb8be04>] tc_new_tfilter+0x4d1/0xda0 net/sched/cls_api.c:2169
    [<00000000928845ef>] rtnetlink_rcv_msg+0x3a5/0x4b0 net/core/rtnetlink.c:5445
    [<000000000a28add7>] netlink_rcv_skb+0x5a/0x180 net/netlink/af_netlink.c:2469
    [<00000000288b69e8>] netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
    [<00000000288b69e8>] netlink_unicast+0x20a/0x2f0 net/netlink/af_netlink.c:1329
    [<000000008bb60692>] netlink_sendmsg+0x2b5/0x560 net/netlink/af_netlink.c:1918
    [<00000000143353fa>] sock_sendmsg_nosec net/socket.c:652 [inline]
    [<00000000143353fa>] sock_sendmsg+0x4c/0x60 net/socket.c:672
    [<000000009eb18c09>] ____sys_sendmsg+0x2c0/0x2f0 net/socket.c:2362
    [<00000000456f3c85>] ___sys_sendmsg+0x8a/0xd0 net/socket.c:2416
    [<00000000ab40a212>] __sys_sendmsg+0x77/0xe0 net/socket.c:2449
    [<00000000ca8613f9>] do_syscall_64+0x6e/0x220 arch/x86/entry/common.c:295
    [<000000007a00f58e>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

Crashes (36):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	Maintainers
ci-upstream-gce-leak	2020/05/25 07:41	upstream	9cb1fd0e	11284182	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/05/23 03:15	upstream	051143e1	9682898d	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/05/20 09:56	upstream	3c9e6656	67fa1f59	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/05/17 06:33	upstream	3d1c1e59	37bccd4e	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/05/17 05:34	upstream	3d1c1e59	37bccd4e	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/05/16 15:26	upstream	12bf0b63	37bccd4e	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/05/11 01:17	upstream	e99332e7	8742a2b9	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/05/08 02:53	upstream	6e7f2eac	6c70a1c2	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/04/29 09:21	upstream	3f777e19	e3ecea2e	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/04/25 14:47	upstream	5ef58e29	b8bb8e5f	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/04/25 00:25	upstream	b4f63322	03d97a1b	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/04/22 09:51	upstream	189522da	2e44d63e	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/04/12 21:11	upstream	4f8a3cc1	36b0b050	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/04/11 09:37	upstream	ab6f762f	a8c6a3f8	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/04/07 07:25	upstream	7e634208	99a96044	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/04/01 19:49	upstream	1a323ea5	a34e2c33	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/03/30 02:13	upstream	e595dd94	05736b29	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/03/27 16:37	upstream	f3e69428	7d95711b	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/03/19 03:07	upstream	5076190d	0a96a13c	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/03/16 22:56	upstream	fb33c651	749688d2	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/03/16 05:25	upstream	a42a7bb6	749688d2	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/03/15 11:41	upstream	d3dca690	749688d2	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/03/15 00:44	upstream	69a4d0ba	749688d2	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/03/10 14:13	upstream	30bb5572	35f53e45	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/03/09 19:10	upstream	2c523b34	2e9971bb	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/03/07 04:36	upstream	fb279f4e	fd2a5f28	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/03/02 07:11	upstream	63623fd4	c88c7b75	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/02/22 22:36	upstream	54dedb5b	2c36e7a7	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/02/21 22:48	upstream	ca7e1fd1	2ffa6679	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/02/20 13:08	upstream	ca7e1fd1	81230308	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/02/16 16:35	upstream	db70e26e	cf914200	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/02/14 18:13	upstream	b19e8c68	5d7b90f1	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/02/04 10:12	upstream	322bf2d3	93e5e335	.config	log	report	syz	C	davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/03/22 10:09	upstream	b74b991f	78267cec	.config	log	report	syz		davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/03/21 17:39	upstream	5ad0ec0b	4288d95e	.config	log	report	syz		davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
ci-upstream-gce-leak	2020/03/16 12:09	upstream	a42a7bb6	749688d2	.config	log	report	syz		davem@davemloft.net, jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com