syzbot

=======================================================
ocfs2: Slot 0 on device (7,0) was already allocated to this node!
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.17/5983 is trying to acquire lock:
ffff888032a0c610 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_setattr+0x11c3/0x2560 fs/ocfs2/file.c:1263

but task is already holding lock:
ffff88805d52dbe0 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0x11b2/0x2560 fs/ocfs2/file.c:1262

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_alloc_sem){+.+.}-{4:4}:
       down_write+0x92/0x200 kernel/locking/rwsem.c:1590
       ocfs2_try_remove_refcount_tree+0xa7/0x320 fs/ocfs2/refcounttree.c:932
       ocfs2_xattr_set+0x1043/0x2a80 fs/ocfs2/xattr.c:3669
       ocfs2_set_acl+0x46d/0x550 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x224/0x2d0 fs/ocfs2/acl.c:286
       set_posix_acl+0x25f/0x320 fs/posix_acl.c:954
       vfs_remove_acl+0x33f/0x650 fs/posix_acl.c:1241
       ovl_do_remove_acl fs/overlayfs/overlayfs.h:355 [inline]
       ovl_workdir_create+0x55d/0xa40 fs/overlayfs/super.c:364
       ovl_make_workdir fs/overlayfs/super.c:679 [inline]
       ovl_get_workdir fs/overlayfs/super.c:837 [inline]
       ovl_fill_super+0xf1d/0x7130 fs/overlayfs/super.c:1468
       vfs_get_super fs/super.c:1331 [inline]
       get_tree_nodev+0xdd/0x190 fs/super.c:1350
       vfs_get_tree+0x8e/0x340 fs/super.c:1758
       fc_mount fs/namespace.c:1199 [inline]
       do_new_mount_fc fs/namespace.c:3642 [inline]
       do_new_mount fs/namespace.c:3718 [inline]
       path_mount+0x7b9/0x23a0 fs/namespace.c:4028
       do_mount fs/namespace.c:4041 [inline]
       __do_sys_mount fs/namespace.c:4229 [inline]
       __se_sys_mount fs/namespace.c:4206 [inline]
       __x64_sys_mount+0x293/0x310 fs/namespace.c:4206
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0xfa0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_read+0x9b/0x480 kernel/locking/rwsem.c:1537
       ocfs2_init_acl+0x2fc/0x7d0 fs/ocfs2/acl.c:366
       ocfs2_mknod+0xd5c/0x2540 fs/ocfs2/namei.c:413
       ocfs2_mkdir+0x17c/0x490 fs/ocfs2/namei.c:659
       vfs_mkdir+0x593/0x8c0 fs/namei.c:4453
       do_mkdirat+0x304/0x3e0 fs/namei.c:4486
       __do_sys_mkdirat fs/namei.c:4503 [inline]
       __se_sys_mkdirat fs/namei.c:4501 [inline]
       __x64_sys_mkdirat+0x83/0xb0 fs/namei.c:4501
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0xfa0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x5ea/0x1410 fs/jbd2/transaction.c:444
       jbd2__journal_start+0x394/0x6a0 fs/jbd2/transaction.c:501
       jbd2_journal_start+0x29/0x40 fs/jbd2/transaction.c:540
       ocfs2_start_trans+0x3b9/0x970 fs/ocfs2/journal.c:374
       ocfs2_mknod+0xc19/0x2540 fs/ocfs2/namei.c:364
       ocfs2_mkdir+0x17c/0x490 fs/ocfs2/namei.c:659
       vfs_mkdir+0x593/0x8c0 fs/namei.c:4453
       do_mkdirat+0x304/0x3e0 fs/namei.c:4486
       __do_sys_mkdirat fs/namei.c:4503 [inline]
       __se_sys_mkdirat fs/namei.c:4501 [inline]
       __x64_sys_mkdirat+0x83/0xb0 fs/namei.c:4501
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0xfa0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x9b/0x480 kernel/locking/rwsem.c:1537
       ocfs2_start_trans+0x3ae/0x970 fs/ocfs2/journal.c:372
       ocfs2_mknod+0xc19/0x2540 fs/ocfs2/namei.c:364
       ocfs2_mkdir+0x17c/0x490 fs/ocfs2/namei.c:659
       vfs_mkdir+0x593/0x8c0 fs/namei.c:4453
       do_mkdirat+0x304/0x3e0 fs/namei.c:4486
       __do_sys_mkdirat fs/namei.c:4503 [inline]
       __se_sys_mkdirat fs/namei.c:4501 [inline]
       __x64_sys_mkdirat+0x83/0xb0 fs/namei.c:4501
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0xfa0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (sb_internal#2){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x126f/0x1c90 kernel/locking/lockdep.c:5237
       lock_acquire kernel/locking/lockdep.c:5868 [inline]
       lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5825
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs.h:1916 [inline]
       sb_start_intwrite include/linux/fs.h:2099 [inline]
       ocfs2_start_trans+0x29d/0x970 fs/ocfs2/journal.c:370
       ocfs2_setattr+0x11c3/0x2560 fs/ocfs2/file.c:1263
       notify_change+0x6d2/0x12a0 fs/attr.c:546
       ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline]
       ovl_workdir_create+0x732/0xa40 fs/overlayfs/super.c:374
       ovl_make_workdir fs/overlayfs/super.c:679 [inline]
       ovl_get_workdir fs/overlayfs/super.c:837 [inline]
       ovl_fill_super+0xf1d/0x7130 fs/overlayfs/super.c:1468
       vfs_get_super fs/super.c:1331 [inline]
       get_tree_nodev+0xdd/0x190 fs/super.c:1350
       vfs_get_tree+0x8e/0x340 fs/super.c:1758
       fc_mount fs/namespace.c:1199 [inline]
       do_new_mount_fc fs/namespace.c:3642 [inline]
       do_new_mount fs/namespace.c:3718 [inline]
       path_mount+0x7b9/0x23a0 fs/namespace.c:4028
       do_mount fs/namespace.c:4041 [inline]
       __do_sys_mount fs/namespace.c:4229 [inline]
       __se_sys_mount fs/namespace.c:4206 [inline]
       __x64_sys_mount+0x293/0x310 fs/namespace.c:4206
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0xfa0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  sb_internal#2 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_alloc_sem);
                               lock(&oi->ip_xattr_sem);
                               lock(&oi->ip_alloc_sem);
  rlock(sb_internal#2);

 *** DEADLOCK ***

4 locks held by syz.0.17/5983:
 #0: ffff88807c3c00e0 (&type->s_umount_key#53/1){+.+.}-{4:4}, at: alloc_super+0x1e3/0xb60 fs/super.c:344
 #1: ffff888032a0c420 (sb_writers#12){.+.+}-{0:0}, at: ovl_make_workdir fs/overlayfs/super.c:675 [inline]
 #1: ffff888032a0c420 (sb_writers#12){.+.+}-{0:0}, at: ovl_get_workdir fs/overlayfs/super.c:837 [inline]
 #1: ffff888032a0c420 (sb_writers#12){.+.+}-{0:0}, at: ovl_fill_super+0xeee/0x7130 fs/overlayfs/super.c:1468
 #2: ffff88805d52df40 (&sb->s_type->i_mutex_key#22){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:980 [inline]
 #2: ffff88805d52df40 (&sb->s_type->i_mutex_key#22){+.+.}-{4:4}, at: ovl_workdir_create+0x6bc/0xa40 fs/overlayfs/super.c:373
 #3: ffff88805d52dbe0 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0x11b2/0x2560 fs/ocfs2/file.c:1262

stack backtrace:
CPU: 0 UID: 0 PID: 5983 Comm: syz.0.17 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x275/0x350 kernel/locking/lockdep.c:2043
 check_noncircular+0x14c/0x170 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x126f/0x1c90 kernel/locking/lockdep.c:5237
 lock_acquire kernel/locking/lockdep.c:5868 [inline]
 lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5825
 percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
 percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
 __sb_start_write include/linux/fs.h:1916 [inline]
 sb_start_intwrite include/linux/fs.h:2099 [inline]
 ocfs2_start_trans+0x29d/0x970 fs/ocfs2/journal.c:370
 ocfs2_setattr+0x11c3/0x2560 fs/ocfs2/file.c:1263
 notify_change+0x6d2/0x12a0 fs/attr.c:546
 ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline]
 ovl_workdir_create+0x732/0xa40 fs/overlayfs/super.c:374
 ovl_make_workdir fs/overlayfs/super.c:679 [inline]
 ovl_get_workdir fs/overlayfs/super.c:837 [inline]
 ovl_fill_super+0xf1d/0x7130 fs/overlayfs/super.c:1468
 vfs_get_super fs/super.c:1331 [inline]
 get_tree_nodev+0xdd/0x190 fs/super.c:1350
 vfs_get_tree+0x8e/0x340 fs/super.c:1758
 fc_mount fs/namespace.c:1199 [inline]
 do_new_mount_fc fs/namespace.c:3642 [inline]
 do_new_mount fs/namespace.c:3718 [inline]
 path_mount+0x7b9/0x23a0 fs/namespace.c:4028
 do_mount fs/namespace.c:4041 [inline]
 __do_sys_mount fs/namespace.c:4229 [inline]
 __se_sys_mount fs/namespace.c:4206 [inline]
 __x64_sys_mount+0x293/0x310 fs/namespace.c:4206
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xcd/0xfa0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f8faab8f749
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff4935dd38 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f8faade5fa0 RCX: 00007f8faab8f749
RDX: 0000200000000340 RSI: 00002000000000c0 RDI: 0000000000000000
RBP: 00007f8faac13f91 R08: 0000200000000080 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f8faade5fa0 R14: 00007f8faade5fa0 R15: 0000000000000005
 </TASK>
overlayfs: upper fs does not support tmpfile.
(syz.0.17,5983,0):ocfs2_find_entry:1094 ERROR: status = -117
(syz.0.17,5983,0):ocfs2_orphan_del:2396 ERROR: status = -117
(syz.0.17,5983,0):ocfs2_orphan_del:2418 ERROR: status = -117
(syz.0.17,5983,0):ocfs2_remove_inode:752 ERROR: status = -117
(syz.0.17,5983,0):ocfs2_wipe_inode:897 ERROR: status = -117
(syz.0.17,5983,0):ocfs2_delete_inode:1158 ERROR: status = -117
overlayfs: upper fs does not support RENAME_WHITEOUT.
overlayfs: upper fs missing required features.