possible deadlock in dquot

possible deadlock in dquot_commit
Status: upstream: reported on 2021/02/10 11:25
Reported-by: syzbot+3b6f9218b1301ddda3e2@syzkaller.appspotmail.com
First crash: 173d, last: 4d09h

similar bugs (2):
Kernel	Title	Repro	Cause bisect	Fix bisect	Count	Last	Reported	Patched	Status
linux-4.14	possible deadlock in dquot_commit	C			4	11d	79d	0/1	upstream: reported C repro on 2021/05/11 01:53
linux-4.19	possible deadlock in dquot_commit	C			14	1d16h	303d	0/1	upstream: reported C repro on 2020/09/29 12:02

Sample crash report:

loop4: detected capacity change from 0 to 4096
EXT4-fs (loop4): mounted filesystem without journal. Opts: ,errors=continue. Quota mode: writeback.
======================================================
WARNING: possible circular locking dependency detected
5.14.0-rc2-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.4/591 is trying to acquire lock:
ffff888090848b28 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_commit+0x4d/0x420 fs/quota/dquot.c:474

but task is already holding lock:
ffff888092b22a58 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x5e1/0x17d0 fs/ext4/inode.c:631

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&ei->i_data_sem/2){++++}-{3:3}:
       down_read+0x9a/0x440 kernel/locking/rwsem.c:1353
       ext4_map_blocks+0x381/0x17d0 fs/ext4/inode.c:561
       ext4_getblk+0x13c/0x680 fs/ext4/inode.c:848
       ext4_bread+0x2a/0x1c0 fs/ext4/inode.c:900
       ext4_quota_write+0x26b/0x680 fs/ext4/super.c:6602
       write_blk+0x12e/0x220 fs/quota/quota_tree.c:64
       get_free_dqblk+0x104/0x2c0 fs/quota/quota_tree.c:93
       do_insert_tree+0x63a/0x11f0 fs/quota/quota_tree.c:300
       do_insert_tree+0xd90/0x11f0 fs/quota/quota_tree.c:331
       do_insert_tree+0xd90/0x11f0 fs/quota/quota_tree.c:331
       do_insert_tree+0xd90/0x11f0 fs/quota/quota_tree.c:331
       dq_insert_tree fs/quota/quota_tree.c:357 [inline]
       qtree_write_dquot+0x3b0/0x570 fs/quota/quota_tree.c:376
       v2_write_dquot+0x11c/0x250 fs/quota/quota_v2.c:358
       dquot_acquire+0x2c5/0x590 fs/quota/dquot.c:441
       ext4_acquire_dquot+0x254/0x3b0 fs/ext4/super.c:6261
       dqget+0x679/0x1080 fs/quota/dquot.c:899
       __dquot_initialize+0x560/0xbe0 fs/quota/dquot.c:1477
       ext4_create+0x90/0x4d0 fs/ext4/namei.c:2731
       lookup_open.isra.0+0xfe4/0x13d0 fs/namei.c:3228
       open_last_lookups fs/namei.c:3298 [inline]
       path_openat+0x9b3/0x27f0 fs/namei.c:3504
       do_filp_open+0x1aa/0x400 fs/namei.c:3534
       do_sys_openat2+0x16d/0x420 fs/open.c:1204
       do_sys_open fs/open.c:1220 [inline]
       __do_sys_creat fs/open.c:1294 [inline]
       __se_sys_creat fs/open.c:1288 [inline]
       __x64_sys_creat+0xc9/0x120 fs/open.c:1288
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x44/0xae

-> #1 (&s->s_dquot.dqio_sem){++++}-{3:3}:
       down_read+0x9a/0x440 kernel/locking/rwsem.c:1353
       v2_read_dquot+0x49/0x120 fs/quota/quota_v2.c:332
       dquot_acquire+0x12e/0x590 fs/quota/dquot.c:432
       ext4_acquire_dquot+0x254/0x3b0 fs/ext4/super.c:6261
       dqget+0x679/0x1080 fs/quota/dquot.c:899
       __dquot_initialize+0x560/0xbe0 fs/quota/dquot.c:1477
       ext4_create+0x90/0x4d0 fs/ext4/namei.c:2731
       lookup_open.isra.0+0xfe4/0x13d0 fs/namei.c:3228
       open_last_lookups fs/namei.c:3298 [inline]
       path_openat+0x9b3/0x27f0 fs/namei.c:3504
       do_filp_open+0x1aa/0x400 fs/namei.c:3534
       do_sys_openat2+0x16d/0x420 fs/open.c:1204
       do_sys_open fs/open.c:1220 [inline]
       __do_sys_creat fs/open.c:1294 [inline]
       __se_sys_creat fs/open.c:1288 [inline]
       __x64_sys_creat+0xc9/0x120 fs/open.c:1288
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x44/0xae

-> #0 (&dquot->dq_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3051 [inline]
       check_prevs_add kernel/locking/lockdep.c:3174 [inline]
       validate_chain kernel/locking/lockdep.c:3789 [inline]
       __lock_acquire+0x2a07/0x54a0 kernel/locking/lockdep.c:5015
       lock_acquire kernel/locking/lockdep.c:5625 [inline]
       lock_acquire+0x1ab/0x510 kernel/locking/lockdep.c:5590
       __mutex_lock_common kernel/locking/mutex.c:959 [inline]
       __mutex_lock+0x12a/0x10a0 kernel/locking/mutex.c:1104
       dquot_commit+0x4d/0x420 fs/quota/dquot.c:474
       ext4_write_dquot+0x24e/0x310 fs/ext4/super.c:6245
       ext4_mark_dquot_dirty fs/ext4/super.c:6293 [inline]
       ext4_mark_dquot_dirty+0x111/0x1b0 fs/ext4/super.c:6287
       mark_dquot_dirty fs/quota/dquot.c:345 [inline]
       mark_all_dquot_dirty fs/quota/dquot.c:383 [inline]
       __dquot_alloc_space+0x5d4/0xb60 fs/quota/dquot.c:1707
       dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline]
       dquot_alloc_space include/linux/quotaops.h:310 [inline]
       dquot_alloc_block include/linux/quotaops.h:334 [inline]
       ext4_mb_new_blocks+0x5b3/0x5230 fs/ext4/mballoc.c:5477
       ext4_ext_map_blocks+0x1fa3/0x6070 fs/ext4/extents.c:4245
       ext4_map_blocks+0x653/0x17d0 fs/ext4/inode.c:638
       _ext4_get_block+0x241/0x590 fs/ext4/inode.c:794
       ext4_block_write_begin+0x503/0x1110 fs/ext4/inode.c:1077
       ext4_write_begin+0x4be/0x14c0 fs/ext4/inode.c:1201
       ext4_da_write_begin+0x686/0x11c0 fs/ext4/inode.c:2960
       generic_perform_write+0x202/0x500 mm/filemap.c:3656
       ext4_buffered_write_iter+0x244/0x4d0 fs/ext4/file.c:269
       ext4_file_write_iter+0x423/0x14e0 fs/ext4/file.c:680
       call_write_iter include/linux/fs.h:2114 [inline]
       new_sync_write+0x426/0x650 fs/read_write.c:518
       vfs_write+0x75a/0xa40 fs/read_write.c:605
       ksys_write+0x12d/0x250 fs/read_write.c:658
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x44/0xae

other info that might help us debug this:

Chain exists of:
  &dquot->dq_lock --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ei->i_data_sem/2);
                               lock(&s->s_dquot.dqio_sem);
                               lock(&ei->i_data_sem/2);
  lock(&dquot->dq_lock);

 *** DEADLOCK ***

5 locks held by syz-executor.4/591:
 #0: ffff8880664f6d70 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0xe9/0x100 fs/file.c:974
 #1: ffff888142f94460 (sb_writers#5){.+.+}-{0:0}, at: ksys_write+0x12d/0x250 fs/read_write.c:658
 #2: ffff888092b22c68 (&sb->s_type->i_mutex_key#10){++++}-{3:3}, at: inode_lock include/linux/fs.h:774 [inline]
 #2: ffff888092b22c68 (&sb->s_type->i_mutex_key#10){++++}-{3:3}, at: ext4_buffered_write_iter+0xb6/0x4d0 fs/ext4/file.c:263
 #3: ffff888092b22a58 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x5e1/0x17d0 fs/ext4/inode.c:631
 #4: ffffffff8bb36f38 (dquot_srcu){....}-{0:0}, at: i_dquot fs/quota/dquot.c:924 [inline]
 #4: ffffffff8bb36f38 (dquot_srcu){....}-{0:0}, at: __dquot_alloc_space+0x1b4/0xb60 fs/quota/dquot.c:1669

stack backtrace:
CPU: 1 PID: 591 Comm: syz-executor.4 Not tainted 5.14.0-rc2-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:105
 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2131
 check_prev_add kernel/locking/lockdep.c:3051 [inline]
 check_prevs_add kernel/locking/lockdep.c:3174 [inline]
 validate_chain kernel/locking/lockdep.c:3789 [inline]
 __lock_acquire+0x2a07/0x54a0 kernel/locking/lockdep.c:5015
 lock_acquire kernel/locking/lockdep.c:5625 [inline]
 lock_acquire+0x1ab/0x510 kernel/locking/lockdep.c:5590
 __mutex_lock_common kernel/locking/mutex.c:959 [inline]
 __mutex_lock+0x12a/0x10a0 kernel/locking/mutex.c:1104
 dquot_commit+0x4d/0x420 fs/quota/dquot.c:474
 ext4_write_dquot+0x24e/0x310 fs/ext4/super.c:6245
 ext4_mark_dquot_dirty fs/ext4/super.c:6293 [inline]
 ext4_mark_dquot_dirty+0x111/0x1b0 fs/ext4/super.c:6287
 mark_dquot_dirty fs/quota/dquot.c:345 [inline]
 mark_all_dquot_dirty fs/quota/dquot.c:383 [inline]
 __dquot_alloc_space+0x5d4/0xb60 fs/quota/dquot.c:1707
 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline]
 dquot_alloc_space include/linux/quotaops.h:310 [inline]
 dquot_alloc_block include/linux/quotaops.h:334 [inline]
 ext4_mb_new_blocks+0x5b3/0x5230 fs/ext4/mballoc.c:5477
 ext4_ext_map_blocks+0x1fa3/0x6070 fs/ext4/extents.c:4245
 ext4_map_blocks+0x653/0x17d0 fs/ext4/inode.c:638
 _ext4_get_block+0x241/0x590 fs/ext4/inode.c:794
 ext4_block_write_begin+0x503/0x1110 fs/ext4/inode.c:1077
 ext4_write_begin+0x4be/0x14c0 fs/ext4/inode.c:1201
 ext4_da_write_begin+0x686/0x11c0 fs/ext4/inode.c:2960
 generic_perform_write+0x202/0x500 mm/filemap.c:3656
 ext4_buffered_write_iter+0x244/0x4d0 fs/ext4/file.c:269
 ext4_file_write_iter+0x423/0x14e0 fs/ext4/file.c:680
 call_write_iter include/linux/fs.h:2114 [inline]
 new_sync_write+0x426/0x650 fs/read_write.c:518
 vfs_write+0x75a/0xa40 fs/read_write.c:605
 ksys_write+0x12d/0x250 fs/read_write.c:658
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x4665e9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f7f2422b188 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 000000000056bf80 RCX: 00000000004665e9
RDX: 000000000d4ba0ff RSI: 00000000200009c0 RDI: 0000000000000004
RBP: 00000000004bfcc4 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 000000000056bf80
R13: 00007ffc58f488ef R14: 00007f7f2422b300 R15: 0000000000022000

Crashes (13):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	VM info	Title
ci-upstream-kasan-gce-root	2021/07/25 03:32	upstream	6498f6151825	4d1b57d4	.config	log	report	info	possible deadlock in dquot_commit
ci-upstream-kasan-gce-smack-root	2021/06/21 18:08	upstream	13311e74253f	aba2b2fb	.config	log	report	info	possible deadlock in dquot_commit
ci-upstream-kasan-gce-root	2021/05/25 00:44	upstream	1434a3127887	3c7fef33	.config	log	report	info	possible deadlock in dquot_commit
ci-upstream-kasan-gce-smack-root	2021/05/16 00:00	upstream	c12a29ed9094	f54a5c09	.config	log	report	info	possible deadlock in dquot_commit
ci-upstream-kasan-gce-root	2021/05/11 12:51	upstream	1140ab592e2e	ca873091	.config	log	report	info	possible deadlock in dquot_commit
ci-upstream-kasan-gce-root	2021/05/09 10:52	upstream	b741596468b0	bc5434be	.config	log	report	info	possible deadlock in dquot_commit
ci-upstream-kasan-gce-selinux-root	2021/05/04 17:02	upstream	d2b6f8a17919	09efdd63	.config	log	report	info	possible deadlock in dquot_commit
ci-upstream-kasan-gce-root	2021/04/12 01:33	upstream	7d900724913c	bfeda1b1	.config	log	report	info	possible deadlock in dquot_commit
ci-upstream-kasan-gce-selinux-root	2021/02/06 11:23	upstream	1e0d27fce010	23a562df	.config	log	report	info	possible deadlock in dquot_commit
ci-upstream-linux-next-kasan-gce-root	2021/05/10 02:05	linux-next	e6f67ebd93ef	bc5434be	.config	log	report	info	possible deadlock in dquot_commit
ci-upstream-linux-next-kasan-gce-root	2021/03/02 13:17	linux-next	92f791ebd25b	92ead296	.config	log	report	info	possible deadlock in dquot_commit
ci-qemu2-riscv64	2021/06/17 19:51	git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git fixes	18a3c5f7abfd	aba2b2fb	.config	log	report	info	possible deadlock in dquot_commit
ci-qemu2-riscv64	2021/05/02 09:08	git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git fixes	18a3c5f7abfd	77e2b668	.config	log	report	info	possible deadlock in dquot_commit