syzbot


possible deadlock in hfsplus_file_extend

Status: upstream: reported C repro on 2022/11/26 08:07
Reported-by: syzbot+325b61d3c9a17729454b@syzkaller.appspotmail.com
First crash: 72d, last: 21m

Cause bisection: failed (bisect log)
similar bugs (2):
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.14 possible deadlock in hfsplus_file_extend hfsplus C 3 3d03h 39d 0/1 upstream: reported C repro on 2022/12/29 06:07
linux-4.19 possible deadlock in hfsplus_file_extend hfsplus C 198 2h04m 72d 0/1 upstream: reported C repro on 2022/11/26 10:00

Sample crash report:
loop0: detected capacity change from 0 to 1024
======================================================
WARNING: possible circular locking dependency detected
6.1.0-syzkaller-14594-g72a85e2b0a1e #0 Not tainted
------------------------------------------------------
syz-executor426/5071 is trying to acquire lock:
ffff88802b0d87c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1bf/0xf60 fs/hfsplus/extents.c:457

but task is already holding lock:
ffff88802adcc0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x1bb/0x230 fs/hfsplus/bfind.c:30

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&tree->tree_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x12f/0x1360 kernel/locking/mutex.c:747
       hfsplus_file_truncate+0xe87/0x10d0 fs/hfsplus/extents.c:595
       hfsplus_setattr+0x1f2/0x320 fs/hfsplus/inode.c:269
       notify_change+0xca7/0x1420 fs/attr.c:482
       do_truncate+0x143/0x200 fs/open.c:65
       handle_truncate fs/namei.c:3216 [inline]
       do_open fs/namei.c:3561 [inline]
       path_openat+0x2157/0x2a50 fs/namei.c:3714
       do_filp_open+0x1ba/0x410 fs/namei.c:3741
       do_sys_openat2+0x16d/0x4c0 fs/open.c:1310
       do_sys_open fs/open.c:1326 [inline]
       __do_sys_creat fs/open.c:1402 [inline]
       __se_sys_creat fs/open.c:1396 [inline]
       __x64_sys_creat+0xcd/0x120 fs/open.c:1396
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3097 [inline]
       check_prevs_add kernel/locking/lockdep.c:3216 [inline]
       validate_chain kernel/locking/lockdep.c:3831 [inline]
       __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055
       lock_acquire kernel/locking/lockdep.c:5668 [inline]
       lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x12f/0x1360 kernel/locking/mutex.c:747
       hfsplus_file_extend+0x1bf/0xf60 fs/hfsplus/extents.c:457
       hfsplus_bmap_reserve+0x31c/0x410 fs/hfsplus/btree.c:358
       hfsplus_rename_cat+0x271/0x1270 fs/hfsplus/catalog.c:456
       hfsplus_rename+0x11d/0x210 fs/hfsplus/dir.c:552
       vfs_rename+0x1162/0x1a90 fs/namei.c:4779
       do_renameat2+0xb22/0xc30 fs/namei.c:4930
       __do_sys_renameat2 fs/namei.c:4963 [inline]
       __se_sys_renameat2 fs/namei.c:4960 [inline]
       __x64_sys_renameat2+0xe8/0x120 fs/namei.c:4960
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&tree->tree_lock);
                               lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&tree->tree_lock);
  lock(&HFSPLUS_I(inode)->extents_lock);

 *** DEADLOCK ***

7 locks held by syz-executor426/5071:
 #0: ffff88802adc8460 (sb_writers#9){.+.+}-{0:0}, at: do_renameat2+0x37f/0xc30 fs/namei.c:4866
 #1: ffff88802adc8748 (&type->s_vfs_rename_key){+.+.}-{3:3}, at: lock_rename+0x58/0x280 fs/namei.c:2994
 #2: ffff88802b0d9e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline]
 #2: ffff88802b0d9e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: lock_rename+0xa4/0x280 fs/namei.c:2998
 #3: ffff8880761a09c0 (&sb->s_type->i_mutex_key#15/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline]
 #3: ffff8880761a09c0 (&sb->s_type->i_mutex_key#15/2){+.+.}-{3:3}, at: lock_rename+0xd8/0x280 fs/namei.c:2999
 #4: ffff8880761a1740 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline]
 #4: ffff8880761a1740 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: lock_two_nondirectories+0xf0/0x110 fs/inode.c:1121
 #5: ffff8880761a1e00 (&sb->s_type->i_mutex_key#15/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline]
 #5: ffff8880761a1e00 (&sb->s_type->i_mutex_key#15/4){+.+.}-{3:3}, at: lock_two_nondirectories+0xd5/0x110 fs/inode.c:1123
 #6: ffff88802adcc0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x1bb/0x230 fs/hfsplus/bfind.c:30

stack backtrace:
CPU: 0 PID: 5071 Comm: syz-executor426 Not tainted 6.1.0-syzkaller-14594-g72a85e2b0a1e #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd1/0x138 lib/dump_stack.c:106
 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2177
 check_prev_add kernel/locking/lockdep.c:3097 [inline]
 check_prevs_add kernel/locking/lockdep.c:3216 [inline]
 validate_chain kernel/locking/lockdep.c:3831 [inline]
 __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055
 lock_acquire kernel/locking/lockdep.c:5668 [inline]
 lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x12f/0x1360 kernel/locking/mutex.c:747
 hfsplus_file_extend+0x1bf/0xf60 fs/hfsplus/extents.c:457
 hfsplus_bmap_reserve+0x31c/0x410 fs/hfsplus/btree.c:358
 hfsplus_rename_cat+0x271/0x1270 fs/hfsplus/catalog.c:456
 hfsplus_rename+0x11d/0x210 fs/hfsplus/dir.c:552
 vfs_rename+0x1162/0x1a90 fs/namei.c:4779
 do_renameat2+0xb22/0xc30 fs/namei.c:4930
 __do_sys_renameat2 fs/namei.c:4963 [inline]
 __se_sys_renameat2 fs/namei.c:4960 [inline]
 __x64_sys_renameat2+0xe8/0x120 fs/namei.c:4960
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fb4ff0bc9f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffdd0f88598 EFLAGS: 00000246 ORIG_RAX: 000000000000013c
RAX: ffffffffffffffda RBX: 2f30656c69662f2e RCX: 00007fb4ff0bc9f9
RDX: 0000000000000007 RSI: 00000000200001c0 RDI: 0000000000000007
RBP: 00007fb4ff07c290 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000200002c0 R11: 0000000000000246 R12: 00007fb4ff07c32

Crashes (1291):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Title
ci-upstream-kasan-gce-root 2022/12/25 02:26 upstream 72a85e2b0a1e 9da18ae8 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in hfsplus_file_extend
ci-upstream-kasan-gce-root 2022/12/23 13:59 upstream 8395ae05cb5a 9da18ae8 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2022/12/20 19:44 upstream 6feb57c2fd7c d3e76707 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in hfsplus_file_extend
ci-upstream-kasan-gce-root 2022/12/11 04:15 upstream 296a7b7eb792 67be1ae7 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2022/12/02 08:18 upstream ef4d3ea40565 e080de16 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in hfsplus_file_extend
ci-upstream-linux-next-kasan-gce-root 2023/01/19 03:34 linux-next f3381a7baf5c 42660d9e .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in hfsplus_file_extend
ci-upstream-linux-next-kasan-gce-root 2023/01/08 03:01 linux-next cc3c08b41a9c 1dac8c7a .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/06 10:34 upstream 4ec5183ec486 be607b78 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/06 06:58 upstream 4ec5183ec486 be607b78 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/05 23:28 upstream 4ec5183ec486 be607b78 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/05 19:40 upstream 837c07cf68fe be607b78 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci-upstream-kasan-gce-smack-root 2023/02/05 08:34 upstream 95078069c1e7 be607b78 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci-upstream-kasan-gce-selinux-root 2023/02/05 04:54 upstream 95078069c1e7 be607b78 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/04 22:01 upstream db27c22251e7 be607b78 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci-upstream-kasan-gce-smack-root 2023/02/04 17:54 upstream 0136d86b7852 be607b78 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/04 14:17 upstream 0136d86b7852 be607b78 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/04 08:16 upstream 0136d86b7852 1b2f701a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/04 07:05 upstream 0136d86b7852 1b2f701a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/04 04:04 upstream 0136d86b7852 1b2f701a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/04 02:57 upstream 66a87fff1a87 1b2f701a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/03 23:15 upstream 66a87fff1a87 1b2f701a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/03 21:53 upstream 66a87fff1a87 1b2f701a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/03 17:35 upstream 66a87fff1a87 1b2f701a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/03 14:39 upstream 66a87fff1a87 1b2f701a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/03 12:03 upstream e7368fd30165 1b2f701a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci-upstream-kasan-gce-root 2023/02/03 09:37 upstream 66a87fff1a87 16d19e30 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/03 08:19 upstream e7368fd30165 33fc5c09 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/03 02:49 upstream e7368fd30165 33fc5c09 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/02 22:20 upstream e7368fd30165 16d19e30 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci-upstream-kasan-gce-smack-root 2023/02/02 16:08 upstream 9f266ccaa2f5 16d19e30 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/02 14:14 upstream 9f266ccaa2f5 16d19e30 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/02 14:11 upstream 9f266ccaa2f5 16d19e30 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/02 01:51 upstream 9f266ccaa2f5 9a6f477c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/01 21:11 upstream c0b67534c95c 9a6f477c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/01 19:12 upstream c0b67534c95c 9a6f477c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci-upstream-kasan-gce-smack-root 2023/02/01 17:44 upstream c0b67534c95c 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/01 16:12 upstream c0b67534c95c 9a6f477c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci-upstream-kasan-gce-root 2023/02/01 14:51 upstream c0b67534c95c 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/01 11:22 upstream c0b67534c95c 9a6f477c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/01 10:18 upstream c0b67534c95c 9a6f477c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/01 04:08 upstream 22b8077d0fce b68fb8d6 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/02/01 00:26 upstream 22b8077d0fce b68fb8d6 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/01/31 22:54 upstream 22b8077d0fce b68fb8d6 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2023/01/31 16:07 upstream 22b8077d0fce b68fb8d6 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci-qemu-upstream 2023/01/26 02:51 upstream 7c46948a6e9c 7374c4e5 .config console log report info possible deadlock in hfsplus_file_extend
ci-upstream-kasan-gce-root 2022/11/26 01:51 upstream 0b1dcc2cf55a 74a66371 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci2-upstream-fs 2022/11/25 23:54 upstream 08ad43d554ba f4470a7b .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci-qemu-upstream-386 2023/01/19 02:48 upstream 7287904c8771 66fca3ae .config console log report info possible deadlock in hfsplus_file_extend
ci-upstream-gce-arm64 2023/02/06 08:22 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci ca72d58361ee be607b78 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci-upstream-gce-arm64 2023/02/05 21:23 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci ca72d58361ee be607b78 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci-upstream-gce-arm64 2023/02/05 17:32 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci ca72d58361ee be607b78 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci-upstream-gce-arm64 2023/02/05 16:21 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci ca72d58361ee be607b78 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci-upstream-gce-arm64 2023/02/05 12:40 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci ca72d58361ee be607b78 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci-upstream-gce-arm64 2023/02/05 10:19 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci ca72d58361ee be607b78 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci-upstream-gce-arm64 2023/02/04 16:14 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci ca72d58361ee be607b78 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci-upstream-gce-arm64 2023/02/02 10:00 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci ca72d58361ee 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
ci-upstream-gce-arm64 2023/02/01 22:17 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci ca72d58361ee 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in hfsplus_file_extend
* Struck through repros no longer work on HEAD.